[2/2] pinctrl: qcom: spmi-gpio: Mark expected switch fall-through

Message ID 20190726112816.19723-1-anders.roxell@linaro.org
State Accepted
Commit 6161dc03587b8057b97c61aa3a2f8b16562d8991
Headers show
Series
  • Untitled series #22219
Related show

Commit Message

Anders Roxell July 26, 2019, 11:28 a.m.
When fall-through warnings was enabled by default the following warnings
was starting to show up:

../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c: In function ‘pmic_gpio_populate’:
../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:815:20: warning: this statement may fall
 through [-Wimplicit-fallthrough=]
   pad->have_buffer = true;
   ~~~~~~~~~~~~~~~~~^~~~~~
../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:816:2: note: here
  case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
  ^~~~
../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:820:20: warning: this statement may fall
 through [-Wimplicit-fallthrough=]
   pad->have_buffer = true;
   ~~~~~~~~~~~~~~~~~^~~~~~
../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:821:2: note: here
  case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
  ^~~~

Rework so that the compiler doesn't warn about fall-through.

Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.20.1

Comments

Linus Walleij Aug. 5, 2019, 10:33 a.m. | #1
On Fri, Jul 26, 2019 at 1:28 PM Anders Roxell <anders.roxell@linaro.org> wrote:

> When fall-through warnings was enabled by default the following warnings

> was starting to show up:

>

> ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c: In function ‘pmic_gpio_populate’:

> ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:815:20: warning: this statement may fall

>  through [-Wimplicit-fallthrough=]

>    pad->have_buffer = true;

>    ~~~~~~~~~~~~~~~~~^~~~~~

> ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:816:2: note: here

>   case PMIC_GPIO_SUBTYPE_GPIOC_4CH:

>   ^~~~

> ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:820:20: warning: this statement may fall

>  through [-Wimplicit-fallthrough=]

>    pad->have_buffer = true;

>    ~~~~~~~~~~~~~~~~~^~~~~~

> ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:821:2: note: here

>   case PMIC_GPIO_SUBTYPE_GPIOC_8CH:

>   ^~~~

>

> Rework so that the compiler doesn't warn about fall-through.

>

> Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


Patch applied.

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f39da87ea185..ebf33f65c1bc 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -813,11 +813,13 @@  static int pmic_gpio_populate(struct pmic_gpio_state *state,
 	switch (subtype) {
 	case PMIC_GPIO_SUBTYPE_GPIO_4CH:
 		pad->have_buffer = true;
+		/* Fall through */
 	case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
 		pad->num_sources = 4;
 		break;
 	case PMIC_GPIO_SUBTYPE_GPIO_8CH:
 		pad->have_buffer = true;
+		/* Fall through */
 	case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
 		pad->num_sources = 8;
 		break;