| Message ID | 20190730093733.31861-1-suzuki.poulose@arm.com |
|---|---|
| State | Accepted |
| Commit | 82451bbd540f5254b1f5b655d2183469f2b0a7a7 |
| Headers | show |
| Series | None | expand |
On Tue, 30 Jul 2019 at 03:37, Suzuki K Poulose <suzuki.poulose@arm.com> wrote: > > We warn the users of obsolete bindings in the DT for coresight replicator > and funnel drivers. However we use pr_warn_once() which doesn't give a clue > about which device it is bound to. Let us use dev_warn_once() to give the > context. > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > > Changes since previous version: > - Update replicator driver too. > --- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index fa97cb9ab4f9..84ca30f4e5ec 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) > > if (is_of_node(dev_fwnode(dev)) && > of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) > - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); > + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); > > desc.name = coresight_alloc_device_name(&funnel_devs, dev); > if (!desc.name) > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index b7d6d59d56db..b29ba640eb25 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -184,7 +184,8 @@ static int replicator_probe(struct device *dev, struct resource *res) > > if (is_of_node(dev_fwnode(dev)) && > of_device_is_compatible(dev->of_node, "arm,coresight-replicator")) > - pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n"); > + dev_warn_once(dev, > + "Uses OBSOLETE CoreSight replicator binding\n"); Applied - thanks Mathieu > > desc.name = coresight_alloc_device_name(&replicator_devs, dev); > if (!desc.name) > -- > 2.21.0 >
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index fa97cb9ab4f9..84ca30f4e5ec 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -192,7 +192,7 @@ static int funnel_probe(struct device *dev, struct resource *res) if (is_of_node(dev_fwnode(dev)) && of_device_is_compatible(dev->of_node, "arm,coresight-funnel")) - pr_warn_once("Uses OBSOLETE CoreSight funnel binding\n"); + dev_warn_once(dev, "Uses OBSOLETE CoreSight funnel binding\n"); desc.name = coresight_alloc_device_name(&funnel_devs, dev); if (!desc.name) diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b7d6d59d56db..b29ba640eb25 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -184,7 +184,8 @@ static int replicator_probe(struct device *dev, struct resource *res) if (is_of_node(dev_fwnode(dev)) && of_device_is_compatible(dev->of_node, "arm,coresight-replicator")) - pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n"); + dev_warn_once(dev, + "Uses OBSOLETE CoreSight replicator binding\n"); desc.name = coresight_alloc_device_name(&replicator_devs, dev); if (!desc.name)
We warn the users of obsolete bindings in the DT for coresight replicator and funnel drivers. However we use pr_warn_once() which doesn't give a clue about which device it is bound to. Let us use dev_warn_once() to give the context. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- Changes since previous version: - Update replicator driver too. --- drivers/hwtracing/coresight/coresight-funnel.c | 2 +- drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.21.0