| Message ID | 20190731174820.16459-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | cbbfac2a330ad5577a56b5d0fe74300acff287f8 |
| Headers | show |
| Series | [1/2] libedit: Move from meta-oe | expand |
On Wed, 31 Jul 2019 at 19:48, Khem Raj <raj.khem@gmail.com> wrote: > +UPSTREAM_CHECK_REGEX = "libedit-(?P<pver>\d+(\.\d+)+)\.tar.gz" > The recipe in meta-oe did not have this line. Where did you take it from and how did you test it? It is incorrect as it does not match anything with a dash (-) in it. Simply dropping the line makes the version check work again. Alex <div dir="ltr"><div dir="ltr">On Wed, 31 Jul 2019 at 19:48, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+UPSTREAM_CHECK_REGEX = "libedit-(?P<pver>\d+(\.\d+)+)\.tar.gz"<br></blockquote><div><br></div><div>The recipe in meta-oe did not have this line. Where did you take it from and how did you test it? It is incorrect as it does not match anything with a dash (-) in it.</div><div>Simply dropping the line makes the version check work again.<br></div><div><br></div><div>Alex<br></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Mon, Aug 5, 2019 at 4:34 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > On Wed, 31 Jul 2019 at 19:48, Khem Raj <raj.khem@gmail.com> wrote: > >> +UPSTREAM_CHECK_REGEX = "libedit-(?P<pver>\d+(\.\d+)+)\.tar.gz" >> > > The recipe in meta-oe did not have this line. Where did you take it from > and how did you test it? It is incorrect as it does not match anything with > a dash (-) in it. > Simply dropping the line makes the version check work again. > Yes it was left over of some trying thanks for finding it I will send a patch > > Alex > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 5, 2019 at 4:34 AM Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com">alex.kanavin@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, 31 Jul 2019 at 19:48, Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+UPSTREAM_CHECK_REGEX = "libedit-(?P<pver>\d+(\.\d+)+)\.tar.gz"<br></blockquote><div><br></div><div>The recipe in meta-oe did not have this line. Where did you take it from and how did you test it? It is incorrect as it does not match anything with a dash (-) in it.</div><div>Simply dropping the line makes the version check work again.<br></div><div></div></div></div></blockquote><div dir="auto"><br></div><div dir="auto">Yes it was left over of some trying thanks for finding it I will send a patch </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Alex<br></div></div></div> </blockquote></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 77af8b6dad..201130e771 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -326,6 +326,7 @@ RECIPE_MAINTAINER_pn-libdazzle = "Alexander Kanavin <alex.kanavin@gmail.com>" RECIPE_MAINTAINER_pn-libdmx = "Armin Kuster <akuster808@gmail.com>" RECIPE_MAINTAINER_pn-libdnf = "Alexander Kanavin <alex.kanavin@gmail.com>" RECIPE_MAINTAINER_pn-libdrm = "Otavio Salvador <otavio.salvador@ossystems.com.br>" +RECIPE_MAINTAINER_pn-libedit = "Khem Raj <raj.khem@gmail.com>" RECIPE_MAINTAINER_pn-libepoxy = "Anuj Mittal <anuj.mittal@intel.com>" RECIPE_MAINTAINER_pn-liberation-fonts = "Alexander Kanavin <alex.kanavin@gmail.com>" RECIPE_MAINTAINER_pn-liberror-perl = "Tim Orling <timothy.t.orling@linux.intel.com>" diff --git a/meta/recipes-devtools/libedit/libedit/stdc-predef.patch b/meta/recipes-devtools/libedit/libedit/stdc-predef.patch new file mode 100644 index 0000000000..75ef308fad --- /dev/null +++ b/meta/recipes-devtools/libedit/libedit/stdc-predef.patch @@ -0,0 +1,18 @@ +__STDC_ISO_10646__ is defined in stdc-predef.h +therefore include it to see if its there on a platform + +Upstream-Status: Pending +Signed-off-by: Khem Raj <raj.khem@gmail.com> + +Index: libedit-20160903-3.1/src/chartype.h +=================================================================== +--- libedit-20160903-3.1.orig/src/chartype.h ++++ libedit-20160903-3.1/src/chartype.h +@@ -29,6 +29,7 @@ + #ifndef _h_chartype_f + #define _h_chartype_f + ++#include <stdc-predef.h> + /* Ideally we should also test the value of the define to see if it + * supports non-BMP code points without requiring UTF-16, but nothing + * seems to actually advertise this properly, despite Unicode 3.1 having diff --git a/meta/recipes-devtools/libedit/libedit_20190324-3.1.bb b/meta/recipes-devtools/libedit/libedit_20190324-3.1.bb new file mode 100644 index 0000000000..01e7f36009 --- /dev/null +++ b/meta/recipes-devtools/libedit/libedit_20190324-3.1.bb @@ -0,0 +1,23 @@ +SUMMARY = "BSD replacement for libreadline" +DESCRIPTION = "Command line editor library providing generic line editing, \ +history, and tokenization functions" +HOMEPAGE = "http://www.thrysoee.dk/editline/" +SECTION = "libs" +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://COPYING;md5=1e4228d0c5a9093b01aeaaeae6641533" + +DEPENDS = "ncurses" + +inherit autotools + +# upstream site does not allow wget's User-Agent +FETCHCMD_wget += "-U bitbake" +SRC_URI = "http://www.thrysoee.dk/editline/${BP}.tar.gz \ + file://stdc-predef.patch \ + " +SRC_URI[md5sum] = "bec755c8044ad84b752dfe49a0b371d8" +SRC_URI[sha256sum] = "ac8f0f51c1cf65492e4d1e3ed2be360bda41e54633444666422fbf393bba1bae" + +UPSTREAM_CHECK_REGEX = "libedit-(?P<pver>\d+(\.\d+)+)\.tar.gz" + +BBCLASSEXTEND = "native nativesdk"
libedit is needed by llvm on linux and this makes it useful for both oe-core and clang layer among other users Thanks to various contributors in maintaing it in meta-oe Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/conf/distro/include/maintainers.inc | 1 + .../libedit/libedit/stdc-predef.patch | 18 +++++++++++++++ .../libedit/libedit_20190324-3.1.bb | 23 +++++++++++++++++++ 3 files changed, 42 insertions(+) create mode 100644 meta/recipes-devtools/libedit/libedit/stdc-predef.patch create mode 100644 meta/recipes-devtools/libedit/libedit_20190324-3.1.bb -- 2.22.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core