[01/11] ALSA: pxa2xx-ac97: Remove redundant platform_set_drvdata()

Message ID 1369039124-32590-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Commit 54d672e922cdb7e015a22a3a2c096dcac5ba284f
Headers show

Commit Message

Sachin Kamat May 20, 2013, 8:38 a.m.
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Eric Miao <eric.y.miao@gmail.com>
---
 sound/arm/pxa2xx-ac97.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Mark Brown May 20, 2013, 6:46 p.m. | #1
On Mon, May 20, 2013 at 02:08:34PM +0530, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.

Always CC maintainers on patches...
Takashi Iwai May 23, 2013, 12:37 p.m. | #2
At Mon, 20 May 2013 14:08:34 +0530,
Sachin Kamat wrote:
> 
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Eric Miao <eric.y.miao@gmail.com>

Thanks, applied all 11 patches.


Takashi

> ---
>  sound/arm/pxa2xx-ac97.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
> index ec54be4..ce431e6 100644
> --- a/sound/arm/pxa2xx-ac97.c
> +++ b/sound/arm/pxa2xx-ac97.c
> @@ -230,7 +230,6 @@ static int pxa2xx_ac97_remove(struct platform_device *dev)
>  
>  	if (card) {
>  		snd_card_free(card);
> -		platform_set_drvdata(dev, NULL);
>  		pxa2xx_ac97_hw_remove(dev);
>  	}
>  
> -- 
> 1.7.9.5
>

Patch

diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index ec54be4..ce431e6 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -230,7 +230,6 @@  static int pxa2xx_ac97_remove(struct platform_device *dev)
 
 	if (card) {
 		snd_card_free(card);
-		platform_set_drvdata(dev, NULL);
 		pxa2xx_ac97_hw_remove(dev);
 	}