[v2] net: sched: sch_taprio: fix memleak in error path for sched list parse

Message ID 20190806224540.24912-1-ivan.khoronzhuk@linaro.org
State New
Headers show
Series
  • [v2] net: sched: sch_taprio: fix memleak in error path for sched list parse
Related show

Commit Message

Ivan Khoronzhuk Aug. 6, 2019, 10:45 p.m.
In error case, all entries should be freed from the sched list
before deleting it. For simplicity use rcu way.

Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler")
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

---
 net/sched/sch_taprio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

David Miller Aug. 9, 2019, 5:01 a.m. | #1
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

Date: Wed,  7 Aug 2019 01:45:40 +0300

> In error case, all entries should be freed from the sched list

> before deleting it. For simplicity use rcu way.

> 

> Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler")

> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>


Applied and queued up for -stable, thank you.

Patch

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index c39db507ba3f..e25d414ae12f 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1195,7 +1195,8 @@  static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
 	spin_unlock_bh(qdisc_lock(sch));
 
 free_sched:
-	kfree(new_admin);
+	if (new_admin)
+		call_rcu(&new_admin->rcu, taprio_free_sched_cb);
 
 	return err;
 }