gpio: pca953x: Include the right header

Message ID 20190808132020.15470-1-linus.walleij@linaro.org
State New
Headers show
Series
  • gpio: pca953x: Include the right header
Related show

Commit Message

Linus Walleij Aug. 8, 2019, 1:20 p.m.
This LED chip provides a GPIO driver, so include
<linux/gpio/driver.h> rather than the legacy header
<linux/gpio.h>.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/leds/leds-pca9532.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.21.0

Comments

Jacek Anaszewski Aug. 8, 2019, 6:50 p.m. | #1
Hi Linus,

Thank you for the patch.

On 8/8/19 3:20 PM, Linus Walleij wrote:
> This LED chip provides a GPIO driver, so include

> <linux/gpio/driver.h> rather than the legacy header

> <linux/gpio.h>.

> 

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  drivers/leds/leds-pca9532.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c

> index 290871072d65..c7c7199e8ebd 100644

> --- a/drivers/leds/leds-pca9532.c

> +++ b/drivers/leds/leds-pca9532.c

> @@ -16,7 +16,7 @@

>  #include <linux/mutex.h>

>  #include <linux/workqueue.h>

>  #include <linux/leds-pca9532.h>

> -#include <linux/gpio.h>

> +#include <linux/gpio/driver.h>

>  #include <linux/of.h>

>  #include <linux/of_device.h>


I've changed the patch title prefix to "leds: pca953x:" -
(this is for leds-pca9532.c driver) and applied.

-- 
Best regards,
Jacek Anaszewski

Patch

diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 290871072d65..c7c7199e8ebd 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -16,7 +16,7 @@ 
 #include <linux/mutex.h>
 #include <linux/workqueue.h>
 #include <linux/leds-pca9532.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <linux/of.h>
 #include <linux/of_device.h>