From patchwork Wed Aug 14 21:49:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 171375 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1368283ily; Wed, 14 Aug 2019 14:49:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgPl15i2vrAudq4KbQNg4Ntj8JHwVmK8zF9kPlQYNuFCBiTNAhzQjLfqQx/KYo+rZuETgP X-Received: by 2002:a17:902:bf4c:: with SMTP id u12mr1284749pls.317.1565819397305; Wed, 14 Aug 2019 14:49:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565819397; cv=none; d=google.com; s=arc-20160816; b=t4j68B7NZYtbfTnqR5W9Q1EFPZ+nxhDjXblgN4eYyzbbf9gFZlNm2Cuo4MoKnRPp+4 mAxLewW6K1waQjOELFgRpv48wDiqk6JLFt7NDdRb0iK9G4zUFDeZs6MgwaPr6tbkZE0/ fU7PzvMdZfs8BMGRh4oiWrAyRiOLa3t8/2RuocUjq+MQjTchIRgc4dgU7VkOoRWyVO1y qSsoiRNY1n72vMyjkhxqvWBR+Kr9Cypc6a24WDRv+/Nie6RbntwiKj89UO9FHLELp9KH dc7drx90Ir4sdUSodNPXggTx6J4h644o1gCMhsKiQ58miV7Dxy+uPh6b4VI3ahzBdEoR 8cKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=quNqjepPTnacbRHb7c2eVenKYgne2iNuWND1D+zRC8U=; b=ZzEuNeD7HDO1oh3UPP926MBOf+txXx0ahP/CrZysP7GAJDNzXMXdsZ8FgDw+m3IzgA WOpNxCqoXLvl+AX19STt20uPha975icJpF6876STZgTAHm9xhlu7Wo7lfzMmIpK5XlQ5 4OA+PV4CTcB44EAG5NaNETt7ZAPGb5jCKZWcNAXdI1XpTtlJRMM962xdEyLcNqPua5me KcEBb7t1UVyL3TegTR2IprxavO/u8HuLGfpNGMqR7Z4Bf0leRRbGA8f8yb6jAvXiingU 4Gf9nKTCI6a/r2mv/VSODpxdY+tcye5rjDBH+fKKforfpKKIGD9fU6Hhi/fpUKfjzpJd WeHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sUjGo9yX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2si542152pff.169.2019.08.14.14.49.56; Wed, 14 Aug 2019 14:49:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sUjGo9yX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729508AbfHNVtz (ORCPT + 28 others); Wed, 14 Aug 2019 17:49:55 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37276 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728252AbfHNVtz (ORCPT ); Wed, 14 Aug 2019 17:49:55 -0400 Received: by mail-lf1-f67.google.com with SMTP id c9so347485lfh.4 for ; Wed, 14 Aug 2019 14:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=quNqjepPTnacbRHb7c2eVenKYgne2iNuWND1D+zRC8U=; b=sUjGo9yXU26Huey71Nv31NVxbfEQLci9On0kv2+ROoSDiFng0MELV4XmPa++4r0itW S5eWusmIAQMYTWT+1aGb4zEKFcnCYhWdDl+pGNDkM1RSxyeMjCdvmcu3q2o/2pUdi6UF DYPar1pHFv5KdFyV+Bu9Y501HsDE6mDRsdR39XWmJJhDySt3K/BsWTkoKw3Xh7QQYFj/ O6req7zP9ZrhPa3rgIPBNu/n5wLAByRkzhzjvucDhDsLct1uEYj0qsmdcKIcxsqpsH6C ujz1gIvbPaMPB4Prv16krM7VDSlAFA4YPLD8H7yInX2sgJNZFZ4ySRsnEAfODauihknM tNSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=quNqjepPTnacbRHb7c2eVenKYgne2iNuWND1D+zRC8U=; b=EygyzoEs7TfBqO6FbruCIVgFepEa2KYP/eSCOC66un0pIPQEKQsrCF5tjtbvDveTmo xd8ow/GQ5gYyHAZSX8M0bhFw8P+OItRrIgeQ/9gfJJLyzof1/MKd0eW2tj32PZ7kwOzM B9+kwITepEaibtL66eqytp9ZczUjEb2CFPZKWLf1wt6Ifw9n6taQatNFydEsf5kivGfK KxSCqSVob15AwX0MssUL+9AYPeoGDTZfzpSl6rG5ceJhrL2Q60bvYcuQlx43k8mECoGv Mxe3+rUmqt5kJlwfYkNt7SBNP5mOxuInrsYdriQsnuI0PH96yIFKREzUbqt3Oi5x7S7Y oBUA== X-Gm-Message-State: APjAAAUlwsnYBebqlLUOCF/iOsP0v3QMN16FzGYGJpE/X8z76FfBN/zE KqBcciUmDauQ94+X3R5U4y2jdqmEsFgejw== X-Received: by 2002:ac2:484e:: with SMTP id 14mr783405lfy.50.1565819393263; Wed, 14 Aug 2019 14:49:53 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id z30sm132722lfj.63.2019.08.14.14.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 14:49:52 -0700 (PDT) From: Anders Roxell To: davem@davemloft.net, shuah@kernel.org Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue Date: Wed, 14 Aug 2019 23:49:48 +0200 Message-Id: <20190814214948.5571-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When running tcp_fastopen_backup_key.sh the following issue was seen in a busybox environment. ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected Shellcheck showed the following issue. $ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33: if [ $val -ne 0 ]; then ^-- SC2086: Double quote to prevent globbing and word splitting. Rework to add double quotes around the variable 'val' that shellcheck recommends. Signed-off-by: Anders Roxell --- tools/testing/selftests/net/tcp_fastopen_backup_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.sh b/tools/testing/selftests/net/tcp_fastopen_backup_key.sh index 41476399e184..ba5ec3eb314e 100755 --- a/tools/testing/selftests/net/tcp_fastopen_backup_key.sh +++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.sh @@ -30,7 +30,7 @@ do_test() { ip netns exec "${NETNS}" ./tcp_fastopen_backup_key "$1" val=$(ip netns exec "${NETNS}" nstat -az | \ grep TcpExtTCPFastOpenPassiveFail | awk '{print $2}') - if [ $val -ne 0 ]; then + if [ "$val" -ne 0 ]; then echo "FAIL: TcpExtTCPFastOpenPassiveFail non-zero" return 1 fi