[Xen-devel] xen/arm: domain_build: Print the correct domain in construct_domain()

Message ID 20190815173533.26310-1-julien.grall@arm.com
State New
Headers show
Series
  • [Xen-devel] xen/arm: domain_build: Print the correct domain in construct_domain()
Related show

Commit Message

Julien Grall Aug. 15, 2019, 5:35 p.m.
construct_domain() can be called by other domain than dom0. To avoid
confusion in the log, print the correct domain.

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/domain_build.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Volodymyr Babchuk Aug. 16, 2019, 4:30 p.m. | #1
Julien Grall writes:

> construct_domain() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

> ---
>  xen/arch/arm/domain_build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 33171081ea..cf9ffbc360 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1978,7 +1978,7 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo)
>          cpu = cpumask_cycle(cpu, &cpu_online_map);
>          if ( vcpu_create(d, i, cpu) == NULL )
>          {
> -            printk("Failed to allocate dom0 vcpu %d on pcpu %d\n", i, cpu);
> +            printk("Failed to allocate %pd vcpu %d on pcpu %d\n", d, i, cpu);
>              break;
>          }
Stefano Stabellini Oct. 2, 2019, 1:18 a.m. | #2
On Thu, 15 Aug 2019, Julien Grall wrote:
> construct_domain() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
>  xen/arch/arm/domain_build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 33171081ea..cf9ffbc360 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1978,7 +1978,7 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo)
>          cpu = cpumask_cycle(cpu, &cpu_online_map);
>          if ( vcpu_create(d, i, cpu) == NULL )
>          {
> -            printk("Failed to allocate dom0 vcpu %d on pcpu %d\n", i, cpu);
> +            printk("Failed to allocate %pd vcpu %d on pcpu %d\n", d, i, cpu);
>              break;
>          }
>  
> -- 
> 2.11.0
>

Patch

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 33171081ea..cf9ffbc360 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1978,7 +1978,7 @@  static int __init construct_domain(struct domain *d, struct kernel_info *kinfo)
         cpu = cpumask_cycle(cpu, &cpu_online_map);
         if ( vcpu_create(d, i, cpu) == NULL )
         {
-            printk("Failed to allocate dom0 vcpu %d on pcpu %d\n", i, cpu);
+            printk("Failed to allocate %pd vcpu %d on pcpu %d\n", d, i, cpu);
             break;
         }