From patchwork Sun Aug 18 09:39:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 171570 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1586530ily; Sun, 18 Aug 2019 02:39:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2E2HXkDxuaviv/PSFFWC5coRMAS3gSS/bAtVj7RMe2Sy4irEiWcef+K0QujSTJ5e+LZ1J X-Received: by 2002:a17:90a:29c5:: with SMTP id h63mr14856979pjd.83.1566121182328; Sun, 18 Aug 2019 02:39:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566121182; cv=none; d=google.com; s=arc-20160816; b=wVqIH8O8qllVPSY4fXyAbtp2gi44c4RG2xOfxPz8RGvqJuxqYvLkX/d6/DTuvY6yUe 79GB4OzuSs9ye8TuCEwUiy6WvCUdHrs22/s7xzMZ6w7X1ivOMnY09yAGnQ2EdGhjhVin z9izJakhyibF/Rs/vXy8TxJ5ggo2c8YcSWrdxxldyq+QemvLM2oIfKIlDLGM2/tksL8g IIB2+SbATX7DDWXBeuw8Cl9LWnwznGINyIcsKX4yNKTsNyOVGjJ6gO+LLTsZ6fbOb6rU cFK+g31n07cKUzQ88kAkh51sI9xsIUyA4YyjvlcVlJVc27zaPZI8lrYdkZgnuIJ9vLm3 2Dfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rg3pEHV16wLjiiBOFWW/dTYF5vTRUDPNa6t2gdjPdGA=; b=tDKeNZwzfctUmnDPcHX6Sa4K5AdIy6WKhrQvaVc8/+xldKoTC3vd8CE8nZxHWvG0Qi U5a/yPtVp0IEGisqCIR59joWtQzTiY9ODZQkGCYAYs7MEfJ36dcv2V0KFxekITgDmJ1b okqHtDhoQKFtvaHBmIQpws8XUHEP1fDmhA5bHlr+JV/toqOjQjYy96m1k6qrBilxC6mY 7IAOw4mCkYPsMs/RAB0t0wI9Fte66GerzTRg+IWCuKZT3ZUj9T/18f04XDZYk2vs5t3f eQpfXDlBiBb4odWZn2WN31xQUilDIvCLByCLFphpn0Rj/ya4VLYedkPH4yRquRdxfICM UC1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NLu0z+7H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 186si8027837pfd.44.2019.08.18.02.39.41; Sun, 18 Aug 2019 02:39:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NLu0z+7H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbfHRJjk (ORCPT + 28 others); Sun, 18 Aug 2019 05:39:40 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46448 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbfHRJjg (ORCPT ); Sun, 18 Aug 2019 05:39:36 -0400 Received: by mail-wr1-f65.google.com with SMTP id z1so5624193wru.13 for ; Sun, 18 Aug 2019 02:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rg3pEHV16wLjiiBOFWW/dTYF5vTRUDPNa6t2gdjPdGA=; b=NLu0z+7HcZtQ5E/s2TTT31YxW33bhq1OM6Jbn8gx3N6vVZwa6dV4GKgtJWpYE0Y8iX Af7LE5YSYR3HLIhEPcNhrrbx/ZeYeA+Ky2BsRfIA0B7kftnROmGUKYJjw0LY2dtNPdPD o7yubU76uZV1dOK1xkST5Uw6FzxbOOJ/ABOBdtzeRudaiyU5gx1AzhQwgeQSgNdAXqi/ lFikJQUjoy+meao7yFKMUH5UNphdINmKUEDo1Lli3jNj1ziUx3ZDkyzQibzEVZX6rXvZ PQYgfFPH7rSRfSy/YqB4f6seeNtwV9mameJ0yZg/mxdwCteA0mq/UctNlO0I43G16zk5 EBLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rg3pEHV16wLjiiBOFWW/dTYF5vTRUDPNa6t2gdjPdGA=; b=GM2rFUaicdBeiC5mXjPEL4SAHiycvd0mPKagZydKIeqLTVHLjt3Mj7QytqDB2Zyhjj L1A6xTt8qLgK8mxitR12G5e43+Ukh20+r4PdbM1WJYd0MskZCzSNzVx7ir0PKUOer+aI V4dybACFZuR5R8rj0DXgNCfO02vvD1xQnMEZO+XG/Twk+pYTeIV3y9Hc2sNSNslKFHX6 RJ+M4xU1GqAQGGr+qKbCXpO0F+lJauy0Y1cCGt/PKkxbmPuUHQ5ah/MeeHugi/cyZ1/Q vHkMRSnK4gg0h7PeMwDUxP/wLi1+9OIqVeprs9uNBc0ZtDOlpZjf6/8HnXV5GfPxF/Tl E1Nw== X-Gm-Message-State: APjAAAUwjuWpq4vlA2BpfzBg1vduTBiLBZq5tMypnQXt3DOhd97m46j8 sP2SLIpAu4lyZpGPhEPAjqVH1A== X-Received: by 2002:a5d:62c1:: with SMTP id o1mr20366778wrv.293.1566121173997; Sun, 18 Aug 2019 02:39:33 -0700 (PDT) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id q3sm11520190wma.48.2019.08.18.02.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2019 02:39:33 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Srinivas Kandagatla , Hariprasad Kelam Subject: [PATCH 2/2] slimbus: fix slim_tid_txn() Date: Sun, 18 Aug 2019 10:39:02 +0100 Message-Id: <20190818093902.29993-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190818093902.29993-1-srinivas.kandagatla@linaro.org> References: <20190818093902.29993-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or || Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE is command which requires transaction ID, so fix it, this also fix the warning. Reported-by: Hariprasad Kelam Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/slimbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0 diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 9be41089edde..b2f013bfe42e 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -439,7 +439,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc) (mc == SLIM_MSG_MC_REQUEST_INFORMATION || mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION || mc == SLIM_MSG_MC_REQUEST_VALUE || - mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION)); + mc == SLIM_MSG_MC_REQUEST_CHANGE_VALUE)); } static inline bool slim_ec_txn(u8 mt, u8 mc)