[v2] pinctrl: st: Include the right header

Message ID 20190820111135.10701-1-linus.walleij@linaro.org
State New
Headers show
Series
  • [v2] pinctrl: st: Include the right header
Related show

Commit Message

Linus Walleij Aug. 20, 2019, 11:11 a.m.
The ST pinctrl driver wants to provode a gpio_chip but is not
including the header for this, fix the inclusion to use the right
header. <linux/of_gpio.h> has to remain as the driver is calling
of_get_named_gpio().

Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v1->v2:
- Include <linux/of_gpio.h> again, the driver is indeed using
  it.
- Add an explanatory comment.
---
 drivers/pinctrl/pinctrl-st.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.21.0

Comments

Patrice CHOTARD Aug. 26, 2019, 7:41 a.m. | #1
Hi Linus

On 8/20/19 1:11 PM, Linus Walleij wrote:
> The ST pinctrl driver wants to provode a gpio_chip but is not

> including the header for this, fix the inclusion to use the right

> header. <linux/of_gpio.h> has to remain as the driver is calling

> of_get_named_gpio().

>

> Cc: Patrice Chotard <patrice.chotard@st.com>

> Cc: Maxime Coquelin <maxime.coquelin@st.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

> ChangeLog v1->v2:

> - Include <linux/of_gpio.h> again, the driver is indeed using

>   it.

> - Add an explanatory comment.

> ---

>  drivers/pinctrl/pinctrl-st.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c

> index b9688ea548da..25236b716fb3 100644

> --- a/drivers/pinctrl/pinctrl-st.c

> +++ b/drivers/pinctrl/pinctrl-st.c

> @@ -12,8 +12,9 @@

>  #include <linux/io.h>

>  #include <linux/of.h>

>  #include <linux/of_irq.h>

> -#include <linux/of_gpio.h>

> +#include <linux/of_gpio.h> /* of_get_named_gpio() */

>  #include <linux/of_address.h>

> +#include <linux/gpio/driver.h>

>  #include <linux/regmap.h>

>  #include <linux/mfd/syscon.h>

>  #include <linux/pinctrl/pinctrl.h>



Reviewed-by: Patrice Chotard <patrice.chotard@st.com>


Thanks

Patch

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index b9688ea548da..25236b716fb3 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -12,8 +12,9 @@ 
 #include <linux/io.h>
 #include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/of_gpio.h>
+#include <linux/of_gpio.h> /* of_get_named_gpio() */
 #include <linux/of_address.h>
+#include <linux/gpio/driver.h>
 #include <linux/regmap.h>
 #include <linux/mfd/syscon.h>
 #include <linux/pinctrl/pinctrl.h>