From patchwork Wed Aug 21 03:55:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 171904 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp416788ily; Tue, 20 Aug 2019 20:56:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwV0e2kgatepb0JxI7As9z/ypp4vpvshWYqmH30oEbK/Z3lTXspUR+XfOpgWpo6GNVy9tg6 X-Received: by 2002:a65:4b8b:: with SMTP id t11mr27448725pgq.130.1566359766033; Tue, 20 Aug 2019 20:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566359766; cv=none; d=google.com; s=arc-20160816; b=j1g0ovre/dSKcT0hi+v0JlhZVhuJWCStsOQGgfj1mAqxQs7n5E36LrtbzYaIcKQntX QT1RNWIQ96nZdvezZRTkfECp0NIJQOhrTH60cr22IE36K4gmHTCndIxmTfwS8U5c0uMg 385v88LWPE+Ldru2rV88yqM1ru7G6xkeY1Bl8vpXzK9ZtLfr4fsgRCwR2MZEmRxmJMIc SRynHiaDVxsB77Eu2Yw0p4im2iIFOPjkAc5ijOHnKPBJ7WL/qKtgZyrvbQnW0aBnwojV 8Rzozl2wRJ8UDFTtwKP1ccNoBwGBn0E/4+RTpkCgJsWWFb8j38KxTAie+U1HBanemZvK V/kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=xvzRaJpfAiuO+5/j+Hz3YB5Qx9ImeceBGGq+CyKuQ7k=; b=WcyefmyolumFChJ5wTy664PWlDAgGgN/fQn/dv7o4P5oGaCQ0Hz4jOIFv8oo/atzL2 Mqb8qPYCInrr+SDFzDAhrkyPgt5Q6j/ZYxqa8sYV77g0St7puvaTZudItKSFWeJkf9za 7DQnfslaKplRJgqtZJyHUydynLwOiwjPuvS/2/OfKP/9ZiOTGWPh48BzD4YALOmF+djD OCjEnLAj4mlGzlt9UUr8/CJudO+7u0HcxZA6x5M1kCl8MOle5YxQ1Vc9v4gVEtELmyAh /4QKuL2WgfnPjDTZw0YFyhJDKMwI4M/sedAI+z8NH0XsQxuhtDkgzVIyp2GdmFkOr8AO E6Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Wa3+nU5B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q38si13696877pgk.63.2019.08.20.20.56.05; Tue, 20 Aug 2019 20:56:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Wa3+nU5B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfHUDz4 (ORCPT + 28 others); Tue, 20 Aug 2019 23:55:56 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:17893 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726693AbfHUDzy (ORCPT ); Tue, 20 Aug 2019 23:55:54 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x7L3tQp3016439; Wed, 21 Aug 2019 12:55:28 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x7L3tQp3016439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1566359728; bh=xvzRaJpfAiuO+5/j+Hz3YB5Qx9ImeceBGGq+CyKuQ7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wa3+nU5BGO15eyxz0lR5bIn9rwZ+2mjRIYim+iLMokOLIkpJs39HjD4Myi/Ao98hq x6P5m2dqGM4Xs0ynb4eSTpu4eZsabnZi25M6MOLBeSNSHbW+ltJYl0ZKKi1WC/nswO FWDm5tNeP5UZkEWbjqdkmoQ2LNBTw9iLkQPVKpL0YVte6K6Sri3igN7yzfqCEn6LHB oQlnxf/gVIikOijXjjvndkr7dj1LJg3ci3pfshNAIIVPjKftzdxGc7wuB9etDJENDI IbufhIOK0fj85Nb9hHEaxwiA9YWkA1ks0y+m+H6wZP9RTuPnkXwfrFhBqWvxKmO9pr JKUI+JjrERlkA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Geert Uytterhoeven , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] video/logo: fix unneeded generation of font C files Date: Wed, 21 Aug 2019 12:55:14 +0900 Message-Id: <20190821035517.21671-3-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190821035517.21671-1-yamada.masahiro@socionext.com> References: <20190821035517.21671-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, all the font C files are generated irrespective of CONFIG options. Adding them to extra-y is wrong. What we need to do here is to add them to 'targets' so that if_changed works properly. All files listed in 'targets' are cleaned, so clean-files is unneeded. Signed-off-by: Masahiro Yamada --- drivers/video/logo/Makefile | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) -- 2.17.1 diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile index 10b75ce3ce09..16f60c1e1766 100644 --- a/drivers/video/logo/Makefile +++ b/drivers/video/logo/Makefile @@ -18,23 +18,6 @@ obj-$(CONFIG_SPU_BASE) += logo_spe_clut224.o # How to generate logo's -# Use logo-cfiles to retrieve list of .c files to be built -logo-cfiles = $(notdir $(patsubst %.$(2), %.c, \ - $(wildcard $(srctree)/$(src)/*$(1).$(2)))) - - -# Mono logos -extra-y += $(call logo-cfiles,_mono,pbm) - -# VGA16 logos -extra-y += $(call logo-cfiles,_vga16,ppm) - -# 224 Logos -extra-y += $(call logo-cfiles,_clut224,ppm) - -# Gray 256 -extra-y += $(call logo-cfiles,_gray256,pgm) - pnmtologo := scripts/pnmtologo # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..." @@ -55,5 +38,5 @@ $(obj)/%_clut224.c: $(src)/%_clut224.ppm $(pnmtologo) FORCE $(obj)/%_gray256.c: $(src)/%_gray256.pgm $(pnmtologo) FORCE $(call if_changed,logo) -# Files generated that shall be removed upon make clean -clean-files := *_mono.c *_vga16.c *_clut224.c *_gray256.c +# generated C files +targets += *_mono.c *_vga16.c *_clut224.c *_gray256.c