ACPICA: Remove redundant macro defines for ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW()

Message ID 51A08098.1090807@linaro.org
State New
Headers show

Commit Message

Hanjun Guo May 25, 2013, 9:12 a.m.
In commit 0377b5acba2 (ACPICA: Merge all debug output macros into
a single file, acoutput.), the patch introduces redundant macro
defines for ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW(), just
remove it.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 include/acpi/acoutput.h | 2 --
 1 file changed, 2 deletions(-)

-- 1.8.2.1

Comments

Moore, Robert May 28, 2013, 5:07 p.m. | #1
This was fixed some time ago in the main ACPICA source, and should have made it into Linux by now.


> -----Original Message-----
> From: Hanjun Guo [mailto:hanjun.guo@linaro.org]
> Sent: Saturday, May 25, 2013 2:13 AM
> To: Zheng, Lv
> Cc: Wysocki, Rafael J; Moore, Robert; linux-acpi@vger.kernel.org;
> patches@linaro.org; linaro-kernel@lists.linaro.org; Jiang Liu
> Subject: [PATCH] ACPICA: Remove redundant macro defines for
> ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW()
> 
> In commit 0377b5acba2 (ACPICA: Merge all debug output macros into a single
> file, acoutput.), the patch introduces redundant macro defines for
> ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW(), just remove it.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  include/acpi/acoutput.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/acpi/acoutput.h b/include/acpi/acoutput.h index
> 4f52ea7..e1c7474 100644
> --- a/include/acpi/acoutput.h
> +++ b/include/acpi/acoutput.h
> @@ -447,8 +447,6 @@
>  #define ACPI_DUMP_TABLES(a, b)
>  #define ACPI_DUMP_PATHNAME(a, b, c, d)
>  #define ACPI_DUMP_BUFFER(a, b)
> -#define ACPI_DEBUG_PRINT(pl)
> -#define ACPI_DEBUG_PRINT_RAW(pl)
>  #define ACPI_IS_DEBUG_ENABLED(level, component) 0
> 
>  /* Return macros must have a return statement at the minimum */
> -- 1.8.2.1
Hanjun Guo May 29, 2013, 10 a.m. | #2
On 2013-5-29 1:07, Moore, Robert wrote:
> This was fixed some time ago in the main ACPICA source, and should have made it into Linux by now.

Ok, I noticed the ACPICA patch set sent out today by Lv Zheng,
and it is fixed in this patch set.

Thanks
Hanjun Guo

> 
> 
>> -----Original Message-----
>> From: Hanjun Guo [mailto:hanjun.guo@linaro.org]
>> Sent: Saturday, May 25, 2013 2:13 AM
>> To: Zheng, Lv
>> Cc: Wysocki, Rafael J; Moore, Robert; linux-acpi@vger.kernel.org;
>> patches@linaro.org; linaro-kernel@lists.linaro.org; Jiang Liu
>> Subject: [PATCH] ACPICA: Remove redundant macro defines for
>> ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW()
>>
>> In commit 0377b5acba2 (ACPICA: Merge all debug output macros into a single
>> file, acoutput.), the patch introduces redundant macro defines for
>> ACPI_DEBUG_PRINT() and ACPI_DEBUG_PRINT_RAW(), just remove it.
>>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>>  include/acpi/acoutput.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/acpi/acoutput.h b/include/acpi/acoutput.h index
>> 4f52ea7..e1c7474 100644
>> --- a/include/acpi/acoutput.h
>> +++ b/include/acpi/acoutput.h
>> @@ -447,8 +447,6 @@
>>  #define ACPI_DUMP_TABLES(a, b)
>>  #define ACPI_DUMP_PATHNAME(a, b, c, d)
>>  #define ACPI_DUMP_BUFFER(a, b)
>> -#define ACPI_DEBUG_PRINT(pl)
>> -#define ACPI_DEBUG_PRINT_RAW(pl)
>>  #define ACPI_IS_DEBUG_ENABLED(level, component) 0
>>
>>  /* Return macros must have a return statement at the minimum */
>> -- 1.8.2.1

Patch

diff --git a/include/acpi/acoutput.h b/include/acpi/acoutput.h
index 4f52ea7..e1c7474 100644
--- a/include/acpi/acoutput.h
+++ b/include/acpi/acoutput.h
@@ -447,8 +447,6 @@ 
 #define ACPI_DUMP_TABLES(a, b)
 #define ACPI_DUMP_PATHNAME(a, b, c, d)
 #define ACPI_DUMP_BUFFER(a, b)
-#define ACPI_DEBUG_PRINT(pl)
-#define ACPI_DEBUG_PRINT_RAW(pl)
 #define ACPI_IS_DEBUG_ENABLED(level, component) 0

 /* Return macros must have a return statement at the minimum */