pmdinfogen: add SPDX license tag

Message ID 20190903072435.2859-1-hemant.agrawal@nxp.com
State New
Headers show
Series
  • pmdinfogen: add SPDX license tag
Related show

Commit Message

Hemant Agrawal Sept. 3, 2019, 7:24 a.m.
This patch adds SPDX license tag to pmdinfogen files.

These files are originally drived from kernel.
They are being used as binary tool to support internal
build.

This patch requires license exception approval from
DPDK Technical Board and Governing Board.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 buildtools/pmdinfogen/pmdinfogen.c | 7 ++-----
 buildtools/pmdinfogen/pmdinfogen.h | 8 ++------
 license/exceptions.txt             | 4 +++-
 3 files changed, 7 insertions(+), 12 deletions(-)

-- 
2.17.1

Comments

Neil Horman Sept. 3, 2019, 12:15 p.m. | #1
On Tue, Sep 03, 2019 at 12:54:35PM +0530, Hemant Agrawal wrote:
> This patch adds SPDX license tag to pmdinfogen files.

> 

> These files are originally drived from kernel.

> They are being used as binary tool to support internal

> build.

> 

> This patch requires license exception approval from

> DPDK Technical Board and Governing Board.

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  buildtools/pmdinfogen/pmdinfogen.c | 7 ++-----

>  buildtools/pmdinfogen/pmdinfogen.h | 8 ++------

>  license/exceptions.txt             | 4 +++-

>  3 files changed, 7 insertions(+), 12 deletions(-)

> 

> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c

> index dc0b6d5ff..a68d1ea99 100644

> --- a/buildtools/pmdinfogen/pmdinfogen.c

> +++ b/buildtools/pmdinfogen/pmdinfogen.c

> @@ -1,11 +1,8 @@

> -/* Postprocess pmd object files to export hw support

> +/* SPDX-License-Identifier: GPL-2.0

> + * Postprocess pmd object files to export hw support

>   *

>   * Copyright 2016 Neil Horman <nhorman@tuxdriver.com>

>   * Based in part on modpost.c from the linux kernel

> - *

> - * This software may be used and distributed according to the terms

> - * of the GNU General Public License V2, incorporated herein by reference.

> - *

>   */

>  

>  #include <stdio.h>

> diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h

> index c8a9e2136..e6ba54535 100644

> --- a/buildtools/pmdinfogen/pmdinfogen.h

> +++ b/buildtools/pmdinfogen/pmdinfogen.h

> @@ -1,12 +1,8 @@

> -

> -/* Postprocess pmd object files to export hw support

> +/* SPDX-License-Identifier: GPL-2.0

> + * Postprocess pmd object files to export hw support

>   *

>   * Copyright 2016 Neil Horman <nhorman@tuxdriver.com>

>   * Based in part on modpost.c from the linux kernel

> - *

> - * This software may be used and distributed according to the terms

> - * of the GNU General Public License V2, incorporated herein by reference.

> - *

>   */

>  

>  #include <stdio.h>

> diff --git a/license/exceptions.txt b/license/exceptions.txt

> index f1cfa462f..9443dfc63 100644

> --- a/license/exceptions.txt

> +++ b/license/exceptions.txt

> @@ -12,7 +12,9 @@ Note that following licenses are not exceptions:-

>  -----------------------------------------------------------------

>  SPDX Identifier     TB Approval Date  GB Approval Date  File name

>  -----------------------------------------------------------------

> -1.

> +1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.c

> +1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.h

> +

>  

>  -----------------------------------------------------------------

>  

> -- 

> 2.17.1

> 

> 

Acked-by: Neil Horman <nhorman@tuxdriver.com>
Stephen Hemminger Dec. 31, 2019, 1:05 a.m. | #2
On Tue,  3 Sep 2019 12:54:35 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> diff --git a/license/exceptions.txt b/license/exceptions.txt

> index f1cfa462f..9443dfc63 100644

> --- a/license/exceptions.txt

> +++ b/license/exceptions.txt

> @@ -12,7 +12,9 @@ Note that following licenses are not exceptions:-

>  -----------------------------------------------------------------

>  SPDX Identifier     TB Approval Date  GB Approval Date  File name

>  -----------------------------------------------------------------

> -1.

> +1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.c

> +1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.h


This should not be part of this patch, it needs to be a separate patch with
real approval dates.

Also, the same license must apply to the whole directory. It makes no sense
to have a BSD licensed make setup with a GPL licensed source. Better
to just list whole directory.

Patch

diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
index dc0b6d5ff..a68d1ea99 100644
--- a/buildtools/pmdinfogen/pmdinfogen.c
+++ b/buildtools/pmdinfogen/pmdinfogen.c
@@ -1,11 +1,8 @@ 
-/* Postprocess pmd object files to export hw support
+/* SPDX-License-Identifier: GPL-2.0
+ * Postprocess pmd object files to export hw support
  *
  * Copyright 2016 Neil Horman <nhorman@tuxdriver.com>
  * Based in part on modpost.c from the linux kernel
- *
- * This software may be used and distributed according to the terms
- * of the GNU General Public License V2, incorporated herein by reference.
- *
  */
 
 #include <stdio.h>
diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h
index c8a9e2136..e6ba54535 100644
--- a/buildtools/pmdinfogen/pmdinfogen.h
+++ b/buildtools/pmdinfogen/pmdinfogen.h
@@ -1,12 +1,8 @@ 
-
-/* Postprocess pmd object files to export hw support
+/* SPDX-License-Identifier: GPL-2.0
+ * Postprocess pmd object files to export hw support
  *
  * Copyright 2016 Neil Horman <nhorman@tuxdriver.com>
  * Based in part on modpost.c from the linux kernel
- *
- * This software may be used and distributed according to the terms
- * of the GNU General Public License V2, incorporated herein by reference.
- *
  */
 
 #include <stdio.h>
diff --git a/license/exceptions.txt b/license/exceptions.txt
index f1cfa462f..9443dfc63 100644
--- a/license/exceptions.txt
+++ b/license/exceptions.txt
@@ -12,7 +12,9 @@  Note that following licenses are not exceptions:-
 -----------------------------------------------------------------
 SPDX Identifier     TB Approval Date  GB Approval Date  File name
 -----------------------------------------------------------------
-1.
+1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.c
+1.GPL-2.0	TBD	 TBD		buildtools/pmdinfogen/pmdinfogen.h
+
 
 -----------------------------------------------------------------