| Message ID | 1307077639-18604-1-git-send-email-tushar.behera@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Friday, June 03, 2011 7:07 AM Tushar Behera wrote: > EHCI requires that USB support be enabled in kernel config. > Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. > > Signed-off-by: Tushar Behera <tushar.behera@linaro.org> > --- > arch/arm/plat-s5p/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig > index e98f5c5..c7e7419 100644 > --- a/arch/arm/plat-s5p/Kconfig > +++ b/arch/arm/plat-s5p/Kconfig > @@ -87,6 +87,7 @@ config S5P_DEV_CSIS1 > > config S5P_DEV_USB_EHCI > bool > + select USB_SUPPORT IMHO this is not the best way to solve this issue. The main problem is the fact that usb-phy.c file depends on CONFIG_USB_SUPPORT not it's own Kconfig entry. Please check arch/arm/mach-exynos4/Makefile. To match the style of other helper functions, usb-phy.c should be renamed to setup-usb-phy.c and get it's own Kconfig entry like CONFIG_EXYNOS4_SETUP_USB_PHY. Also the machine that uses it should select this new entry. This is really not related to CONFIG_USB_SUPPORT at all (one might want to have a kernel without USB support for some reason). > help > Compile in platform device definition for USB EHCI > > -- Best regards
Hi Marek, Thanks for your review. On Friday 03 June 2011 11:23 AM, Marek Szyprowski wrote: > Hello, > > On Friday, June 03, 2011 7:07 AM Tushar Behera wrote: > >> EHCI requires that USB support be enabled in kernel config. >> Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. >> >> Signed-off-by: Tushar Behera<tushar.behera@linaro.org> >> --- >> arch/arm/plat-s5p/Kconfig | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig >> index e98f5c5..c7e7419 100644 >> --- a/arch/arm/plat-s5p/Kconfig >> +++ b/arch/arm/plat-s5p/Kconfig >> @@ -87,6 +87,7 @@ config S5P_DEV_CSIS1 >> >> config S5P_DEV_USB_EHCI >> bool >> + select USB_SUPPORT > > IMHO this is not the best way to solve this issue. The main problem is > the fact that usb-phy.c file depends on CONFIG_USB_SUPPORT not it's own > Kconfig entry. Please check arch/arm/mach-exynos4/Makefile. To match the > style of other helper functions, usb-phy.c should be renamed to > setup-usb-phy.c and get it's own Kconfig entry like > CONFIG_EXYNOS4_SETUP_USB_PHY. Also the machine that uses it should select > this new entry. This is really not related to CONFIG_USB_SUPPORT at all > (one might want to have a kernel without USB support for some reason). > > Ok. I will re-submit the patch. >> help >> Compile in platform device definition for USB EHCI >> >> -- > > Best regards
diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig index e98f5c5..c7e7419 100644 --- a/arch/arm/plat-s5p/Kconfig +++ b/arch/arm/plat-s5p/Kconfig @@ -87,6 +87,7 @@ config S5P_DEV_CSIS1 config S5P_DEV_USB_EHCI bool + select USB_SUPPORT help Compile in platform device definition for USB EHCI
EHCI requires that USB support be enabled in kernel config. Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- arch/arm/plat-s5p/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)