diff mbox series

clk: qcom: gcc-qcs404: Use floor ops for sdcc clks

Message ID 20190906045659.20621-1-vkoul@kernel.org
State Accepted
Commit 593020811cb0903141649fb6c7c53c442baae90a
Headers show
Series clk: qcom: gcc-qcs404: Use floor ops for sdcc clks | expand

Commit Message

Vinod Koul Sept. 6, 2019, 4:56 a.m. UTC
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
dont want the clock rates to do round up.

[1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 drivers/clk/qcom/gcc-qcs404.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.1

Comments

Bjorn Andersson Sept. 6, 2019, 7:55 p.m. UTC | #1
On Thu 05 Sep 21:56 PDT 2019, Vinod Koul wrote:

> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As

> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we

> dont want the clock rates to do round up.

> 

> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/

> 


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

>  drivers/clk/qcom/gcc-qcs404.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c

> index e12c04c09a6a..bd32212f37e6 100644

> --- a/drivers/clk/qcom/gcc-qcs404.c

> +++ b/drivers/clk/qcom/gcc-qcs404.c

> @@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {

>  		.name = "sdcc1_apps_clk_src",

>  		.parent_names = gcc_parent_names_13,

>  		.num_parents = 5,

> -		.ops = &clk_rcg2_ops,

> +		.ops = &clk_rcg2_floor_ops,

>  	},

>  };

>  

> @@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {

>  		.name = "sdcc2_apps_clk_src",

>  		.parent_names = gcc_parent_names_14,

>  		.num_parents = 4,

> -		.ops = &clk_rcg2_ops,

> +		.ops = &clk_rcg2_floor_ops,

>  	},

>  };

>  

> -- 

> 2.20.1

>
Stephen Boyd Sept. 9, 2019, 10:25 a.m. UTC | #2
Quoting Vinod Koul (2019-09-05 21:56:59)
> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As

> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we

> dont want the clock rates to do round up.

> 

> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/

> 

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---


Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index e12c04c09a6a..bd32212f37e6 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -1057,7 +1057,7 @@  static struct clk_rcg2 sdcc1_apps_clk_src = {
 		.name = "sdcc1_apps_clk_src",
 		.parent_names = gcc_parent_names_13,
 		.num_parents = 5,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
@@ -1103,7 +1103,7 @@  static struct clk_rcg2 sdcc2_apps_clk_src = {
 		.name = "sdcc2_apps_clk_src",
 		.parent_names = gcc_parent_names_14,
 		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };