[v2,5/6] test/lpm: reset total time

Message ID 20190906094534.36060-6-ruifeng.wang@arm.com
State New
Headers show
Series
  • [v2,1/6] doc/rcu: add RCU integration design details
Related show

Commit Message

Ruifeng Wang (Arm Technology China) Sept. 6, 2019, 9:45 a.m.
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>


total_time needs to be reset to measure the cycles for delete API.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Reviewed-by: Gavin Hu <gavin.hu@arm.com>

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

---
 app/test/test_lpm_perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Medvedkin, Vladimir Sept. 18, 2019, 4:17 p.m. | #1
Hi Ruifeng,

Thanks for this bug fix.

I think it should be sent separately from this RCU related patch series.

On 06/09/2019 10:45, Ruifeng Wang wrote:
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

>

> total_time needs to be reset to measure the cycles for delete API.

>

> Fixes: af75078fece3 ("first public release")

> Cc: stable@dpdk.org

>

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

> ---

>   app/test/test_lpm_perf.c | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c

> index 77eea66ad..a2578fe90 100644

> --- a/app/test/test_lpm_perf.c

> +++ b/app/test/test_lpm_perf.c

> @@ -460,7 +460,7 @@ test_lpm_perf(void)

>   			(double)total_time / ((double)ITERATIONS * BATCH_SIZE),

>   			(count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));

>   

> -	/* Delete */

> +	/* Measure Delete */

>   	status = 0;

>   	begin = rte_rdtsc();

>   

> @@ -470,7 +470,7 @@ test_lpm_perf(void)

>   				large_route_table[i].depth);

>   	}

>   

> -	total_time += rte_rdtsc() - begin;

> +	total_time = rte_rdtsc() - begin;

>   

>   	printf("Average LPM Delete: %g cycles\n",

>   			(double)total_time / NUM_ROUTE_ENTRIES);


-- 
Regards,
Vladimir
Ruifeng Wang (Arm Technology China) Sept. 19, 2019, 6:22 a.m. | #2
Hi Vladimir,

> -----Original Message-----

> From: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>

> Sent: Thursday, September 19, 2019 00:18

> To: Ruifeng Wang (Arm Technology China) <Ruifeng.Wang@arm.com>;

> bruce.richardson@intel.com; olivier.matz@6wind.com

> Cc: dev@dpdk.org; stephen@networkplumber.org;

> konstantin.ananyev@intel.com; Gavin Hu (Arm Technology China)

> <Gavin.Hu@arm.com>; Honnappa Nagarahalli

> <Honnappa.Nagarahalli@arm.com>; Dharmik Thakkar

> <Dharmik.Thakkar@arm.com>; nd <nd@arm.com>; stable@dpdk.org

> Subject: Re: [PATCH v2 5/6] test/lpm: reset total time

> 

> Hi Ruifeng,

> 

> Thanks for this bug fix.

> 

> I think it should be sent separately from this RCU related patch series.

Agree. It will be sent out separately.
> 

> On 06/09/2019 10:45, Ruifeng Wang wrote:

> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> >

> > total_time needs to be reset to measure the cycles for delete API.

> >

> > Fixes: af75078fece3 ("first public release")

> > Cc: stable@dpdk.org

> >

> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>

> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

> > ---

> >   app/test/test_lpm_perf.c | 4 ++--

> >   1 file changed, 2 insertions(+), 2 deletions(-)

> >

> > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index

> > 77eea66ad..a2578fe90 100644

> > --- a/app/test/test_lpm_perf.c

> > +++ b/app/test/test_lpm_perf.c

> > @@ -460,7 +460,7 @@ test_lpm_perf(void)

> >   			(double)total_time / ((double)ITERATIONS *

> BATCH_SIZE),

> >   			(count * 100.0) / (double)(ITERATIONS *

> BATCH_SIZE));

> >

> > -	/* Delete */

> > +	/* Measure Delete */

> >   	status = 0;

> >   	begin = rte_rdtsc();

> >

> > @@ -470,7 +470,7 @@ test_lpm_perf(void)

> >   				large_route_table[i].depth);

> >   	}

> >

> > -	total_time += rte_rdtsc() - begin;

> > +	total_time = rte_rdtsc() - begin;

> >

> >   	printf("Average LPM Delete: %g cycles\n",

> >   			(double)total_time / NUM_ROUTE_ENTRIES);

> 

> --

> Regards,

> Vladimir

Patch

diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 77eea66ad..a2578fe90 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -460,7 +460,7 @@  test_lpm_perf(void)
 			(double)total_time / ((double)ITERATIONS * BATCH_SIZE),
 			(count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
 
-	/* Delete */
+	/* Measure Delete */
 	status = 0;
 	begin = rte_rdtsc();
 
@@ -470,7 +470,7 @@  test_lpm_perf(void)
 				large_route_table[i].depth);
 	}
 
-	total_time += rte_rdtsc() - begin;
+	total_time = rte_rdtsc() - begin;
 
 	printf("Average LPM Delete: %g cycles\n",
 			(double)total_time / NUM_ROUTE_ENTRIES);