From patchwork Fri Sep 6 15:09:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 173247 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp844480ilq; Fri, 6 Sep 2019 08:09:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDd4V/llYQkavkA8Q95zqc7Fp7gDDOGQMAWhcZ+ozTwJMnKMvdBdms5Qucrf6SLEmVJpPr X-Received: by 2002:a63:2a87:: with SMTP id q129mr8551991pgq.101.1567782574689; Fri, 06 Sep 2019 08:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567782574; cv=none; d=google.com; s=arc-20160816; b=LzyNDFOzwbp4dnMllSld3U3OYwlpJVKFkgHntYHWW0nmphIgSqgJQo+s+xAYYnTAQ4 JQE3R1PRAOSEvIwmQxeSwqRp3g15EJPSvz0XpXyRunfJ6MxfhpSuV/BhbVGFs+Rf/qGQ jZSGrXrL+9ksTKGTMk4HkbgzZYgjcN/Y8rRD5DUlnE/i+Zk/gUK0XN+dj5w60fXcoYyH yIiptls20Y6CorVTyQvgB50ibWTAGlrzn3BoB7jgQnQFMDwTGiSTA+p1lGkfXnRwSsEw 1gPanIdA7cGMDbDPHzTDkqch/4YgGflpd1DX0kZih79ysAoBd+HJlGy1THNisn+Tq0Mg N6Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lkrKGLMQfIpP2sk6ld4gGiqXbPRbnWlBO0MZbghWn2A=; b=VlRb+Qbyuo2nVR+t10p9OsqS+lwO2swkNNfshs7CcFbTlHd6I6INivNRbGPiOfXGSJ GKINjNX6ofuTmi+lxSTF1PELLN/OoxYquBRUrE/QAzc6CE91q7WmyjuDViLgaX6trJZ5 7d8ua7JgOkZi/43Hpkdct8TLH3kJKjqYRD4NMSZ4wmwucTt3cs8S9Rj+YPG5fAz+F5uE ydyG9hA64SzctlufF2pB0O86MjzcRoy0viXsDWBSUd4La1b7fU4Flxh9Qa5bg86xJqBp KPE8/DbCBOuebhltQqVJqTsmT8nNFmEu1utlNBODKnRNBUBlsvd/E+0JXNLsStzG9zJt jzQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si5969671pfb.238.2019.09.06.08.09.34; Fri, 06 Sep 2019 08:09:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394706AbfIFPJd (ORCPT + 28 others); Fri, 6 Sep 2019 11:09:33 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55325 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbfIFPJd (ORCPT ); Fri, 6 Sep 2019 11:09:33 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MhUDj-1iated0Y4J-00eZJS; Fri, 06 Sep 2019 17:09:20 +0200 From: Arnd Bergmann To: Valdis Kletnieks , Greg Kroah-Hartman Cc: Arnd Bergmann , Valentin Vidic , Colin Ian King , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] exfat stopusing CONFIG_FAT_DEFAULT_IOCHARSET Date: Fri, 6 Sep 2019 17:09:04 +0200 Message-Id: <20190906150917.1025250-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:uqse4hogKOr7BI9YbaZwXs0qyNe9NNWburGdPI+eJEYl2q8Qt1s uQVNJNkUVfq+l/FOkvdPd5DI9S065oyd28MutYIcNOCemFvmd3sk0OS91NieEqurLW0ou7f 7ybSd+bMXeKQX5WVWhkVlHXTSMVz410x/mC3E8ME35vkFYSA8+DLyrt9KG6rKKChBeUtw66 fXV42UtlfUIJdeW5Yh2ZA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:4FoCFpjAsA8=:5xtEH+8/eJEDimTUKDvoYx kHftU+cpIZPlUEmKAgHcJcxq4+61ytMOFgBk1BUg/7s3p9h3KjyOBG4cplYu2dq9FduHsP5Wd etPBm5XzDrEnA9JY8SZ1xaAR7hD2IxFe1Stnq6vsIEpFiqPcJmicIKmVjvF325ZY0IyIrvzdr TQNfgsdGgIgXaEiHFvtwPZtWH3UpLrD8tp/lYpaBUP5GqFIYLsJyrVidm5t42K25yyfF8IG9N vYQwy/yGu1XDYBHnnWjnk0d0at38ouNKDmx9jDQgr+BAIFQWjAXnD4eY8jFP9btIELx8fHEhd OpU8yixFAEbdhpms2EPQ7/wQ7TOA+cCl/1Qk1nunsskh6meH2OeEiMT1aH7kGMaNecVP/pWP6 RrQekXMfDXUmHSi8+iSBUKP2uHkETJkOFqN0fXjisKElLbxq11b2Vwa2NkwUE87H0gNe78Qty lIVGFWJqW4g4epFt31ZxReiSmtTxshaz/lCpNVfQwAf0yCpq+OnaaKbhvD5bjnwznMJDVDXMn SVfFK/LPNj3dCPIO0S4pstaF+rsEKQ3O0UpHyMSYBk1Virp5T+b9ScsK3AOiR6pk+mNr6JkD0 sDJCXFSskfU8O5Ky1m3zMVsBWAwRG6qqzCz2KfYgXsFJwDjShdHbsOq6rm1kV86hKelnGerIZ /n6ejLqNNTazUL7mEzUWJqg+DzXA/dkphaju4bZlcBowvBQ1GvMzzHzhoM8T9dobYJMNPWCPj RHQFXGcTLWue1b0TAUZpOzbZJA3c/hKBWaJlbetfN/Rkt39ZPz+M0ybZzyysB2Y5cATh9aQEH 3nyf+i1B3NKhmOpzHwTU1xruTx4QN0n6LzmF5qAQNPGNS+hyF0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_VFAT_FS is disabled, the reference to CONFIG_FAT_DEFAULT_IOCHARSET causes a link failure: drivers/staging/exfat/exfat_super.c:46:41: error: use of undeclared identifier 'CONFIG_FAT_DEFAULT_IOCHARSET' static char exfat_default_iocharset[] = CONFIG_FAT_DEFAULT_IOCHARSET; I could not figure out why the correct code is commented out, but using that fixes the problem. Signed-off-by: Arnd Bergmann --- drivers/staging/exfat/exfat_super.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.20.0 diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 3934b120e1dd..37e78620723f 100644 --- a/drivers/staging/exfat/exfat_super.c +++ b/drivers/staging/exfat/exfat_super.c @@ -39,11 +39,8 @@ static struct kmem_cache *exfat_inode_cachep; -// FIXME use commented lines -// static int exfat_default_codepage = CONFIG_EXFAT_DEFAULT_CODEPAGE; -// static char exfat_default_iocharset[] = CONFIG_EXFAT_DEFAULT_IOCHARSET; -static int exfat_default_codepage = CONFIG_FAT_DEFAULT_CODEPAGE; -static char exfat_default_iocharset[] = CONFIG_FAT_DEFAULT_IOCHARSET; +static int exfat_default_codepage = CONFIG_EXFAT_DEFAULT_CODEPAGE; +static char exfat_default_iocharset[] = CONFIG_EXFAT_DEFAULT_IOCHARSET; #define INC_IVERSION(x) (inode_inc_iversion(x)) #define GET_IVERSION(x) (inode_peek_iversion_raw(x))