[1/2] module: remove redundant 'depends on MODULES'

Message ID 20190909110408.21832-1-yamada.masahiro@socionext.com
State New
Headers show
Series
  • [1/2] module: remove redundant 'depends on MODULES'
Related show

Commit Message

Masahiro Yamada Sept. 9, 2019, 11:04 a.m.
These are located in the 'if MODULES' ... 'endif' block.

Remove the redundant dependencies.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 init/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.17.1

Comments

Jessica Yu Sept. 11, 2019, 11:45 a.m. | #1
+++ Masahiro Yamada [09/09/19 20:04 +0900]:
>These are located in the 'if MODULES' ... 'endif' block.

>

>Remove the redundant dependencies.

>

>Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Acked-by: Jessica Yu <jeyu@kernel.org>
Masahiro Yamada Sept. 11, 2019, 12:21 p.m. | #2
On Wed, Sep 11, 2019 at 8:46 PM Jessica Yu <jeyu@kernel.org> wrote:
>

> +++ Masahiro Yamada [09/09/19 20:04 +0900]:

> >These are located in the 'if MODULES' ... 'endif' block.

> >

> >Remove the redundant dependencies.

> >

> >Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

>

> Acked-by: Jessica Yu <jeyu@kernel.org>

>


Could you queue these two patches to your tree?

Thanks.


--
Best Regards

Masahiro Yamada
Jessica Yu Sept. 11, 2019, 2:17 p.m. | #3
+++ Masahiro Yamada [11/09/19 21:21 +0900]:
>On Wed, Sep 11, 2019 at 8:46 PM Jessica Yu <jeyu@kernel.org> wrote:

>>

>> +++ Masahiro Yamada [09/09/19 20:04 +0900]:

>> >These are located in the 'if MODULES' ... 'endif' block.

>> >

>> >Remove the redundant dependencies.

>> >

>> >Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

>>

>> Acked-by: Jessica Yu <jeyu@kernel.org>

>>

>

>Could you queue these two patches to your tree?

>

>Thanks.


Ah, I thought they were going to the kbuild tree. But yes, I'll take
them through modules-next.

Thanks,

Jessica

Patch

diff --git a/init/Kconfig b/init/Kconfig
index bd7d650d4a99..9e72cc6071f5 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -2006,7 +2006,6 @@  config MODULE_SRCVERSION_ALL
 
 config MODULE_SIG
 	bool "Module signature verification"
-	depends on MODULES
 	select SYSTEM_DATA_VERIFICATION
 	help
 	  Check modules for valid signatures upon load: the signature
@@ -2083,7 +2082,6 @@  config MODULE_SIG_HASH
 
 config MODULE_COMPRESS
 	bool "Compress modules on installation"
-	depends on MODULES
 	help
 
 	  Compresses kernel modules when 'make modules_install' is run; gzip or
@@ -2121,7 +2119,7 @@  endchoice
 
 config TRIM_UNUSED_KSYMS
 	bool "Trim unused exported kernel symbols"
-	depends on MODULES && !UNUSED_SYMBOLS
+	depends on !UNUSED_SYMBOLS
 	help
 	  The kernel and some modules make many symbols available for
 	  other modules to use via EXPORT_SYMBOL() and variants. Depending