[v3,03/11] mmc: mtk-sd: Re-store SDIO IRQs mask at system resume

Message ID 20190911120920.9026-1-ulf.hansson@linaro.org
State New
Headers show
  • Untitled series #23350
Related show

Commit Message

Ulf Hansson Sept. 11, 2019, 12:09 p.m.
In cases when SDIO IRQs have been enabled, runtime suspend is prevented by
the driver. However, this still means msdc_runtime_suspend|resume() gets
called during system suspend/resume, via pm_runtime_force_suspend|resume().

This means during system suspend/resume, the register context of the mtk-sd
device most likely loses its register context, even in cases when SDIO IRQs
have been enabled.

To re-enable the SDIO IRQs during system resume, the mtk-sd driver
currently relies on the mmc core to re-enable the SDIO IRQs when it resumes
the SDIO card, but this isn't the recommended solution. Instead, it's
better to deal with this locally in the mtk-sd driver, so let's do that.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>


Changes in v3:
	- Fix the code to do the restore in msdc_restore_reg().

 drivers/mmc/host/mtk-sd.c | 3 +++
 1 file changed, 3 insertions(+)



diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 6946bb040a28..189e42674d85 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2435,6 +2435,9 @@  static void msdc_restore_reg(struct msdc_host *host)
 	} else {
 		writel(host->save_para.pad_tune, host->base + tune_reg);
+	if (sdio_irq_claimed(host->mmc))
+		__msdc_enable_sdio_irq(host, 1);
 static int msdc_runtime_suspend(struct device *dev)