[Xen-devel] xen/arm: bootfd: Fix indentation in process_multiboot_node()

Message ID 20190911151942.28459-1-julien.grall@arm.com
State New
Headers show
Series
  • [Xen-devel] xen/arm: bootfd: Fix indentation in process_multiboot_node()
Related show

Commit Message

Julien Grall Sept. 11, 2019, 3:19 p.m.
One line in process_multiboot_node() is using hard tab rather than soft
tab. So fix it!

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/bootfdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Volodymyr Babchuk Sept. 11, 2019, 5:33 p.m. | #1
Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)


> ---
>  xen/arch/arm/bootfdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void *fdt, int node,
>          case 1: kind = BOOTMOD_RAMDISK; break;
>          default: break;
>          }
> -	if ( kind_guess > 1 && has_xsm_magic(start) )
> +        if ( kind_guess > 1 && has_xsm_magic(start) )
>              kind = BOOTMOD_XSM;
>      }
Julien Grall Sept. 11, 2019, 5:58 p.m. | #2
On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, <Volodymyr_Babchuk@epam.com>
wrote:

>

> Julien Grall writes:

>

> > One line in process_multiboot_node() is using hard tab rather than soft

> > tab. So fix it!

> >

> > Signed-off-by: Julien Grall <julien.grall@arm.com>

> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

>

> So, hunting them one-by-one is the preferred way?



I usually do it while I touch code around. I found this one when debugging
a boot regression today. You are welcome to fix the rest although...

I'm asking this
> because there are more of them:

>

> % find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;

> xen/arch/arm/traps.c

> xen/arch/arm/acpi/boot.c

> xen/arch/arm/arm32/lib/assembler.h

> xen/arch/arm/arm64/livepatch.c

> xen/arch/arm/arm64/lib/find_next_bit.c

> xen/arch/arm/arm64/insn.c

>


The 4 above are a copy from Linux and therefore hard tab should stay.

Cheers,


>
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, &lt;<a href="mailto:Volodymyr_Babchuk@epam.com">Volodymyr_Babchuk@epam.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Julien Grall writes:<br>
<br>
&gt; One line in process_multiboot_node() is using hard tab rather than soft<br>
&gt; tab. So fix it!<br>
&gt;<br>
&gt; Signed-off-by: Julien Grall &lt;<a href="mailto:julien.grall@arm.com" target="_blank" rel="noreferrer">julien.grall@arm.com</a>&gt;<br>
Reviewed-by: Volodymyr Babchuk &lt;<a href="mailto:volodymyr_babchuk@epam.com" target="_blank" rel="noreferrer">volodymyr_babchuk@epam.com</a>&gt;<br>

<br>
So, hunting them one-by-one is the preferred way?</blockquote></div></div><div dir="auto"><br></div><div dir="auto">I usually do it while I touch code around. I found this one when debugging a boot regression today. You are welcome to fix the rest although...</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I&#39;m asking this<br>
because there are more of them:<br>
<br>
% find xen/arch/arm -type f -name &quot;*.[ch]&quot; -exec grep -lP &quot;\t&quot; {} \;<br>
xen/arch/arm/traps.c<br>
xen/arch/arm/acpi/boot.c<br>
xen/arch/arm/arm32/lib/assembler.h<br>
xen/arch/arm/arm64/livepatch.c<br>
xen/arch/arm/arm64/lib/find_next_bit.c<br>
xen/arch/arm/arm64/insn.c<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">The 4 above are a copy from Linux and therefore hard tab should stay.</div><div dir="auto"><br></div><div dir="auto">Cheers,</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br></blockquote></div></div></div>
Stefano Stabellini Sept. 12, 2019, 5:06 p.m. | #3
On Wed, 11 Sep 2019, Volodymyr Babchuk wrote:
> 
> Julien Grall writes:
> 
> > One line in process_multiboot_node() is using hard tab rather than soft
> > tab. So fix it!
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

Patch

diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 258b057f00..623173bc7f 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -264,7 +264,7 @@  static void __init process_multiboot_node(const void *fdt, int node,
         case 1: kind = BOOTMOD_RAMDISK; break;
         default: break;
         }
-	if ( kind_guess > 1 && has_xsm_magic(start) )
+        if ( kind_guess > 1 && has_xsm_magic(start) )
             kind = BOOTMOD_XSM;
     }