diff mbox series

[2/4] arm64: Kconfig: Fix BRCMSTB driver dependencies

Message ID 21b9dd0bf0bbc80b69bc81a7efb88243e4981c56.1568239378.git.amit.kucheria@linaro.org
State New
Headers show
Series Cleanup arm64 driver dependencies | expand

Commit Message

Amit Kucheria Sept. 11, 2019, 10:18 p.m. UTC
Push various BRCMSTB drivers behind ARCH_BRCMSTB dependency so that it
doesn't get enabled by default on other platforms.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

---
 drivers/bus/Kconfig         | 1 +
 drivers/power/reset/Kconfig | 1 +
 drivers/soc/bcm/Kconfig     | 1 +
 3 files changed, 3 insertions(+)

-- 
2.17.1

Comments

Arnd Bergmann Sept. 12, 2019, 9:20 a.m. UTC | #1
On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig

> index 1851112ccc29..d80e8d70bf10 100644

> --- a/drivers/bus/Kconfig

> +++ b/drivers/bus/Kconfig

> @@ -22,6 +22,7 @@ config ARM_CCI400_PORT_CTRL

>

>  config BRCMSTB_GISB_ARB

>         bool "Broadcom STB GISB bus arbiter"

> +       depends on ARCH_BRCMSTB

>         depends on ARM || ARM64 || MIPS

>         default ARCH_BRCMSTB || BMIPS_GENERIC

>         help


This breaks MIPS configurations that need this driver, and
it breask compile-testing on non-ARM/MIPS targets.

> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig

> index 651b763f80cd..6f0b1ed1a05a 100644

> --- a/drivers/power/reset/Kconfig

> +++ b/drivers/power/reset/Kconfig

> @@ -59,6 +59,7 @@ config POWER_RESET_BRCMKONA

>

>  config POWER_RESET_BRCMSTB

>         bool "Broadcom STB reset driver"

> +       depends on ARCH_BRCMSTB

>         depends on ARM || ARM64 || MIPS || COMPILE_TEST

>         depends on MFD_SYSCON

>         default ARCH_BRCMSTB || BMIPS_GENERIC


Same here and below.

> diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig

> index 648e32693b7e..5a8ff33241ae 100644

> --- a/drivers/soc/bcm/Kconfig

> +++ b/drivers/soc/bcm/Kconfig

> @@ -24,6 +24,7 @@ config RASPBERRYPI_POWER

>

>  config SOC_BRCMSTB

>         bool "Broadcom STB SoC drivers"

> +       depends on ARCH_BRCMSTB

>         depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST

>         select SOC_BUS

>         help


       Arnd
diff mbox series

Patch

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 1851112ccc29..d80e8d70bf10 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -22,6 +22,7 @@  config ARM_CCI400_PORT_CTRL
 
 config BRCMSTB_GISB_ARB
 	bool "Broadcom STB GISB bus arbiter"
+	depends on ARCH_BRCMSTB
 	depends on ARM || ARM64 || MIPS
 	default ARCH_BRCMSTB || BMIPS_GENERIC
 	help
diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 651b763f80cd..6f0b1ed1a05a 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -59,6 +59,7 @@  config POWER_RESET_BRCMKONA
 
 config POWER_RESET_BRCMSTB
 	bool "Broadcom STB reset driver"
+	depends on ARCH_BRCMSTB
 	depends on ARM || ARM64 || MIPS || COMPILE_TEST
 	depends on MFD_SYSCON
 	default ARCH_BRCMSTB || BMIPS_GENERIC
diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig
index 648e32693b7e..5a8ff33241ae 100644
--- a/drivers/soc/bcm/Kconfig
+++ b/drivers/soc/bcm/Kconfig
@@ -24,6 +24,7 @@  config RASPBERRYPI_POWER
 
 config SOC_BRCMSTB
 	bool "Broadcom STB SoC drivers"
+	depends on ARCH_BRCMSTB
 	depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
 	select SOC_BUS
 	help