diff mbox series

[4/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG

Message ID 20190919232952.6382-5-richard.henderson@linaro.org
State Superseded
Headers show
Series exec: Improve code for TARGET_PAGE_BITS_VARY | expand

Commit Message

Richard Henderson Sept. 19, 2019, 11:29 p.m. UTC
This reduces the size of a release build by about 10k.
Noticably, within the tlb miss helpers.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 include/exec/cpu-all.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé Sept. 21, 2019, 9:01 a.m. UTC | #1
On 9/20/19 1:29 AM, Richard Henderson wrote:
> This reduces the size of a release build by about 10k.

> Noticably, within the tlb miss helpers.

> 

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  include/exec/cpu-all.h | 6 +++++-

>  1 file changed, 5 insertions(+), 1 deletion(-)

> 

> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h

> index a53b761b48..b11ee1f711 100644

> --- a/include/exec/cpu-all.h

> +++ b/include/exec/cpu-all.h

> @@ -215,7 +215,11 @@ typedef struct {

>      int bits;

>  } TargetPageBits;

>  extern const TargetPageBits target_page;

> -#define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)

> +# ifdef CONFIG_DEBUG_TCG

> +#  define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)

> +# else

> +#  define TARGET_PAGE_BITS target_page.bits

> +# endif

>  #else

>  #define TARGET_PAGE_BITS_MIN TARGET_PAGE_BITS

>  #endif

> 


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index a53b761b48..b11ee1f711 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -215,7 +215,11 @@  typedef struct {
     int bits;
 } TargetPageBits;
 extern const TargetPageBits target_page;
-#define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
+# ifdef CONFIG_DEBUG_TCG
+#  define TARGET_PAGE_BITS (assert(target_page.decided), target_page.bits)
+# else
+#  define TARGET_PAGE_BITS target_page.bits
+# endif
 #else
 #define TARGET_PAGE_BITS_MIN TARGET_PAGE_BITS
 #endif