[1/2] json-c: use GitHub for upstream release checking

Message ID 20190920111602.27927-1-ross.burton@intel.com
State Superseded
Headers show
Series
  • [1/2] json-c: use GitHub for upstream release checking
Related show

Commit Message

Ross Burton Sept. 20, 2019, 11:16 a.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-devtools/json-c/json-c_0.13.1.bb | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

-- 
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Adrian Bunk Sept. 20, 2019, 11:26 a.m. | #1
On Fri, Sep 20, 2019 at 12:16:01PM +0100, Ross Burton wrote:
> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/recipes-devtools/json-c/json-c_0.13.1.bb | 8 +-------

>  1 file changed, 1 insertion(+), 7 deletions(-)

> 

> diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb

> index 9654e60a3d2..fcc3e4337ea 100644

> --- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb

> +++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb

> @@ -10,13 +10,7 @@ SRC_URI = "https://s3.amazonaws.com/json-c_releases/releases/${BP}.tar.gz \

>  SRC_URI[md5sum] = "04969ad59cc37bddd83741a08b98f350"

>  SRC_URI[sha256sum] = "b87e608d4d3f7bfdd36ef78d56d53c74e66ab278d318b71e6002a369d36f4873"

>  

> -UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+).tar"

> -# json-c releases page is fetching the list of releases in some weird XML format

> -# from https://s3.amazonaws.com/json-c_releases and processes it with javascript :-/

> -#UPSTREAM_CHECK_URI = "https://s3.amazonaws.com/json-c_releases/releases/index.html"

> -RECIPE_UPSTREAM_VERSION = "0.13.1"

> -RECIPE_UPSTREAM_DATE = "Mar 04, 2018"

> -CHECK_DATE = "May 02, 2018"

> +UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/releases"

>...


Upstream tag names are appending the date to the version,
making "devtool check-upgrade-status" with this patch result in
INFO: json-c                    0.13.1          UNKNOWN_BROKEN  Yi Zhao <yi.zhao@windriver.com>


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton Sept. 20, 2019, 11:59 a.m. | #2
On 20/09/2019 12:26, Adrian Bunk wrote:
> Upstream tag names are appending the date to the version,

> making "devtool check-upgrade-status" with this patch result in

> INFO: json-c                    0.13.1          UNKNOWN_BROKEN  Yi Zhao <yi.zhao@windriver.com>


I totally tested this and it worked, somehow.  Obviously my tool is broken!

V2 incoming...

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
index 9654e60a3d2..fcc3e4337ea 100644
--- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
@@ -10,13 +10,7 @@  SRC_URI = "https://s3.amazonaws.com/json-c_releases/releases/${BP}.tar.gz \
 SRC_URI[md5sum] = "04969ad59cc37bddd83741a08b98f350"
 SRC_URI[sha256sum] = "b87e608d4d3f7bfdd36ef78d56d53c74e66ab278d318b71e6002a369d36f4873"
 
-UPSTREAM_CHECK_REGEX = "json-c-(?P<pver>\d+(\.\d+)+).tar"
-# json-c releases page is fetching the list of releases in some weird XML format
-# from https://s3.amazonaws.com/json-c_releases and processes it with javascript :-/
-#UPSTREAM_CHECK_URI = "https://s3.amazonaws.com/json-c_releases/releases/index.html"
-RECIPE_UPSTREAM_VERSION = "0.13.1"
-RECIPE_UPSTREAM_DATE = "Mar 04, 2018"
-CHECK_DATE = "May 02, 2018"
+UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/releases"
 
 RPROVIDES_${PN} = "libjson"