spec: Drop unittest overrides

Message ID b1d76ae993429b98d5a29160f95853d821d691d1.1569347439.git.crobinso@redhat.com
State Accepted
Commit 03449e25047c71eaf4a54b6459007bf2c504802e
Headers show
Series
  • spec: Drop unittest overrides
Related show

Commit Message

Cole Robinson Sept. 24, 2019, 5:50 p.m.
nodinfotest.c doesn't exist anymore

seclabeltest.c has changed substantially since this behavior was
added to the spec, and in my testing doesn't have any problems
running in mock

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 libvirt.spec.in | 9 ---------
 1 file changed, 9 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Erik Skultety Sept. 25, 2019, 6:23 a.m. | #1
On Tue, Sep 24, 2019 at 01:50:39PM -0400, Cole Robinson wrote:
> nodinfotest.c doesn't exist anymore

>

> seclabeltest.c has changed substantially since this behavior was

> added to the spec, and in my testing doesn't have any problems

> running in mock

>

> Signed-off-by: Cole Robinson <crobinso@redhat.com>

> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patch

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e2f2a40238..2e1d575663 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1313,15 +1313,6 @@  mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvirt_qemu_probes.stp \
 %endif
 
 %check
-cd tests
-# These tests don't current work in a mock build root
-for i in nodeinfotest seclabeltest
-do
-  rm -f $i
-  printf 'int main(void) { return 0; }' > $i.c
-  printf '#!/bin/sh\nexit 0\n' > $i
-  chmod +x $i
-done
 if ! make %{?_smp_mflags} check VIR_TEST_DEBUG=1
 then
   cat test-suite.log || true