gpio: aspeed-sgpio: Rename and add Kconfig/Makefile

Message ID 20190927114833.12551-1-linus.walleij@linaro.org
State Accepted
Commit f8b410e3695a86686f4075b997bc53c8a178e4e2
Headers show
Series
  • gpio: aspeed-sgpio: Rename and add Kconfig/Makefile
Related show

Commit Message

Linus Walleij Sept. 27, 2019, 11:48 a.m.
This renames the "gpio-aspeed" driver to conform with other
GPIO drivers as "gpio-aspeed-sgpio.c". All GPIO drivers
should start with the string "gpio-" no special exceptions.

Also the Kconfig and Makefile entries should normally
go with the driver but I missed this in my review, sorry
for mistake. "CONFIG_GPIO_ASPEED_SGPIO" is used to
activate this driver.

Cc: Hongwei Zhang <hongweiz@ami.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpio/Kconfig                                 | 8 ++++++++
 drivers/gpio/Makefile                                | 1 +
 drivers/gpio/{sgpio-aspeed.c => gpio-aspeed-sgpio.c} | 0
 3 files changed, 9 insertions(+)
 rename drivers/gpio/{sgpio-aspeed.c => gpio-aspeed-sgpio.c} (100%)

-- 
2.21.0

Comments

Andrew Jeffery Sept. 30, 2019, 5:48 a.m. | #1
On Fri, 27 Sep 2019, at 21:18, Linus Walleij wrote:
> This renames the "gpio-aspeed" driver to conform with other

> GPIO drivers as "gpio-aspeed-sgpio.c". All GPIO drivers

> should start with the string "gpio-" no special exceptions.

> 

> Also the Kconfig and Makefile entries should normally

> go with the driver but I missed this in my review, sorry

> for mistake. "CONFIG_GPIO_ASPEED_SGPIO" is used to

> activate this driver.

> 

> Cc: Hongwei Zhang <hongweiz@ami.com>

> Cc: Andrew Jeffery <andrew@aj.id.au>

> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Acked-by: Andrew Jeffery <andrew@aj.id.au>


> ---

>  drivers/gpio/Kconfig                                 | 8 ++++++++

>  drivers/gpio/Makefile                                | 1 +

>  drivers/gpio/{sgpio-aspeed.c => gpio-aspeed-sgpio.c} | 0

>  3 files changed, 9 insertions(+)

>  rename drivers/gpio/{sgpio-aspeed.c => gpio-aspeed-sgpio.c} (100%)

> 

> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig

> index 38e096e6925f..7138290cdd36 100644

> --- a/drivers/gpio/Kconfig

> +++ b/drivers/gpio/Kconfig

> @@ -120,6 +120,14 @@ config GPIO_ASPEED

>  	help

>  	  Say Y here to support Aspeed AST2400 and AST2500 GPIO controllers.

>  

> +config GPIO_ASPEED_SGPIO

> +	bool "Aspeed SGPIO support"

> +	depends on (ARCH_ASPEED || COMPILE_TEST) && OF_GPIO

> +	select GPIO_GENERIC

> +	select GPIOLIB_IRQCHIP

> +	help

> +	  Say Y here to support Aspeed AST2500 SGPIO functionality.

> +

>  config GPIO_ATH79

>  	tristate "Atheros AR71XX/AR724X/AR913X GPIO support"

>  	default y if ATH79

> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile

> index d2fd19c15bae..e4599f90f702 100644

> --- a/drivers/gpio/Makefile

> +++ b/drivers/gpio/Makefile

> @@ -32,6 +32,7 @@ obj-$(CONFIG_GPIO_AMD_FCH)		+= gpio-amd-fch.o

>  obj-$(CONFIG_GPIO_AMDPT)		+= gpio-amdpt.o

>  obj-$(CONFIG_GPIO_ARIZONA)		+= gpio-arizona.o

>  obj-$(CONFIG_GPIO_ASPEED)		+= gpio-aspeed.o

> +obj-$(CONFIG_GPIO_ASPEED_SGPIO)		+= gpio-aspeed-sgpio.o

>  obj-$(CONFIG_GPIO_ATH79)		+= gpio-ath79.o

>  obj-$(CONFIG_GPIO_BCM_KONA)		+= gpio-bcm-kona.o

>  obj-$(CONFIG_GPIO_BD70528)		+= gpio-bd70528.o

> diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/gpio/gpio-aspeed-sgpio.c

> similarity index 100%

> rename from drivers/gpio/sgpio-aspeed.c

> rename to drivers/gpio/gpio-aspeed-sgpio.c

> -- 

> 2.21.0

> 

>

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 38e096e6925f..7138290cdd36 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -120,6 +120,14 @@  config GPIO_ASPEED
 	help
 	  Say Y here to support Aspeed AST2400 and AST2500 GPIO controllers.
 
+config GPIO_ASPEED_SGPIO
+	bool "Aspeed SGPIO support"
+	depends on (ARCH_ASPEED || COMPILE_TEST) && OF_GPIO
+	select GPIO_GENERIC
+	select GPIOLIB_IRQCHIP
+	help
+	  Say Y here to support Aspeed AST2500 SGPIO functionality.
+
 config GPIO_ATH79
 	tristate "Atheros AR71XX/AR724X/AR913X GPIO support"
 	default y if ATH79
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index d2fd19c15bae..e4599f90f702 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -32,6 +32,7 @@  obj-$(CONFIG_GPIO_AMD_FCH)		+= gpio-amd-fch.o
 obj-$(CONFIG_GPIO_AMDPT)		+= gpio-amdpt.o
 obj-$(CONFIG_GPIO_ARIZONA)		+= gpio-arizona.o
 obj-$(CONFIG_GPIO_ASPEED)		+= gpio-aspeed.o
+obj-$(CONFIG_GPIO_ASPEED_SGPIO)		+= gpio-aspeed-sgpio.o
 obj-$(CONFIG_GPIO_ATH79)		+= gpio-ath79.o
 obj-$(CONFIG_GPIO_BCM_KONA)		+= gpio-bcm-kona.o
 obj-$(CONFIG_GPIO_BD70528)		+= gpio-bd70528.o
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/gpio/gpio-aspeed-sgpio.c
similarity index 100%
rename from drivers/gpio/sgpio-aspeed.c
rename to drivers/gpio/gpio-aspeed-sgpio.c