From patchwork Wed Oct 2 12:04:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 174981 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp663478ill; Wed, 2 Oct 2019 05:04:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcBLhJPtn13V8taYspXrXaPG9RcoIKILQwSMkVX6oMBJ5zEnIUaul7WNVMm98KhnzXEMVZ X-Received: by 2002:a17:906:fad6:: with SMTP id lu22mr2583133ejb.98.1570017862453; Wed, 02 Oct 2019 05:04:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570017862; cv=none; d=google.com; s=arc-20160816; b=VGbnVi6mCO/pLcyL3XDuVqhQD7lcEojUx4LnFKdsdmlIG9TOp4A6P0xuy+9XM27HIi M/Yzp/HCBAyYJAL91B5jyWBkVbhVmW0fcy4Bd+yMUK4R/s8dDfATg2HQ/j0gpCMR4oS7 NdKujiLav1aFuNXuLUbFCMmFByyE0jKs1toizxY3/PStmfbqzUhqOSSkCI+uC1lt5utp sbEC30ku4R7j8Yiv7wPr/Ze3b01MTD8eQyztlWYKPGEUaw5Y8f0Ys2WMBXFQpy2dPLCY 3PgImO8o7KIFeOriSvq3m9mYREVMACINjSUGsJPIW7wMfdqQHfnNhHN6hAqSoQI0ywf8 9CMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TMB6TblY53+4VyVSJtgn0L5ohD/FsUtecY9KXTnnDX4=; b=UFkq/xvwjYNfmqBfbA62WqbPQAUgVj1ilLXwi1WS0IBQzqGuGx5+YzUzhs4K24f5f+ rm2FhIN9ytxx+CuM7F1MIaX+kZAxpMwM8cRx8LDn5r1yMc0J0osswQtZfTplGYDxSSzF PooanYHciOzpE4tmfmFbGQ3MAuuIxdBGS3u/0DDZdRIbavd6dzLQBJn7VXum4d7LVKEV oaVA3QlBEwpxQ92IY6HIwdjcLMmETWZ84zv6aCunhyGm+Dt+W1VycxzUyJIQ6QdExemi xGcDUS796/uxTWjN1Wxu13yKsfUVxDNn97xjVHtbixoLJGPcuUf5kSdTGhVto24/8Qah gDkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqsD2s9P; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si11684177ede.380.2019.10.02.05.04.22; Wed, 02 Oct 2019 05:04:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqsD2s9P; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728389AbfJBMES (ORCPT + 8 others); Wed, 2 Oct 2019 08:04:18 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41056 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728351AbfJBMER (ORCPT ); Wed, 2 Oct 2019 08:04:17 -0400 Received: by mail-lf1-f68.google.com with SMTP id r2so12496933lfn.8 for ; Wed, 02 Oct 2019 05:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TMB6TblY53+4VyVSJtgn0L5ohD/FsUtecY9KXTnnDX4=; b=DqsD2s9P1SD/PtORTHEVfyScMUoIU61jGf1MvpZNqMizg2xPfFl/kReztOBlI4GO3e z1Go2J83GjLF8pQSMiXB4U4w1NUvICHnzC5UOXJa6j9dnv/CmSOdsXIclmhJu5ouVmiw cToPMiZ4rCxpRNxFnHuHNzLsiDwWc6LOOlN33hmZjj6W70SdmDvDd62PT+QmGNFua/B7 ooS7xH/oMHWaQ+xWj4FiiNRXj3PsjC+LqWib6sHftimrqCDAbyBFNlAuAVZcAXcj4Adn h8uW+B5LXmgVaa0IuMpmJC5qHZGVXmUXkW+tsLgrdOjtHofRERJ3R5BekTtFZDNYZVUk fx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TMB6TblY53+4VyVSJtgn0L5ohD/FsUtecY9KXTnnDX4=; b=qtL7g5XzokvtC9j4pWfKBiPcF5/zW8UWGYtsPu1YaBeRRqckc19rXgMn2LNpyGdu4/ e/BhOyX3cRlSVV0gLJnmqH5TsRV3DfSYSwi1y+LtJ+DnhysfiKDsFietytzypl369sx0 yCDuLA6igp5yIrQoFvmH2TlYqF+SFz9kuslRqoXQzVEICuE6nIiC26OGasGHgzI6REGn FxBZs3t+daHQEVvvolLONJMDZzxwpyNFw6hhAMSJbDI4jFA+23ay90ydKkEUH5hs+dPt s0mTtJ2V7A8KxBJzw2dzwTfruTM/GblGYUpdG9wVbEtmKBPnC7lXkb0VsmOZ5OGNThQa BPlg== X-Gm-Message-State: APjAAAWl0XTjnYQjVmzMZthijBAwjjiFO0PqBpSzBKrZF3p7O8tRnzcO GULhKYb0GZrfzknlojysfD6h3A== X-Received: by 2002:ac2:4a69:: with SMTP id q9mr2037834lfp.86.1570017855074; Wed, 02 Oct 2019 05:04:15 -0700 (PDT) Received: from localhost.localdomain (168-200-94-178.pool.ukrtel.net. [178.94.200.168]) by smtp.gmail.com with ESMTPSA id x2sm4833827ljj.94.2019.10.02.05.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 05:04:14 -0700 (PDT) From: Ivan Khoronzhuk To: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net Cc: kafai@fb.com, songliubraving@fb.com, yhs@fb.com, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH bpf-next 2/2] selftests/bpf: correct path to include msg + path Date: Wed, 2 Oct 2019 15:04:04 +0300 Message-Id: <20191002120404.26962-3-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191002120404.26962-1-ivan.khoronzhuk@linaro.org> References: <20191002120404.26962-1-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The "path" buf is supposed to contain path + printf msg up to 24 bytes. It will be cut anyway, but compiler generates truncation warns like: " samples/bpf/../../tools/testing/selftests/bpf/cgroup_helpers.c: In function ‘setup_cgroup_environment’: samples/bpf/../../tools/testing/selftests/bpf/cgroup_helpers.c:52:34: warning: ‘/cgroup.controllers’ directive output may be truncated writing 19 bytes into a region of size between 1 and 4097 [-Wformat-truncation=] snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path); ^~~~~~~~~~~~~~~~~~~ samples/bpf/../../tools/testing/selftests/bpf/cgroup_helpers.c:52:2: note: ‘snprintf’ output between 20 and 4116 bytes into a destination of size 4097 snprintf(path, sizeof(path), "%s/cgroup.controllers", cgroup_path); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ samples/bpf/../../tools/testing/selftests/bpf/cgroup_helpers.c:72:34: warning: ‘/cgroup.subtree_control’ directive output may be truncated writing 23 bytes into a region of size between 1 and 4097 [-Wformat-truncation=] snprintf(path, sizeof(path), "%s/cgroup.subtree_control", ^~~~~~~~~~~~~~~~~~~~~~~ cgroup_path); samples/bpf/../../tools/testing/selftests/bpf/cgroup_helpers.c:72:2: note: ‘snprintf’ output between 24 and 4120 bytes into a destination of size 4097 snprintf(path, sizeof(path), "%s/cgroup.subtree_control", cgroup_path); " In order to avoid warns, lets decrease buf size for cgroup workdir on 24 bytes with assumption to include also "/cgroup.subtree_control" to the address. The cut will never happen anyway. Signed-off-by: Ivan Khoronzhuk --- tools/testing/selftests/bpf/cgroup_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c index 4d74f3c4619b..0fb910df5387 100644 --- a/tools/testing/selftests/bpf/cgroup_helpers.c +++ b/tools/testing/selftests/bpf/cgroup_helpers.c @@ -98,7 +98,7 @@ static int enable_all_controllers(char *cgroup_path) */ int setup_cgroup_environment(void) { - char cgroup_workdir[PATH_MAX + 1]; + char cgroup_workdir[PATH_MAX - 24]; format_cgroup_path(cgroup_workdir, "");