From patchwork Mon Oct 7 21:49:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 175433 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4849339ill; Mon, 7 Oct 2019 14:53:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxx97ru3ekb9Bs1J/PwcFHbDsy5l/INEmNZ5cws1IqlhuJmhBQnePPe6o5c/J/aH48S1Wjx X-Received: by 2002:a05:6808:689:: with SMTP id k9mr1214442oig.58.1570485227515; Mon, 07 Oct 2019 14:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570485227; cv=none; d=google.com; s=arc-20160816; b=dggwHRRRGCPOaWW0imP+h0vpAgvT39lTkDfU0fRiJ8NXPo2sLUONAC0sYA+YX9qXEk NAtoRJRY7BUcmpzGIpJQS8SAZ7VxNKU6+hAgExDDU+BcEq9TSqO1E7bnBiX9uFhbVwFG ECD6pw9CyXmWFr4Lpn6H6JMv74p4LYCQSR8HZwV8P8xvFPd44gMczL7KwW4UUvS0X7rh 1/1dXobSDRuwNeP4Vw8ocQ2E5Z596iMZHFue53UVXI1nONTPzXwuxbf5/nQK5el6lOQd oUlSnchFAOgDF8nnVR0CBZeFA9zOo8lcaHUn1N+FzvINABhBSlaS2WI8a8MTRMbJAS6Z 7GNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :delivered-to; bh=k33Ixq2WgBBYpYV8nwIKQFQkdNXjO215KEDqFVc2DoQ=; b=B+/Fr7o9GoUvK9lFII0uDKIpRHERq23b2qT/Yx1mpnzB6GkuE8kAQiB/gb4CGBxNU1 azgN/KmpY9WANyuzusZoLUop/8eEatggAclBTA03ULWlXJqXj9tM+itw5Fsvu7aNiDr7 xPfa3vwwmRm3rW8eCGx4Lo5+brhy/aQpY2gf7IcE4j56B6aAbo6lvBGVnWOlZ8xknMfp rIWgac0Lem5xwa6Nn8gecAitM6IBPJWRzkaqo0N2i1srLGCY59w7GVLBFetotaMJFXbs RK6tGXvcsJYkNkvZ4X1JsKtd4gHPmMCkX/97hzaeGos1ZRUmjo30p/JwI5ZQXHxmFo/c 9+eQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id a144si9937099oii.221.2019.10.07.14.53.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 14:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79A95315C03D; Mon, 7 Oct 2019 21:53:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5652219C77; Mon, 7 Oct 2019 21:53:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1AF68180B536; Mon, 7 Oct 2019 21:53:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x97LnrNP014765 for ; Mon, 7 Oct 2019 17:49:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 84B655C224; Mon, 7 Oct 2019 21:49:53 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from worklaptop.redhat.com (ovpn-123-156.rdu2.redhat.com [10.10.123.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4FD45C223; Mon, 7 Oct 2019 21:49:48 +0000 (UTC) From: Cole Robinson To: libvir-list@redhat.com Date: Mon, 7 Oct 2019 17:49:30 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 16/30] storagefile: Don't access backingStoreRaw directly in FromBackingRelative X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 07 Oct 2019 21:53:46 +0000 (UTC) For the only usage, the rel == parent->backingStoreRaw, so drop the direct access Signed-off-by: Cole Robinson --- src/util/virstoragefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Daniel Henrique Barboza diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 53fe4590b4..c47df6c200 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2625,7 +2625,7 @@ virStorageSourceNewFromBackingRelative(virStorageSourcePtr parent, return NULL; /* store relative name */ - if (VIR_STRDUP(def->relPath, parent->backingStoreRaw) < 0) + if (VIR_STRDUP(def->relPath, rel) < 0) return NULL; if (!(dirname = mdir_name(parent->path))) {