diff mbox series

[BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation

Message ID 20191008095832.3473-1-ross.burton@intel.com
State New
Headers show
Series [BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation | expand

Commit Message

Ross Burton Oct. 8, 2019, 9:58 a.m. UTC
In parallel out-of-tree builds it's possible that obexd/src/builtin.h is
generated before the target directory has been implicitly created. Solve this by
creating the directory before writing into it.
---
 Makefile.obexd | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Luiz Augusto von Dentz Oct. 9, 2019, 3:01 p.m. UTC | #1
Hi Ross,

On Tue, Oct 8, 2019 at 1:03 PM Ross Burton <ross.burton@intel.com> wrote:
>

> In parallel out-of-tree builds it's possible that obexd/src/builtin.h is

> generated before the target directory has been implicitly created. Solve this by

> creating the directory before writing into it.

> ---

>  Makefile.obexd | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/Makefile.obexd b/Makefile.obexd

> index d36874770..de59d297b 100644

> --- a/Makefile.obexd

> +++ b/Makefile.obexd

> @@ -104,6 +104,7 @@ BUILT_SOURCES += obexd/src/builtin.h

>  obexd/src/plugin.$(OBJEXT): obexd/src/builtin.h

>

>  obexd/src/builtin.h: obexd/src/genbuiltin $(obexd_builtin_sources)

> +       $(AM_V_at)$(MKDIR_P) $(dir $@)

>         $(AM_V_GEN)$(srcdir)/obexd/src/genbuiltin $(obexd_builtin_modules) > $@

>

>  CLEANFILES += obexd/src/builtin.h $(builtin_files) obexd/src/obex.service

> --

> 2.20.1


Applied, thanks.

-- 
Luiz Augusto von Dentz
diff mbox series

Patch

diff --git a/Makefile.obexd b/Makefile.obexd
index d36874770..de59d297b 100644
--- a/Makefile.obexd
+++ b/Makefile.obexd
@@ -104,6 +104,7 @@  BUILT_SOURCES += obexd/src/builtin.h
 obexd/src/plugin.$(OBJEXT): obexd/src/builtin.h
 
 obexd/src/builtin.h: obexd/src/genbuiltin $(obexd_builtin_sources)
+	$(AM_V_at)$(MKDIR_P) $(dir $@)
 	$(AM_V_GEN)$(srcdir)/obexd/src/genbuiltin $(obexd_builtin_modules) > $@
 
 CLEANFILES += obexd/src/builtin.h $(builtin_files) obexd/src/obex.service