From patchwork Tue Oct 8 20:48:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 175565 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp6206718ill; Tue, 8 Oct 2019 13:48:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpfWg2WW4r/2LiRHC/27z9zP0lRZbK0RbKp2NYxuWCz8pRfGrkoJGtjjAowBaO0xb6eNNZ X-Received: by 2002:a50:eac4:: with SMTP id u4mr36273230edp.36.1570567729498; Tue, 08 Oct 2019 13:48:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570567729; cv=none; d=google.com; s=arc-20160816; b=OuRModY05SmfwqR/9K8fFXs1TEi6o1n7YNEUQe0Hwz91T2RKLDCoVS+HgvIaI8nAbL M/vx+F2FzEzjaqoOwgqpI6IoueYOi+TcmRQZZ4UIs1jV/6go9Q5Xgr5oMmu0fvbzPhnm KaOXgaYTweke/xBzeJDAFv43+ZSP4p5Lj/lS1gZXUotas6VwgPS+6mXyy5GSE/2ej3Wq WqgEfKrSgFQPQZg7/fuvd0n3a5uOnvvIvv7rU8vNF/plShooN7ElaqBwasLMquJ0IuO+ RhhjBaFZGNg6jrcAsgDHOHTBF4R/CeZTxvtbh7IEa/VRNYzVVi2/Xxu0ctUy0t+n/Af1 Wv+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nbVVUZ3Qhf2Oih+Vzfzrpge7klNd8/7wkUn5sxV3aTo=; b=PFF82+aDhBQUCR++nsEtvGBrL1kwhXX5jS4Sw0lkidVz525gPmdQX4hYwldy4e4HQ8 2NGVtqZXcWdlxrW09ASqPluGLvvrhbQwPwer9cCqUz9gTMHxo4sRI68NL6r8K4gwIb6h gHbV8cRfhDGKshM9b1qNPw6fiXRckbjkT7ZxEDMoBd37gl+BWFopln92ZeHOTdvET5Cn 3ydwnc7tNq4P0WHXMuelDF0Xs+pM8zXAhT19dY+z7fejXeFlhG6p6adcBZhLC68qwq5R lw4e5szIXtj3+CAYOo12yLe43GMxDsJVZY6A7x6yu6bNUnjUe7tidGhAm/030zRRNx6l EEnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OmHvTmqp; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l22si105336edq.174.2019.10.08.13.48.49; Tue, 08 Oct 2019 13:48:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OmHvTmqp; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731261AbfJHUst (ORCPT + 1 other); Tue, 8 Oct 2019 16:48:49 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:43492 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731134AbfJHUsZ (ORCPT ); Tue, 8 Oct 2019 16:48:25 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x98KmMpG114907; Tue, 8 Oct 2019 15:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570567702; bh=nbVVUZ3Qhf2Oih+Vzfzrpge7klNd8/7wkUn5sxV3aTo=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=OmHvTmqpYXk3YehzINLxlEUsn8Y8eJXtOKxzN8ef+hzdC2q+OWNj4EL25/9h8LkH5 F159exaMX4q3nMIFTFvAA6+CDV5k1G5RwZYSKeOYrm+V2R3OLWrUX6UE5ekzV6Ypad yalNbSB+ghNpLKE7A7icLFl6twNL5iJFqcL9u6Bc= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x98KmMih027727 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Oct 2019 15:48:22 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 8 Oct 2019 15:48:22 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Oct 2019 15:48:19 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x98KmMXt066700; Tue, 8 Oct 2019 15:48:22 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v11 16/16] leds: lp5523: Fix checkpatch issues in the code Date: Tue, 8 Oct 2019 15:48:00 -0500 Message-ID: <20191008204800.19870-17-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191008204800.19870-1-dmurphy@ti.com> References: <20191008204800.19870-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Fix checkpatch errors and warnings for the LP5523.c device driver. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 5d6002e4d657..3c7c2e68e137 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -23,13 +23,13 @@ #define LP5523_PROGRAM_LENGTH 32 /* bytes */ /* Memory is used like this: - 0x00 engine 1 program - 0x10 engine 2 program - 0x20 engine 3 program - 0x30 engine 1 muxing info - 0x40 engine 2 muxing info - 0x50 engine 3 muxing info -*/ + * 0x00 engine 1 program + * 0x10 engine 2 program + * 0x20 engine 3 program + * 0x30 engine 1 muxing info + * 0x40 engine 2 muxing info + * 0x50 engine 3 muxing info + */ #define LP5523_MAX_LEDS 9 /* Registers */ @@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, const u8 *data, size_t size) { u8 pattern[LP5523_PROGRAM_LENGTH] = {0}; - unsigned cmd; + unsigned int cmd; char c[3]; int nrchars; int ret; @@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len) static void lp5523_mux_to_array(u16 led_mux, char *array) { int i, pos = 0; + for (i = 0; i < LP5523_MAX_LEDS; i++) pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i)); @@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr) if (ret) return ret; - ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8)); + ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8)); if (ret) return ret;