From patchwork Wed Oct 9 14:41:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 175622 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp855370ill; Wed, 9 Oct 2019 07:41:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxY1lxV/wvqx8sACjThQyPbSse3SZizplZE/cD5hRfElnUWkpOmbZ/Ew+0HeJMpxVZMu8y5 X-Received: by 2002:a17:906:6d87:: with SMTP id h7mr3225057ejt.4.1570632097540; Wed, 09 Oct 2019 07:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570632097; cv=none; d=google.com; s=arc-20160816; b=t4TMrvWmePWk3D5KuWoigJYZLpmNLd3bMOh5HXLnSlSDM8VpuBXbcXyeAcHyLyhUgq N4BJwlF/Hoqy+zYxwdvHtpDXz5c/WY1hXQoiIEXO3gWz/DZVXshPNIX3Lha+/i+JIGKn 0hyiS7oT59VSjMdWmdpT2Ne7BCaN27UFvWOt1ZGMbk53rkut5cpqBp1z9d2U0NeIK8fV UFs/oJWgjOQCC+PaxSnCPi6De0B+BeUc0vCCe/88mA0N2yAxgc7eY+eLNkw0tQmiNlSc RQHPG8MuL/ZHIx2tGf6OYwwWcI6thWwz0Pv5kZhSACyFtYIzCfNpXkkWulkEmE5YISzn Wm8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kcLlMzjMsysWETgQh91f6OPcWKj+qkhd5X668mmqw/Q=; b=Q2YsWpA/Df7T8XVS98J2J9r9yQ8FgJz4AjXSS/qpAqCirYR6Pze76+zbHTJ2vY0Em/ xgRZk80x3D8g37eBNwOfnsUusxP1VFJQYSOBxKTB1xLtQ17wGMw5G490hhT8EYjPIJBO 0YSI/d6cnuZtY9vw7xb+TpaAYncW9AG6splieAf0+zy0cesJFJtsV7yJYdvU89cR7/Fc hwPTbgNmU7rA6K5lo+Mm0jv/CJzVIvUd6SzU0GdE0jfHmQkVUn6+XbvReOHa8EiFLsPx OJKXS44QBZflucaQ99mMpGbetoQK0oXOP3VEXbZ53iVjzKTkd89c7WUhYv4TLmlK2FPi tGKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GWaEyzGq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gf9si1238818ejb.230.2019.10.09.07.41.37; Wed, 09 Oct 2019 07:41:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GWaEyzGq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729471AbfJIOlg (ORCPT + 15 others); Wed, 9 Oct 2019 10:41:36 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41688 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731434AbfJIOlf (ORCPT ); Wed, 9 Oct 2019 10:41:35 -0400 Received: by mail-wr1-f68.google.com with SMTP id q9so3345678wrm.8 for ; Wed, 09 Oct 2019 07:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kcLlMzjMsysWETgQh91f6OPcWKj+qkhd5X668mmqw/Q=; b=GWaEyzGql51eoXnd1+9HbztdXoU4S+/WAXkpE3JiLjoAdSXYFfOCdRlo8ka9teKRo+ qctTklxUCgnX3HTAEi1A/qI8zu4jpaZ8Gpl0WdfdlypBR0CL9S2J6Kf/MT1h2byvXceh QK/dtGGW0CV4g99zEJvCwYenJUQLXrnwtV6F3uoN4j3DxmWgw7W3Io/JU8KvRo5Pcp8L Hdk2SNOFCK/hZLLxkSTEnvE8/h6YMePlmmSNE9eLQk3bWmnXbJspBYFqHiU7dmQb1xOs SHODCutnrqaEqWbryPH3ZYsK4fGW2F3TBYA3Lwu0I1O9fZWYurW1/M2EpF/1Bj4zKuMj H6BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kcLlMzjMsysWETgQh91f6OPcWKj+qkhd5X668mmqw/Q=; b=fF1lMfOsYSbWxvzGU6bQmOZeLCNKzO0poLaac9gnjuEiF5zV20i33SuKhQgVKxnHm/ vSXAb166COrTscJ+A5klXffXCXnxGwUXYdZTlr9RzU7FK3lr5OEhnp4B+DWcHB/8jaAr tK9ylaDNAZun4vv3n8yDBc9SOhyIEpRyRBoCun2FeLDkyZZkg0kUVCSYU6DhYT97WaKK xnmUkelb0nBCoatsx2tiLPjrsJICEv8j2bdV/SPEdpxQX4SrIZgpO0V9pAzgStQGJD4d OCQK0a6IooiIIBk4hmD1Sv1RiQC77YJaS39nQXnBOBpYlhGrARPWTjJRXOf6X2JoU2Qf 4eBw== X-Gm-Message-State: APjAAAV1nnNswLLGx+pvFPy5k54tEu+gtvp0tPdK/KKWIUj/biyHoB1X mSmvtK0SJwurd6o9Q8BYYMX21g== X-Received: by 2002:adf:de85:: with SMTP id w5mr3185456wrl.278.1570632093491; Wed, 09 Oct 2019 07:41:33 -0700 (PDT) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id b7sm3031770wrx.56.2019.10.09.07.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 07:41:32 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jorge Ramirez-Ortiz , Srinivas Kandagatla Subject: [PATCH v3 3/5] misc: fastrpc: do not interrupt kernel calls Date: Wed, 9 Oct 2019 15:41:21 +0100 Message-Id: <20191009144123.24583-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191009144123.24583-1-srinivas.kandagatla@linaro.org> References: <20191009144123.24583-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Jorge Ramirez-Ortiz the DSP firmware requires some calls to be held until processing has completed: this is to guarantee that memory continues to be accessible. Nevertheless, the fastrpc driver chooses not support the case were requests need to be held for unbounded amounts of time. If such a use-case becomes necessary, this timeout will need to be revisited. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.21.0 diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index c0fe3419c685..666c431380ce 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -959,8 +959,13 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, if (err) goto bail; - /* Wait for remote dsp to respond or time out */ - err = wait_for_completion_interruptible(&ctx->work); + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err = -ETIMEDOUT; + } else { + err = wait_for_completion_interruptible(&ctx->work); + } + if (err) goto bail;