[oe,meta-oe] nvme-cli: Use install-spec target

Message ID 20191009151926.1733788-1-raj.khem@gmail.com
State New
Headers show
Series
  • [oe,meta-oe] nvme-cli: Use install-spec target
Related show

Commit Message

Khem Raj Oct. 9, 2019, 3:19 p.m.
install target build install-hostparams as well, which tries to run nvme
tool during build, we defer that to runtime post_install anyway so we
can ignore building it during install task

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.23.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Khem Raj Oct. 12, 2019, 3:37 p.m. | #1
Stefan

Please rebase it on top of latest master and resend please. Since half
of this patch is already merged.

On Sat, 2019-10-12 at 14:44 +0200, Stefan Wiehler wrote:
> Signed-off-by: Stefan Wiehler <

> stefan.wiehler@missinglinkelectronics.com>

> ---

>  meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb | 7 +++++--

>  1 file changed, 5 insertions(+), 2 deletions(-)

> 

> diff --git a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb b/meta-

> oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb

> index 256d83f03..061c7a0fe 100644

> --- a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb

> +++ b/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb

> @@ -4,7 +4,7 @@ HOMEPAGE = "https://github.com/linux-nvme/nvme-cli"

>  SECTION = "console/utils"

>  LICENSE = "GPLv2"

>  LIC_FILES_CHKSUM =

> "file://LICENSE;md5=8264535c0c4e9c6c335635c4026a8022"

> -DEPENDS = "util-linux util-linux-native"

> +DEPENDS = "util-linux"

>  PV .= "+git${SRCPV}"

>  

>  SRC_URI = "git://github.com/linux-nvme/nvme-cli.git"

> @@ -15,15 +15,18 @@ S = "${WORKDIR}/git"

>  inherit bash-completion systemd

>  

>  do_install() {

> -    oe_runmake install DESTDIR=${D} PREFIX=${prefix} \

> +    oe_runmake install-spec DESTDIR=${D} PREFIX=${prefix} \

>          UDEVDIR=${nonarch_base_libdir}/udev

> SYSTEMDDIR=${systemd_unitdir}

>  }

>  

>  pkg_postinst_ontarget_${PN}() {

>      ${sbindir}/nvme gen-hostnqn > ${sysconfdir}/nvme/hostnqn

> +    ${bindir}/uuidgen > ${sysconfdir}/nvme/hostid

>  }

>  

>  PACKAGES =+ "${PN}-dracut ${PN}-zsh-completion"

>  

>  FILES_${PN}-dracut = "${libdir}/dracut/dracut.conf.d"

>  FILES_${PN}-zsh-completion = "${datadir}/zsh/site-functions"

> +

> +RDEPENDS_${PN} = "util-linux-uuidgen"

> -- 

> 2.19.2

> 


-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb b/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
index 256d83f039..fa47c9e7bc 100644
--- a/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
+++ b/meta-oe/recipes-bsp/nvme-cli/nvme-cli_1.9.bb
@@ -15,7 +15,7 @@  S = "${WORKDIR}/git"
 inherit bash-completion systemd
 
 do_install() {
-    oe_runmake install DESTDIR=${D} PREFIX=${prefix} \
+    oe_runmake install-spec DESTDIR=${D} PREFIX=${prefix} \
         UDEVDIR=${nonarch_base_libdir}/udev SYSTEMDDIR=${systemd_unitdir}
 }