[oe,meta-oe] jsonrpc: Disable coverage in default build

Message ID 20191011004907.1347765-1-raj.khem@gmail.com
State New
Headers show
Series
  • [oe,meta-oe] jsonrpc: Disable coverage in default build
Related show

Commit Message

Khem Raj Oct. 11, 2019, 12:49 a.m.
Building with intrumentation is only useful during development or
optimization phases, in production, this will just make it slow and in
some cases not work where file system might be readonly.

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb | 1 +
 1 file changed, 1 insertion(+)

-- 
2.23.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Tim Orling Oct. 11, 2019, 12:59 a.m. | #1
PACKAGECONFIG  option? Or do you just think users wanting coverage would
override EXTRA_OECMAKE?

On Thu, Oct 10, 2019 at 5:49 PM Khem Raj <raj.khem@gmail.com> wrote:

> Building with intrumentation is only useful during development or

> optimization phases, in production, this will just make it slow and in

> some cases not work where file system might be readonly.

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb

> b/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb

> index b23775708a..6ad0a49abd 100644

> --- a/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb

> +++ b/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb

> @@ -18,6 +18,7 @@ inherit cmake

>

>  EXTRA_OECMAKE += "-DCOMPILE_TESTS=NO -DCOMPILE_STUBGEN=NO

> -DCOMPILE_EXAMPLES=NO \

>                    -DBUILD_SHARED_LIBS=YES -DBUILD_STATIC_LIBS=YES \

> +                  -DWITH_COVERAGE=NO \

>                    -DCMAKE_LIBRARY_PATH=${libdir} \

>  "

>

> --

> 2.23.0

>

> --

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb b/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb
index b23775708a..6ad0a49abd 100644
--- a/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb
+++ b/meta-oe/recipes-devtools/jsonrpc/jsonrpc_1.2.0.bb
@@ -18,6 +18,7 @@  inherit cmake
 
 EXTRA_OECMAKE += "-DCOMPILE_TESTS=NO -DCOMPILE_STUBGEN=NO -DCOMPILE_EXAMPLES=NO \
                   -DBUILD_SHARED_LIBS=YES -DBUILD_STATIC_LIBS=YES \
+                  -DWITH_COVERAGE=NO \
                   -DCMAKE_LIBRARY_PATH=${libdir} \
 "