diff mbox series

[v6,07/20] target/arm: Split out rebuild_hflags_a32

Message ID 20191011155546.14342-8-richard.henderson@linaro.org
State Superseded
Headers show
Series target/arm: Reduce overhead of cpu_get_tb_cpu_state | expand

Commit Message

Richard Henderson Oct. 11, 2019, 3:55 p.m. UTC 
Currently a trivial wrapper for rebuild_hflags_common_32.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/helper.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Alex Bennée Oct. 14, 2019, 4:17 p.m. UTC | #1 
Richard Henderson <richard.henderson@linaro.org> writes:

> Currently a trivial wrapper for rebuild_hflags_common_32.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---

>  target/arm/helper.c | 8 +++++++-

>  1 file changed, 7 insertions(+), 1 deletion(-)

>

> diff --git a/target/arm/helper.c b/target/arm/helper.c

> index 296a4b2232..d1cd54cc93 100644

> --- a/target/arm/helper.c

> +++ b/target/arm/helper.c

> @@ -11106,6 +11106,12 @@ static uint32_t rebuild_hflags_m32(CPUARMState *env, int fp_el,

>      return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags);

>  }

>

> +static uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el,

> +                                   ARMMMUIdx mmu_idx)

> +{

> +    return rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);

> +}

> +

>  static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,

>                                     ARMMMUIdx mmu_idx)

>  {

> @@ -11218,7 +11224,7 @@ void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc,

>                  flags = FIELD_DP32(flags, TBFLAG_A32, LSPACT, 1);

>              }

>          } else {

> -            flags = rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);

> +            flags = rebuild_hflags_a32(env, fp_el, mmu_idx);

>          }

>

>          flags = FIELD_DP32(flags, TBFLAG_A32, THUMB, env->thumb);



--
Alex Bennée
diff mbox series

Patch

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 296a4b2232..d1cd54cc93 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -11106,6 +11106,12 @@  static uint32_t rebuild_hflags_m32(CPUARMState *env, int fp_el,
     return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags);
 }
 
+static uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el,
+                                   ARMMMUIdx mmu_idx)
+{
+    return rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);
+}
+
 static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
                                    ARMMMUIdx mmu_idx)
 {
@@ -11218,7 +11224,7 @@  void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc,
                 flags = FIELD_DP32(flags, TBFLAG_A32, LSPACT, 1);
             }
         } else {
-            flags = rebuild_hflags_common_32(env, fp_el, mmu_idx, 0);
+            flags = rebuild_hflags_a32(env, fp_el, mmu_idx);
         }
 
         flags = FIELD_DP32(flags, TBFLAG_A32, THUMB, env->thumb);