From patchwork Tue Oct 22 13:31:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 177190 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp4903744ill; Tue, 22 Oct 2019 07:00:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFbQGbP7Zf0khexWgQ9Za3vgnoKBvHdYa3YWTHPTP+izULOYPpARgxqSXoASCpDCcnwt0G X-Received: by 2002:ac8:2247:: with SMTP id p7mr3515435qtp.180.1571752801553; Tue, 22 Oct 2019 07:00:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571752801; cv=none; d=google.com; s=arc-20160816; b=StxtU3gUY5bQRKzmcwcvfuOiDuQh96XkbQ8PopNU/EgWr+bk0Y5/V1gfE1tAV6mUSS LVXuFja3BNGUPGhRFaDIKG6p44R3ensKW7ZZKJQIGNfr15Fq3qHhueUaA23ucr+TBwOT cXG1kq636Pzhb1D1WOt//Gec9m7NNaf4cXZP7Ewm/CcE7vvZuDpOFohSwJofLEaqyp4H jMrc157aRNDlsnVXSkZspAhtk9GVsnHx7jShRAsukiV+JDtbhdfkSKVL+e7YPtJ+4ojY OSMg9ObXoUOJdVY6yTHQWDiIfokXBwpCCRuQTRVlICQWmcptM1i3qmYAvBniUmNN7yPg m5/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=XIcMLgLOy6AOjihetZxPEvZlo29WPIvHIy0xHe5Xspw=; b=yZOfJ4FpOstfAumq8FlXwoy8RCJQDJ835BofWoBKbaifuaB31E2LJ+JjbYXEYw+I/j dIuZag9wDCgtkYUdJMB8J2uzMPcraTfc5gZLrk9YhCb3Qu2s4beqkuAyVCHRoLB6+lki PKDgCUqo+XQjXId+vprvSMnZp1S3gjAlnnzqZ2g2tUJ6nz7J2iIYRbgjAGdcQwhTke1m C8/GWrs3aCqUZvn9PjOiPPLc78vZv0moWnS3wAiK7i0bM+J1GNQsUjYhPTx/ZtYBA53B lHqcrzntjKxrrDvZlNeH22ri2qzvO1VHyEgjYXQo6JlSkfoYB/38wXEMD5Ex03PRULoW msTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cw0FXpfY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y41si16526217qve.167.2019.10.22.07.00.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Oct 2019 07:00:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cw0FXpfY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMuhc-0001UP-IA for patch@linaro.org; Tue, 22 Oct 2019 10:00:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36985) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMuH8-00038C-7q for qemu-devel@nongnu.org; Tue, 22 Oct 2019 09:32:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMuH5-0001Q8-Vz for qemu-devel@nongnu.org; Tue, 22 Oct 2019 09:32:37 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:44015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMuH5-0001PZ-Pq for qemu-devel@nongnu.org; Tue, 22 Oct 2019 09:32:35 -0400 Received: by mail-wr1-x42e.google.com with SMTP id c2so12855883wrr.10 for ; Tue, 22 Oct 2019 06:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=XIcMLgLOy6AOjihetZxPEvZlo29WPIvHIy0xHe5Xspw=; b=Cw0FXpfYiZ0MB8qI9iXrI5B0xjpmT94qfAYKX5hbnRaV+gxwEvRLw7xxFPix9GkBGK v2SixdegqgmQONCeazgzWtw32b2akft8j1k7MX0r6usDCiwmYCmii4odkYvLDEX4YIU0 EI+vl2lfTt28+lfiqbE4hhS59jW/xoG8mB6+olZHfn90FU1k9xuQrfql16/yyey3r2Qi IV0yErEgKOOYUBY0ITgJka7IH2xJcg0djOHYpd2shJq3cpOjbWwrET+1oLNh0812Xqfm PbD7JjnNcEVAM7PUYUd41UUmyz70zNjm/HaZIIyUqiIa1VFJk/HXGpEeEvivsdK+OzPo gOjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XIcMLgLOy6AOjihetZxPEvZlo29WPIvHIy0xHe5Xspw=; b=CpXk5a5qHokQEJ+0eX9xDkd96p7WWQjYZge6qW4pmY+qMNSmFaCtrvqZ8aZ2kAGONT vpxZFHvGr3XE5b0+WS+JytRjf7l1/sJKOQG6JvY0KM5QCJsiVfspMP/nVkr613kn8h96 ovCqlrH8xrvhJCYpneU2/Vl3U7sWUJD3oiqTQP+bDPbRsgy6qwORF1CsJ0K2mbCjpLWQ KwDedR5pqQeVqpal0C0EZgmck+pKo1eYXHBmvC4VIq38jfAoeiTLDwTX3nje128T7IFA LAdFDyC8s6yuZRg3HhsCL37rOsrgDf4WPKaSb6CK6ENg/ofNG2ilsyH35eCNUT6EDgeM WWPQ== X-Gm-Message-State: APjAAAXl2tSLL18ye+Jqa0lVgrku/rPgX9AoCcvuqKDiDbj2nqTpzruv ykOb9iQJMKi4yXb2VJ+pDezbuZ8ljG0= X-Received: by 2002:a5d:6a02:: with SMTP id m2mr3807170wru.304.1571751154248; Tue, 22 Oct 2019 06:32:34 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id r2sm20263856wma.1.2019.10.22.06.32.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 06:32:33 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 24/41] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state Date: Tue, 22 Oct 2019 14:31:17 +0100 Message-Id: <20191022133134.14487-25-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191022133134.14487-1-peter.maydell@linaro.org> References: <20191022133134.14487-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson By performing this store early, we avoid having to save and restore the register holding the address around any function calls. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20191018174431.1784-15-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/target/arm/helper.c b/target/arm/helper.c index 3f7d3f257d8..37424e3d4dd 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -11225,6 +11225,7 @@ void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc, { uint32_t flags, pstate_for_ss; + *cs_base = 0; flags = rebuild_hflags_internal(env); if (is_a64(env)) { @@ -11298,7 +11299,6 @@ void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc, } *pflags = flags; - *cs_base = 0; } #ifdef TARGET_AARCH64