From patchwork Thu Oct 24 13:23:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 177497 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp2156240ocf; Thu, 24 Oct 2019 06:24:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMipRg1Xf/vo+c5mbj/p3c5B6E3QuzzZIdXWXhphGvxeSjlabFniIwr7vWOI3j91bURBYV X-Received: by 2002:a05:6402:330:: with SMTP id q16mr1968730edw.249.1571923475323; Thu, 24 Oct 2019 06:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571923475; cv=none; d=google.com; s=arc-20160816; b=rUaUXXEnOuBCLneZDXATD8vzI7BCfCUMVwohFo6WBv+3LldjPnGCQqZQf1cRVuFM1L XJPNGjhIvvMnUA1LVY87+7AmErQheiszmaaeGYMEkiDVY1Td7MBN7AfM2Fucaang1VLC AOZVMEX/UCO9yUp3DwoTZhzSaSWNNkaY9loJGOUA/5ciEQAEvIbjLyepNs2nJj0fKaHk g+pZ5efWJwEf8iRtVF7C8qwUJg1bnZQ8Zzax4pnGuhOGRMJWtq1Q1+qh/q6Fk7g63QXi N8lWorvusKwMfn0r6y28RwUjnSdqfi76rg+SmjicSO4rTIyNddZn3mffoMfVhIEShNx3 k2qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gafT1c0FgkNr2xD+zkDSgemAEsZK/gkAa/8lkYnPPKw=; b=LtKWhb7o3zcPB9xr1KHqhsqoW5hC7ztU1cyC8WBRAGjpgIVUJyI5Mj/HI6vkL3R82y M/pI/YGhEaKib8PuIwZf+zr1XcddMwhc0WwL0qj+naQK7Xqab6AFJQyuVfPHL7u75CFc KheylxhfMk045siKSG+Rpw6E+QDCXgzJtBIfTdX/+7cWfY2jIrkeqI4oiuD81AWy+Umu 3ltGTiUi64FEQW5XNrW8ijCULX6VmQtFtKxNHvVuQz5yj41kkXCy7gh/euhwdNsoaSTx LRkwgy++0LFLTmi6CHyf3QO2p76HlnlBzOyQCXSAknZcYqpFyJti34usUgUgIu2EXTTF 1loA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CHB38qnm; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si14702710ejj.70.2019.10.24.06.24.35; Thu, 24 Oct 2019 06:24:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CHB38qnm; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732125AbfJXNYe (ORCPT + 3 others); Thu, 24 Oct 2019 09:24:34 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54548 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731935AbfJXNYe (ORCPT ); Thu, 24 Oct 2019 09:24:34 -0400 Received: by mail-wm1-f65.google.com with SMTP id g7so2829956wmk.4 for ; Thu, 24 Oct 2019 06:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gafT1c0FgkNr2xD+zkDSgemAEsZK/gkAa/8lkYnPPKw=; b=CHB38qnmiIoWY26c3wRxuzk+ZOSa7lwUYBKbyXFt+GT9s2qCB78UmvViVvoiQM7QTY rW2Rcd6SGJIGgGVFNX0SJQXjO+WQVjD4QkIgV0+UI5iEFxbOyFlyTAx0uxmVAn/COzNa ZzY0Bz17VitJ6ppDTaokb69HwslnO20Mo6PNP4LQbUHsHC/kX1f+Al6G3aWrHGy7jvdv 30OisuNk6PgBOI27Znki2YEYKb2BtGep5t8l/NUS1bxAoMb29C03ETB/wv32800J7BBz KwB8Gti8rHMxcu+7DWapIuAph1mtDeASezoAay2t19YtwNGS+qginVZDnBYSm5G+v2XW O0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gafT1c0FgkNr2xD+zkDSgemAEsZK/gkAa/8lkYnPPKw=; b=DJ2CmXCpJeRPmM8cRzQkY2H2CUQUOoGll5A/4jXJ0cxIPMSIPdKnnsaSXrJrPJcrVa NVsrZhL/3FkRFFenHLLINUSTtC9QTw3p9Y6F6EpPwv1a98eXaga/alpDV6p8Tjz3lwG6 61RDSg2Q+9MVJ1/AKr58uRkLXFxRQYACGFar9tLq0+FxLHDURiGE660PHlUvAKQE5hM3 GjiPXDWWz7expvNR9+Mrg1Hco8Jj4zJHzoWobjQRd3rd+NL+rG3MKz4ChpT3IqzglTEj Qawd/0xfVvzvgbdpuMGKoPqRVfOswNlg678MWQvfSBERMfhpHjB2hIQEeSVcFS6N/o5I RtOw== X-Gm-Message-State: APjAAAXxan3IF8rIFVPqozu1O/Mn5MPushjY7o6UVLpz7aSjDFDwYPO5 a5J/H3ZrzmzOO0rIxK94Zkh22HTmLMzY86tU X-Received: by 2002:a1c:49c2:: with SMTP id w185mr4782947wma.16.1571923471290; Thu, 24 Oct 2019 06:24:31 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-657-1-83-120.w92-154.abo.wanadoo.fr. [92.154.90.120]) by smtp.gmail.com with ESMTPSA id e3sm2346310wme.36.2019.10.24.06.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 06:24:30 -0700 (PDT) From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: Ard Biesheuvel , Herbert Xu , "David S. Miller" , Eric Biggers , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 27/27] crypto: nx - remove stale comment referring to the blkcipher walk API Date: Thu, 24 Oct 2019 15:23:45 +0200 Message-Id: <20191024132345.5236-28-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191024132345.5236-1-ard.biesheuvel@linaro.org> References: <20191024132345.5236-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org These drivers do not use either the deprecated blkcipher or the current skcipher walk API, so this comment must refer to a previous state of the driver that no longer exists. So drop the comments. Signed-off-by: Ard Biesheuvel --- drivers/crypto/nx/nx-aes-ccm.c | 5 ----- drivers/crypto/nx/nx-aes-gcm.c | 5 ----- 2 files changed, 10 deletions(-) -- 2.20.1 diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c index 84fed736ed2e..4c9362eebefd 100644 --- a/drivers/crypto/nx/nx-aes-ccm.c +++ b/drivers/crypto/nx/nx-aes-ccm.c @@ -525,11 +525,6 @@ static int ccm_aes_nx_decrypt(struct aead_request *req) return ccm_nx_decrypt(req, req->iv, req->assoclen); } -/* tell the block cipher walk routines that this is a stream cipher by - * setting cra_blocksize to 1. Even using blkcipher_walk_virt_block - * during encrypt/decrypt doesn't solve this problem, because it calls - * blkcipher_walk_done under the covers, which doesn't use walk->blocksize, - * but instead uses this tfm->blocksize. */ struct aead_alg nx_ccm_aes_alg = { .base = { .cra_name = "ccm(aes)", diff --git a/drivers/crypto/nx/nx-aes-gcm.c b/drivers/crypto/nx/nx-aes-gcm.c index 898220e159d3..19c6ed5baea4 100644 --- a/drivers/crypto/nx/nx-aes-gcm.c +++ b/drivers/crypto/nx/nx-aes-gcm.c @@ -467,11 +467,6 @@ static int gcm4106_aes_nx_decrypt(struct aead_request *req) return gcm_aes_nx_crypt(req, 0, req->assoclen - 8); } -/* tell the block cipher walk routines that this is a stream cipher by - * setting cra_blocksize to 1. Even using blkcipher_walk_virt_block - * during encrypt/decrypt doesn't solve this problem, because it calls - * blkcipher_walk_done under the covers, which doesn't use walk->blocksize, - * but instead uses this tfm->blocksize. */ struct aead_alg nx_gcm_aes_alg = { .base = { .cra_name = "gcm(aes)",