| Message ID | 20191029123809.29301-5-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 76b54cf033c9f2effc70066a2bbb2331013889a1 |
| Headers | show |
| Series | More nsdeps improvements | expand |
Hi! On Tue, Oct 29, 2019 at 09:38:09PM +0900, Masahiro Yamada wrote: >The local variable, ns_entry, is unneeded. > >While I was here, I also cleaned up the comparison with NULL or 0. > >Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >--- This was not directly sent to me, hence I missed it. Nevertheless, please feel free to add Reviewed-by: Matthias Maennich <maennich@google.com> Cheers, Matthias > > scripts/mod/modpost.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c >index f7425f5d4ab0..f70b924f379f 100644 >--- a/scripts/mod/modpost.c >+++ b/scripts/mod/modpost.c >@@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name) > static bool contains_namespace(struct namespace_list *list, > const char *namespace) > { >- struct namespace_list *ns_entry; >- >- for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next) >- if (strcmp(ns_entry->namespace, namespace) == 0) >+ for (; list; list = list->next) >+ if (!strcmp(list->namespace, namespace)) > return true; > > return false; >-- >2.17.1 >
On Tue, Oct 29, 2019 at 9:38 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > The local variable, ns_entry, is unneeded. > > While I was here, I also cleaned up the comparison with NULL or 0. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Fixed the typo in the subject ( mospost -> modpost ) and applied to linux-kbuild. > > scripts/mod/modpost.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f7425f5d4ab0..f70b924f379f 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name) > static bool contains_namespace(struct namespace_list *list, > const char *namespace) > { > - struct namespace_list *ns_entry; > - > - for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next) > - if (strcmp(ns_entry->namespace, namespace) == 0) > + for (; list; list = list->next) > + if (!strcmp(list->namespace, namespace)) > return true; > > return false; > -- > 2.17.1 > -- Best Regards Masahiro Yamada
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index f7425f5d4ab0..f70b924f379f 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name) static bool contains_namespace(struct namespace_list *list, const char *namespace) { - struct namespace_list *ns_entry; - - for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next) - if (strcmp(ns_entry->namespace, namespace) == 0) + for (; list; list = list->next) + if (!strcmp(list->namespace, namespace)) return true; return false;
The local variable, ns_entry, is unneeded. While I was here, I also cleaned up the comparison with NULL or 0. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- scripts/mod/modpost.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.17.1