From patchwork Tue Oct 29 13:12:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 178028 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp4859669ill; Tue, 29 Oct 2019 06:13:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuer4RO6sq72033xwfBHiUTKzNTOXq1GxWK3US+d8AeVi1yShmwB7eqmVjYTnKRqTogPfJ X-Received: by 2002:a17:906:50d:: with SMTP id j13mr3202909eja.146.1572354803949; Tue, 29 Oct 2019 06:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572354803; cv=none; d=google.com; s=arc-20160816; b=nOSaGBVHfPALPRQcUmElU+ZYUAORuhk7/4F09UFAyYhxvME9L8kdsE7hawiifTIyPi 3bLgkOGfGnVY7WusKLzxrpKNrNjvDTm3GbVX2N9G1GHnSlAKhuaihhTQTPXojCCjTwVt DWWgr47LVn+T5DoQzHms5vW3wyrk2wSIPPJ9PaUw2EH+eSZ8/LWQZThb/1UFCFRBJ6hi cyYLmNYsbLyEJT4kJy2ynRLONeP54zSI2RLLWTtw1dWH/+bn0UVSw77OWzvwTA38zFwZ 3wtmX23OyVvT1hu6EAwOin88OiGtW3O+hAlriNv90tkgj7KEZBw+B8r66l70cX7rGdDx bBaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:dkim-filter; bh=DFJCAzizH4g10ADI9Rn27rAUxoPMKfPEwBoru1VHVxA=; b=JhwB2Kx0L/VhRrNvjX0RoMuyoD+5V2m0APph1/BDIBrVXwrA6LvwOl2CRuR+PvAZer frzhcNG15ac6adIf9VIm3GPFqpjOX8qrUhv+Fl02qZi1tFoKjm5+xqKC2u7TCsb2k45Q o2cwrkNJpI4LyLJ6oxfSKpPgNEjX3vOltivbtKHqLzNWnnGxCeP0LIgb7NtQ9sXRj+LY 5tlW6801kZ4jhYs9SR5aYxCzZTNpM59EQGCDR0Tn9QGtjyc35xtOkJsc2iqSnzzklHfF efqihy8YlXggWZ1SlpkBysL3bQh7Md8H8Imr1AZv8WF4gnbnYBgDMaTV41BR/QdNfvp7 ooAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=reO02uSb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34si9111579eda.268.2019.10.29.06.13.23; Tue, 29 Oct 2019 06:13:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=reO02uSb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388253AbfJ2NNW (ORCPT + 26 others); Tue, 29 Oct 2019 09:13:22 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:17799 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388235AbfJ2NNW (ORCPT ); Tue, 29 Oct 2019 09:13:22 -0400 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (authenticated) by conssluserg-03.nifty.com with ESMTP id x9TDD9H7008016 for ; Tue, 29 Oct 2019 22:13:09 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com x9TDD9H7008016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1572354790; bh=DFJCAzizH4g10ADI9Rn27rAUxoPMKfPEwBoru1VHVxA=; h=From:Date:Subject:To:Cc:From; b=reO02uSbAHEiFpcpuoY5UJNhpn0kLh5Dj2QO71BSTK3k3pwXlQDuuAtgPWtz3zNIH NfPDCNagWGZDJY7oPXPs/Ps/0Pe/9cNig5HWLYrnpFiCtrm8o3GvrAT0ia1hlY9INT MvuDMWB4G82zqXlOGIX8Ism57sfinIjk5fYGTDVh7Fh5gosTU+HyPx4Au2c+g6lSal MNL6df8Hg+gKRg/3lAoTGrRZVUjMTMHQBuYEurTE2BvV4T95XenPDXPxgUliKdu//2 XuCoraRjAn5byjZm3heDx9pTKoAEr5L+HIIaGnjJO8SuCAE+4mGgkxEE5OBbOS+Wua hMacoe4lqPsIQ== X-Nifty-SrcIP: [209.85.221.174] Received: by mail-vk1-f174.google.com with SMTP id g14so2846820vkl.5 for ; Tue, 29 Oct 2019 06:13:09 -0700 (PDT) X-Gm-Message-State: APjAAAVJN7WFDAZlcBail+dSFwJmgpVXv510dG+rYUnJ9ZyBjz/Ijj8Z ZKbfIp6RoULmSDLi0y6YDOowzegJhzpJH+jO22U= X-Received: by 2002:a1f:4b05:: with SMTP id y5mr11132787vka.12.1572354788616; Tue, 29 Oct 2019 06:13:08 -0700 (PDT) MIME-Version: 1.0 From: Masahiro Yamada Date: Tue, 29 Oct 2019 22:12:32 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Warning message from 'make nsdeps' when namespace is lower cases To: Matthias Maennich , Jessica Yu , Julia Lawall Cc: Coccinelle , Linux Kernel Mailing List Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. When I was playing with 'make nsdeps', I saw a new warning. If I rename USB_STORAGE to usb_storage, I see 'warning: line 15: should usb_storage be a metavariable?' Why? I think it comes from spatch. It should be technically OK to use either upper or lower cases for the namespace name. Just apply the following, and try 'make nsdeps'. -- Best Regards Masahiro Yamada diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile index 46635fa4a340..6f817d65c26b 100644 --- a/drivers/usb/storage/Makefile +++ b/drivers/usb/storage/Makefile @@ -8,7 +8,7 @@ ccflags-y := -I $(srctree)/drivers/scsi -ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE +ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=usb_storage obj-$(CONFIG_USB_UAS) += uas.o obj-$(CONFIG_USB_STORAGE) += usb-storage.o