From patchwork Tue Nov 5 14:00:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 178499 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp709170ocf; Tue, 5 Nov 2019 06:01:30 -0800 (PST) X-Google-Smtp-Source: APXvYqy0M83QT7+a0iD2x5l2IpH+Mx4yYQ/eBWmVJnvfbSLeNTxa8LwNWpEoECS6rZ7bP6xc1zAE X-Received: by 2002:a50:cc43:: with SMTP id n3mr36442823edi.287.1572962490177; Tue, 05 Nov 2019 06:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572962490; cv=none; d=google.com; s=arc-20160816; b=s+AyH9U4aSWFunAoTbclYTRA5KtPZI7jnXNKRK2cediMcQ8rX5rLd72PltdPkxdy1k 7OIQwrsP9MAKYK+hIAebMvFp5mscy3Jo3F7ysM4I4LwlgYMU0B62lX8OAOZCZEfW9XEL wRGA7xEVULWwl7X6hWPdM/AxyQFTCEZK3waUzKYeUJwMsbr3OQRap1Alx2xYDMJDhp8m BIzCVVoVbfsGAUo5E89KC32L3sBJ//SK0yGRjyauKbN8WqAIbNRFFIksuwzrYLuqVpXm hAInk4Q6t9UqCTop9PkVPzkXW9ZkXlPJM5SPnHhKRqIaZhRoGEHjpYKRyXLh7UckHfS/ 70Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=DlKZU2pnO04HoutMJq1MepcXwIlqftahdOsUH2+lg9Q=; b=z2Ehl9yM8ld/PpfiGCl/FV4jAAiBOMBjoWrWG5Ta1/9Q1FMR8c2GP2TA/FKGEosMtL QXZ1Q8pQ5Hpzud2NSoTqCoZTxB3rIK8/f7W57HQRlnnTO9dk/4KRQlqW/pKrYwpYQg2S +y0+hJXkZI67KJSgKV2oJWM3SKZ/lDohax3l5GzMzzohP5fqsIkf85bmucYm7jSecmlL l1JseiaklRS4zFYuES/3aZVok3n0d5L9kSQlkBOyF9lakKKAhzuJkzVshunPT740RcRw Idze5EQOfpTd4lTnzL2x9ogDlLHQbnyBgl1/NMs/930FyBFWhZaUAX/3s8/w7p0aDZJc Nfvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=YSLy33ni; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dk11si13340421ejb.97.2019.11.05.06.01.30; Tue, 05 Nov 2019 06:01:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=YSLy33ni; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389325AbfKEOB3 (ORCPT + 5 others); Tue, 5 Nov 2019 09:01:29 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44690 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389300AbfKEOB3 (ORCPT ); Tue, 5 Nov 2019 09:01:29 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xA5E1NEL043354; Tue, 5 Nov 2019 08:01:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572962483; bh=DlKZU2pnO04HoutMJq1MepcXwIlqftahdOsUH2+lg9Q=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=YSLy33ninCGUHbjzm8f/GKFxgqgZqrVeuWf0TKaET7HX1MfyZ88q7l2eyK2wSWwFU 73tGEiQcvHhF4+7NWn0xxrGimL0txljGSKQYdBQbgA72FTuBHqwuz0/Cxf30b/1dT5 U1JztIU7T0cCE/V0EVCsQVMy8VbsasfIz7lqsWqk= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xA5E1N5m059512 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Nov 2019 08:01:23 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 5 Nov 2019 08:01:23 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 5 Nov 2019 08:01:08 -0600 Received: from sokoban.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA5E1FFg068289; Tue, 5 Nov 2019 08:01:21 -0600 From: Tero Kristo To: , , CC: , Subject: [PATCHv2 03/22] crypto: omap-aes: remove the sysfs group during driver removal Date: Tue, 5 Nov 2019 16:00:52 +0200 Message-ID: <20191105140111.20285-4-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191105140111.20285-1-t-kristo@ti.com> References: <20191105140111.20285-1-t-kristo@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The driver removal should also cleanup the created sysfs group. If not, the driver fails the subsequent probe as the files exist already. Also, drop a completely unnecessary pointer assignment from the removal function at the same time. Signed-off-by: Tero Kristo --- drivers/crypto/omap-aes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index a1fc03ed01f3..38c750e83dbe 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -1296,7 +1296,8 @@ static int omap_aes_remove(struct platform_device *pdev) tasklet_kill(&dd->done_task); omap_aes_dma_cleanup(dd); pm_runtime_disable(dd->dev); - dd = NULL; + + sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group); return 0; }