[v2,06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check

Message ID 20191106141308.30535-7-rth@twiddle.net
State Accepted
Commit 904caa6413c87aacbf7d0682da617c39ca18cf1a
Headers show
  • Improvements for random.h/archrandom.h
Related show

Commit Message

Richard Henderson Nov. 6, 2019, 2:13 p.m.
We must not use the pointer output without validating the
success of the random read.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Signed-off-by: Richard Henderson <rth@twiddle.net>

 include/linux/random.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/include/linux/random.h b/include/linux/random.h
index ea0e2f5f1ec5..d319f9a1e429 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -167,19 +167,19 @@  static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
 # include <asm/archrandom.h>
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
 	return false;
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
 	return false;