[v2,10/10] s390x: Mark archrandom.h functions __must_check

Message ID 20191106141308.30535-11-rth@twiddle.net
State Accepted
Commit 4cb760b02419061209b9b4cc2557986a6bf93e73
Headers show
  • Improvements for random.h/archrandom.h
Related show

Commit Message

Richard Henderson Nov. 6, 2019, 2:13 p.m.
We must not use the pointer output without validating the
success of the random read.

Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Signed-off-by: Richard Henderson <rth@twiddle.net>

 arch/s390/include/asm/archrandom.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/arch/s390/include/asm/archrandom.h b/arch/s390/include/asm/archrandom.h
index 9a6835137a16..de61ce562052 100644
--- a/arch/s390/include/asm/archrandom.h
+++ b/arch/s390/include/asm/archrandom.h
@@ -21,17 +21,17 @@  extern atomic64_t s390_arch_random_counter;
 bool s390_arch_random_generate(u8 *buf, unsigned int nbytes);
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
 	return false;
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
 	if (static_branch_likely(&s390_arch_random_available)) {
 		return s390_arch_random_generate((u8 *)v, sizeof(*v));
@@ -39,7 +39,7 @@  static inline bool arch_get_random_seed_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
 	if (static_branch_likely(&s390_arch_random_available)) {
 		return s390_arch_random_generate((u8 *)v, sizeof(*v));