[v2,09/10] powerpc: Mark archrandom.h functions __must_check

Message ID 20191106141308.30535-10-rth@twiddle.net
State Accepted
Commit 8dae77ac56fec1e085fca3ecea49abda1b4b73d2
Headers show
  • Improvements for random.h/archrandom.h
Related show

Commit Message

Richard Henderson Nov. 6, 2019, 2:13 p.m.
We must not use the pointer output without validating the
success of the random read.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Signed-off-by: Richard Henderson <rth@twiddle.net>

 arch/powerpc/include/asm/archrandom.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index 7766812e2355..60b8ad798743 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -6,17 +6,17 @@ 
 #include <asm/machdep.h>
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
 	return false;
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
 	if (ppc_md.get_random_seed)
 		return ppc_md.get_random_seed(v);
@@ -24,7 +24,7 @@  static inline bool arch_get_random_seed_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
 	unsigned long val;
 	bool rc;