From patchwork Thu Nov 7 15:09:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 178809 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1168345ilf; Thu, 7 Nov 2019 07:10:08 -0800 (PST) X-Google-Smtp-Source: APXvYqz4S24j09/gsPh9tqN/l5n+muPRqoG6cEzxdfnD79o023mkc7DqeckpXR6Nq4t4nXVK56G+ X-Received: by 2002:a17:906:913:: with SMTP id i19mr3429268ejd.23.1573139408649; Thu, 07 Nov 2019 07:10:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573139408; cv=none; d=google.com; s=arc-20160816; b=yTpOfpnC87NX+G5tkg53wou/Hp07nlPZOCfpfyo0ZnuLofYXGu7LSRRIfPsSxPiWVZ +5E6VF/F8vIbBxtJsWrGu8tPDslQM7DV3i9HRdmB8Hkg44REmsB3IHgcJ3ZYe3EjdJW+ qOBJ8CpEYqwmwUDMLz+pYRqFQ8Ts/Gov0tzpNOVglL1FbpC7Sc0z44wFi3omS8utnL+0 Qnj8MRe9i7datQ+fdY3RwZeARqy6HlxI7qHsgDxdYOM7NgZQu3L1k1rodHPOPb0958ES vJCVHw8BhtsR827t0zIhgld5akWjPKp0YOMUGofheCRBOInyhzQ1TE2uzgG/PAurQJGn wAMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=j+Cvt6seYHFvw2RmLOUQxrYQHSymidnwSWT4pOwDdsY=; b=qBfA4/WahtXoE9hmQJ1wcKQGkacxh5A9qIm+LlIL/rNwEISdpy+NHRGAntzjuhRwwB 2loEnieeKzEu8GipUgkMbVDwHSBha62OfS5vCG5VvXQHEXt0yrh/9m79gFvpEpeYPTj+ tZTO5zH1HyBLUJtk3PqVZCnWZQ7Ezx5PTGtYoPT2ErNB802R1XgpRGz3S8NHRlcPm4a8 UCjF9LgraH3xXo0fbJIMGJbeT8JQL9v7omBOpSB80B/rjQo5O84SVeEmRqc7NY3LkOUf UTLeyPsMM5w9ZrnDzng/o9qPCqRwhSRd/HVXdKSl+73Dk6E+FWXvtYI/DAspPycYSfpW nS5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=aOiwQjF2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si1558679ejm.51.2019.11.07.07.10.03; Thu, 07 Nov 2019 07:10:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=aOiwQjF2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389275AbfKGPJ6 (ORCPT + 26 others); Thu, 7 Nov 2019 10:09:58 -0500 Received: from conuserg-10.nifty.com ([210.131.2.77]:63494 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729985AbfKGPJ5 (ORCPT ); Thu, 7 Nov 2019 10:09:57 -0500 Received: from grover.flets-west.jp (softbank126021098169.bbtec.net [126.21.98.169]) (authenticated) by conuserg-10.nifty.com with ESMTP id xA7F9lnE027691; Fri, 8 Nov 2019 00:09:48 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com xA7F9lnE027691 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1573139389; bh=j+Cvt6seYHFvw2RmLOUQxrYQHSymidnwSWT4pOwDdsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aOiwQjF2KC0JtUBdPd/6aFdwBgh2XMjwtnNOmwUVxMk3WkicJKyDS2Tk08WJXhwcO ujwaQ1opOQjDaCgJbA3EcgrmcHGsnZOsxtTbq5PvyWJ6c119vmcihQCKUiLCy/B99v Ncuo2Q16YCWFxhZTPIdL4TOCsi0hwbupcj/dUhsJwmH3w3xKKA2sROC+H1Op2ovlJL rNjTcjNKUAY/lyB3cI2PPA9hE7u7e/RB1ugM1PQM/dIqH6HO6zN36u5PeEeKoqf4Td bAseMh+RlFtMalEL4wMSmaj9zn5hLq/tiG/y/nRW/n0/qT+IyneGLjxPbJFmXd0INS amxIvZYr8yDRw== X-Nifty-SrcIP: [126.21.98.169] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] kbuild: rename any-prereq to newer-prereqs Date: Fri, 8 Nov 2019 00:09:45 +0900 Message-Id: <20191107150945.4513-2-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191107150945.4513-1-yamada.masahiro@socionext.com> References: <20191107150945.4513-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GNU Make manual says: $? The names of all the prerequisites that are newer than the target, with spaces between them. To reflect this, rename any-prereq to newer-prereqs, which is clearer and more intuitive. Signed-off-by: Masahiro Yamada --- scripts/Kbuild.include | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index b3a1189ec3d9..79713bd48a1e 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -210,17 +210,17 @@ endif # (needed for the shell) make-cmd = $(call escsq,$(subst $(pound),$$(pound),$(subst $$,$$$$,$(cmd_$(1))))) -# Find any prerequisites that is newer than target or that does not exist. +# Find any prerequisites that are newer than target or that do not exist. # PHONY targets skipped in both cases. -any-prereq = $(filter-out $(PHONY),$?) +newer-prereqs = $(filter-out $(PHONY),$?) # Execute command if command has changed or prerequisite(s) are updated. -if_changed = $(if $(any-prereq)$(cmd-check), \ +if_changed = $(if $(newer-prereqs)$(cmd-check), \ $(cmd); \ printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd, @:) # Execute the command and also postprocess generated .d dependencies file. -if_changed_dep = $(if $(any-prereq)$(cmd-check),$(cmd_and_fixdep),@:) +if_changed_dep = $(if $(newer-prereqs)$(cmd-check),$(cmd_and_fixdep),@:) cmd_and_fixdep = \ $(cmd); \ @@ -230,7 +230,7 @@ cmd_and_fixdep = \ # Usage: $(call if_changed_rule,foo) # Will check if $(cmd_foo) or any of the prerequisites changed, # and if so will execute $(rule_foo). -if_changed_rule = $(if $(any-prereq)$(cmd-check),$(rule_$(1)),@:) +if_changed_rule = $(if $(newer-prereqs)$(cmd-check),$(rule_$(1)),@:) ### # why - tell why a target got built @@ -255,7 +255,7 @@ ifeq ($(KBUILD_VERBOSE),2) why = \ $(if $(filter $@, $(PHONY)),- due to target is PHONY, \ $(if $(wildcard $@), \ - $(if $(any-prereq),- due to: $(any-prereq), \ + $(if $(newer-prereqs),- due to: $(newer-prereqs), \ $(if $(cmd-check), \ $(if $(cmd_$@),- due to command line change, \ $(if $(filter $@, $(targets)), \