[2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

Message ID 20191114093950.4101-3-tomi.valkeinen@ti.com
State New
Headers show
Series
  • Untitled series #24987
Related show

Commit Message

Tomi Valkeinen Nov. 14, 2019, 9:39 a.m.
panel-simple now handled panel osd070t1718-19ts, and we no longer need
the panel timings in the DT file. So remove them.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts  | 16 ----------------
 arch/arm/boot/dts/am43x-epos-evm.dts | 16 ----------------
 2 files changed, 32 deletions(-)

Comments

Tomi Valkeinen Jan. 13, 2020, 12:01 p.m. | #1
On 12/12/2019 22:35, Laurent Pinchart wrote:
> Hi Tomi,

> 

> On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote:

>> On 11/12/2019 18:53, Tony Lindgren wrote:

>>> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [191202 13:05]:

>>>> Hi Tomi,

>>>>

>>>> Thank you for the patch.

>>>>

>>>> On Thu, Nov 14, 2019 at 11:39:49AM +0200, Tomi Valkeinen wrote:

>>>>> panel-simple now handled panel osd070t1718-19ts, and we no longer need

>>>>> the panel timings in the DT file. So remove them.

>>>>

>>>> Should you in that case drop the panel-dpi compatible string too, as the

>>>> panel-dpi bindings require panel timings in DT ?

>>>

>>> Yeah sounds like if panel-dpi is no longer usable for this device it

>>> should be dropped from the compatible list.

>>

>> Ok, I agree.

>>

>> Looking at the dts files, panel-dpi is used in a bunch of boards. But

>> we even have 3 dts files with panel-dpi, without the detailed panel

>> model in compatible...

>>

>> Fixing those will break the compatibility with old dtbs and new

>> kernel, unless we add timings-from-dt to a panel driver that handles

>> panel-dpi.

> 

> I know, and I don't have a perfect answer for this :-( I don't see a

> third option, it's either breaking DT backward compatibility or adding

> timings parsing to a panel driver (either a new panel-dpi driver or to

> panel-simple). What's your preferred option ?


Hmm, I just realized that changing these will break omapfb. It relies on panel-dpi and timings from 
DT...

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 811c8cae315b..040403049cea 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -91,22 +91,6 @@ 
 
 		backlight = <&lcd_bl>;
 
-		panel-timing {
-			clock-frequency = <33000000>;
-			hactive = <800>;
-			vactive = <480>;
-			hfront-porch = <210>;
-			hback-porch = <16>;
-			hsync-len = <30>;
-			vback-porch = <10>;
-			vfront-porch = <22>;
-			vsync-len = <13>;
-			hsync-active = <0>;
-			vsync-active = <0>;
-			de-active = <1>;
-			pixelclk-active = <1>;
-		};
-
 		port {
 			lcd_in: endpoint {
 				remote-endpoint = <&dpi_out>;
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index 078cb473fa7d..330fce060e8b 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -47,22 +47,6 @@ 
 
 		backlight = <&lcd_bl>;
 
-		panel-timing {
-			clock-frequency = <33000000>;
-			hactive = <800>;
-			vactive = <480>;
-			hfront-porch = <210>;
-			hback-porch = <16>;
-			hsync-len = <30>;
-			vback-porch = <10>;
-			vfront-porch = <22>;
-			vsync-len = <13>;
-			hsync-active = <0>;
-			vsync-active = <0>;
-			de-active = <1>;
-			pixelclk-active = <1>;
-		};
-
 		port {
 			lcd_in: endpoint {
 				remote-endpoint = <&dpi_out>;