[3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge

Message ID 20191114093950.4101-4-tomi.valkeinen@ti.com
State New
Headers show
Series
  • Untitled series #24987
Related show

Commit Message

Tomi Valkeinen Nov. 14, 2019, 9:39 a.m.
The panel datasheet says that the panel samples at falling edge, but
does not say anything about h/v sync signals. Testing shows that if the
sync signals are driven on falling edge, the picture on the panel will
be slightly shifted right.

Setting sync drive edge to the same as data drive edge fixes this issue.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Tomi Valkeinen Jan. 13, 2020, 12:04 p.m. | #1
Hi Thierry,

On 02/12/2019 15:07, Laurent Pinchart wrote:
> Hi Tomi,

> 

> Thank you for the patch.

> 

> On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:

>> The panel datasheet says that the panel samples at falling edge, but

>> does not say anything about h/v sync signals. Testing shows that if the

>> sync signals are driven on falling edge, the picture on the panel will

>> be slightly shifted right.

>>

>> Setting sync drive edge to the same as data drive edge fixes this issue.

>>

>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> 

> I don't have access to the documentation, but this makes sense, so

> 

> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> 

>> ---

>>   drivers/gpu/drm/panel/panel-simple.c | 3 ++-

>>   1 file changed, 2 insertions(+), 1 deletion(-)

>>

>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

>> index 5d487686d25c..0784536ae6af 100644

>> --- a/drivers/gpu/drm/panel/panel-simple.c

>> +++ b/drivers/gpu/drm/panel/panel-simple.c

>> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {

>>   		.height = 91,

>>   	},

>>   	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,

>> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |

>> +		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,

>>   	.connector_type = DRM_MODE_CONNECTOR_DPI,

>>   };

>>   

> 


Can you pick this one up?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Tomi Valkeinen Feb. 10, 2020, 8:15 a.m. | #2
Hi Thierry,

On 02/12/2019 15:07, Laurent Pinchart wrote:
> Hi Tomi,

> 

> Thank you for the patch.

> 

> On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:

>> The panel datasheet says that the panel samples at falling edge, but

>> does not say anything about h/v sync signals. Testing shows that if the

>> sync signals are driven on falling edge, the picture on the panel will

>> be slightly shifted right.

>>

>> Setting sync drive edge to the same as data drive edge fixes this issue.

>>

>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> 

> I don't have access to the documentation, but this makes sense, so

> 

> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> 

>> ---

>>   drivers/gpu/drm/panel/panel-simple.c | 3 ++-

>>   1 file changed, 2 insertions(+), 1 deletion(-)

>>

>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

>> index 5d487686d25c..0784536ae6af 100644

>> --- a/drivers/gpu/drm/panel/panel-simple.c

>> +++ b/drivers/gpu/drm/panel/panel-simple.c

>> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {

>>   		.height = 91,

>>   	},

>>   	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,

>> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |

>> +		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,

>>   	.connector_type = DRM_MODE_CONNECTOR_DPI,

>>   };


Can this be merged?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg Feb. 14, 2020, 9:39 p.m. | #3
Hi Tomi.

On Mon, Feb 10, 2020 at 10:15:33AM +0200, Tomi Valkeinen wrote:
> Hi Thierry,

> 

> On 02/12/2019 15:07, Laurent Pinchart wrote:

> > Hi Tomi,

> > 

> > Thank you for the patch.

> > 

> > On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:

> > > The panel datasheet says that the panel samples at falling edge, but

> > > does not say anything about h/v sync signals. Testing shows that if the

> > > sync signals are driven on falling edge, the picture on the panel will

> > > be slightly shifted right.

> > > 

> > > Setting sync drive edge to the same as data drive edge fixes this issue.

> > > 

> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> > 

> > I don't have access to the documentation, but this makes sense, so

> > 

> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > 

> > > ---

> > >   drivers/gpu/drm/panel/panel-simple.c | 3 ++-

> > >   1 file changed, 2 insertions(+), 1 deletion(-)

> > > 

> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

> > > index 5d487686d25c..0784536ae6af 100644

> > > --- a/drivers/gpu/drm/panel/panel-simple.c

> > > +++ b/drivers/gpu/drm/panel/panel-simple.c

> > > @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {

> > >   		.height = 91,

> > >   	},

> > >   	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,

> > > -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

> > > +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |

> > > +		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,

> > >   	.connector_type = DRM_MODE_CONNECTOR_DPI,

> > >   };

> 

> Can this be merged?


I have lost the original mail.
Can you re-send or provide a patchwork pointer or similar.
Then I will apply.

PS. Mail had been stuck in my spam quarantine so did not get it until
now.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Tomi Valkeinen Feb. 21, 2020, 10:43 a.m. | #4
Hi Sam,

On 14/02/2020 23:39, Sam Ravnborg wrote:
> Hi Tomi.

> 

> On Mon, Feb 10, 2020 at 10:15:33AM +0200, Tomi Valkeinen wrote:

>> Hi Thierry,

>>

>> On 02/12/2019 15:07, Laurent Pinchart wrote:

>>> Hi Tomi,

>>>

>>> Thank you for the patch.

>>>

>>> On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:

>>>> The panel datasheet says that the panel samples at falling edge, but

>>>> does not say anything about h/v sync signals. Testing shows that if the

>>>> sync signals are driven on falling edge, the picture on the panel will

>>>> be slightly shifted right.

>>>>

>>>> Setting sync drive edge to the same as data drive edge fixes this issue.

>>>>

>>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

>>>

>>> I don't have access to the documentation, but this makes sense, so

>>>

>>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>>>

>>>> ---

>>>>    drivers/gpu/drm/panel/panel-simple.c | 3 ++-

>>>>    1 file changed, 2 insertions(+), 1 deletion(-)

>>>>

>>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

>>>> index 5d487686d25c..0784536ae6af 100644

>>>> --- a/drivers/gpu/drm/panel/panel-simple.c

>>>> +++ b/drivers/gpu/drm/panel/panel-simple.c

>>>> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {

>>>>    		.height = 91,

>>>>    	},

>>>>    	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,

>>>> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

>>>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |

>>>> +		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,

>>>>    	.connector_type = DRM_MODE_CONNECTOR_DPI,

>>>>    };

>>

>> Can this be merged?

> 

> I have lost the original mail.

> Can you re-send or provide a patchwork pointer or similar.

> Then I will apply.


Here are lore and patchwork links. Note that the first two patches in the series have already been handled.

https://lore.kernel.org/dri-devel/20191114093950.rT5m86Xh0-a9FZGq7JipQ3O3vldctJYcvRdhxUMGBVE@z/#t

https://patchwork.freedesktop.org/series/69459/

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg Feb. 22, 2020, 12:16 p.m. | #5
Hi Tomi.

> >>>> +++ b/drivers/gpu/drm/panel/panel-simple.c

> >>>> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {

> >>>>    		.height = 91,

> >>>>    	},

> >>>>    	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,

> >>>> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

> >>>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |

> >>>> +		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,

> >>>>    	.connector_type = DRM_MODE_CONNECTOR_DPI,

> >>>>    };

> >>

> >> Can this be merged?

> > 

> > I have lost the original mail.

> > Can you re-send or provide a patchwork pointer or similar.

> > Then I will apply.

> 

> Here are lore and patchwork links. Note that the first two patches in the series have already been handled.

> 

> https://lore.kernel.org/dri-devel/20191114093950.rT5m86Xh0-a9FZGq7JipQ3O3vldctJYcvRdhxUMGBVE@z/#t

> 

> https://patchwork.freedesktop.org/series/69459/


Thanks for the pointers. It is now applied to drm-misc-next.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5d487686d25c..0784536ae6af 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2397,7 +2397,8 @@  static const struct panel_desc osddisplays_osd070t1718_19ts = {
 		.height = 91,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
-	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
+		DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
 	.connector_type = DRM_MODE_CONNECTOR_DPI,
 };