From patchwork Fri Nov 22 10:52:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180024 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp64470ilf; Fri, 22 Nov 2019 03:14:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxpYI/7n4LixGyEeKV15KG4BQYpMUjrOuo0fQtj1ICxa3KYqHE+ZkpeghLbMKN4uKU8sFib X-Received: by 2002:a17:906:1d02:: with SMTP id n2mr21219159ejh.219.1574421281073; Fri, 22 Nov 2019 03:14:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421281; cv=none; d=google.com; s=arc-20160816; b=FqcJ3h9Y00f0bTcknTW6j4YwSWtRbKcXNHcYXntYAn7K4yroU28n9Ti7KfWlrBpSIl 50Kfj9euXZ0PnPiDec4396mU268BLtIEXt2Rd/woSDdgJWyZUkJXn7y4ROmP5eivTM7H rLrrZj3dX23gHIyuT1WJ8QQXFU2tenVil3lOIgsNbSjKfskFu7W/f50VIOEdTDgSYlKj 0fLB+3oTGyrZq6cstOT4yASnq5J8/rGfO471tV+VEVBbV7CzzdIak3n2kfJjy0AwLyBd KKWuDhRl3De+Wm3aRKBkRzXn6vxaYo4UzqgUcIyL/h18KW61u+jzXUwGiQmjDxrwHrJ4 nl2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=7eQ77p+yZoA07vPJ5MQhHwgPGskB4qfhyE5XsEtx6sE=; b=BDMPvGRT1831Fe0Q9nBHYYa3ERIUxXPJZUI3FVFJt2rqQ7/eX9aQ+oUGkcDwMdhPIi Gjj1IG72i7/B35D4xAv6Qy9VA/73c8LUZT0nUJMv0uLtjb4oZxdxr0f5QNRKcb6k0FvG akGxFmCz6TgLAUN4Kto8zQM59iNme6R0W7iDxTDvDCojE45xgWAoK2MgH8bzyNuA4WnV PuAdqYG0hPrJLh4aYgBRQSRMgjjm4BCWmdOKM52GSumbrcXZJQ8ERZjgq2pWjaxY2ra1 /XDtL/agEKGpdLmuEeksk1cTL4zFcGK3gpemoQX8O0iYQRuSRgGTnx5PAGfONbPP4Sep lhrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=his3mcjn; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ce3si5005378edb.441.2019.11.22.03.14.40; Fri, 22 Nov 2019 03:14:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=his3mcjn; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730431AbfKVLOg (ORCPT + 15 others); Fri, 22 Nov 2019 06:14:36 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34057 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727890AbfKVKx3 (ORCPT ); Fri, 22 Nov 2019 05:53:29 -0500 Received: by mail-wm1-f66.google.com with SMTP id j18so9950944wmk.1 for ; Fri, 22 Nov 2019 02:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=7eQ77p+yZoA07vPJ5MQhHwgPGskB4qfhyE5XsEtx6sE=; b=his3mcjnfWoBpqB2zVQxlSl8g0l8Wx1tuGrDrGxy54p0d5QN1DRbW768D9pe7ifTba PM4qEQ98qx9/qRxJz65ZMDowBTAF4Gyy605grLq8F4li20M6QlZCINDWhjOzq0SdR44G TZbKOrlqWLKgdLLeIq6Lt7yO6VLPGcLlDpZLnkxaxKukjckK6nR6uf9DNbpHCyJUSWTU txBZji6jk6ozACvcK6upKCIFg3XwIhWllnRSm/kWX+WUUaoHwHNS/JHaTiYv2AzAd81v YDeB0ydCR5OmkI5SLcWMLD/XDUXpyEyzHapMInbTkgKNff1/S2Rz01v26Ks9VWEZARnD VJng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7eQ77p+yZoA07vPJ5MQhHwgPGskB4qfhyE5XsEtx6sE=; b=ajF46L01l5yZnT2Y+FYZxYqw6QXZbCQNEvH8eSleL0Dz1mrz3eoITFO9IeREsCQ8W2 Soh7aqqC6UrYUnNUAkkNsYZquuF3V48P0D2ZR8Y5lAWZwWoghv7wAhZZXxFxn3gx/G6J CXwM+nHOiZz5YhM5eh40aiJ7JigalId86DfRDKlpvi7a39j9kn3/pBXnkbacwfa22PUY EjkvrIwzd4uFJ1cgugiZBCCygOz4D6ucm/kH21euRV2LOVEVAAhvv35VGe4tPDLXcO9G V+zzABOr2sXdVvR3MKqSNMnb1gPtQ9c7yOnhNUusEnu+lzxVw1aIm7kLhajoBOtmF6hm 4nbw== X-Gm-Message-State: APjAAAWnp3tFyD0pFpqIlweIQZ/koH29vJXkt+J8d2cfO3h3J0mc1q75 VajuWeUdWxldwvzeD1Gbb+B2uPjqUpE= X-Received: by 2002:a1c:a347:: with SMTP id m68mr504530wme.129.1574420008411; Fri, 22 Nov 2019 02:53:28 -0800 (PST) Received: from localhost.localdomain ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id o1sm7444087wrs.50.2019.11.22.02.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 02:53:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, gregkh@google.com, stable@vger.kernel.org Subject: [PATCH 4.9 5/8] bcache: silence static checker warning Date: Fri, 22 Nov 2019 10:52:50 +0000 Message-Id: <20191122105253.11375-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122105253.11375-1-lee.jones@linaro.org> References: <20191122105253.11375-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit da22f0eea555baf9b0a84b52afe56db2052cfe8d ] In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter Reviewed-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Lee Jones --- drivers/md/bcache/super.c | 3 --- 1 file changed, 3 deletions(-) -- 2.24.0 diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index c5bc3e5e921e..3e113be966fe 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1397,9 +1397,6 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; - if (!c) - closure_return(cl); - bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal);