From patchwork Wed Nov 27 07:21:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180258 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp5735655ilf; Tue, 26 Nov 2019 23:22:12 -0800 (PST) X-Google-Smtp-Source: APXvYqy07WKp+6tEOx8wL45xnMZh5GAateWV1jZ53bmIU8BohO454ykO+NWk2VzmT05/EUql23r5 X-Received: by 2002:a17:906:52c3:: with SMTP id w3mr48816592ejn.122.1574839332656; Tue, 26 Nov 2019 23:22:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574839332; cv=none; d=google.com; s=arc-20160816; b=S8x1hv+zktYVkvYnAwqL0v3IGs6lk0eolcdjNCwfMMMewTPBoXhsMvLlXjLYL9AGS3 Ahz950/37HA0ZrubkI6wkjkJciHtiGgditCYN0cKkwO/fr8TmzeSbTIVAJLZorQqkKil c3LP79RmdfCunXbkgbHPm9lpaa51Zyz2tYh763IpFm9uIZbOgQKyqzAt3L48mH6y8pA8 zs3S9GiF3607o5ZCbp7eA8+Uot37igoDjzfD8xm+QOo0fwIeBmIYXgZ3uWq5fqZrta7X ADofDHQPChMl8qXHGzYY1RC08r15inG2RmmzAzvDhMAkCEF+yVwYOPGhlalfbx5Jvvyc r8uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=EwOfwwiNckMuQzPVj8mAR4X16hKKAPeuk3yKLlec5YI=; b=upcJkE2IV9ZKrk2FHP0Juf7nIOpR3Z0L5NlBl67SQgPKTyr+lZF5LQ6CBqX3ZJDIrC l39GUGkIyC3xJK1xI8ksmZxs79s9A80Q9U8S5BccKMWqUXdB6bddehCjbhzFghmqs1tv NARQTl8/xcbwW9Kt/5++qUKkJV/M+ucarBnp/Me/nKPnYF39gVNn2l3RgFc4Veh7JQyM 5bfqdMytVCGgwg8hkwd+biIt6YstwRRznvqdt7OF42MzVfYeNFl+1peVgVbZEe5nX8we QSw2k2O6AFIowvQvLHpGcktBMYDuw4J7RXJu253OquAyNe8PwhOY5lUOOUM++AbcheBS kmkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V3I8YXvN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m19si69058ejc.66.2019.11.26.23.22.12; Tue, 26 Nov 2019 23:22:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V3I8YXvN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726383AbfK0HWM (ORCPT + 15 others); Wed, 27 Nov 2019 02:22:12 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35762 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbfK0HWL (ORCPT ); Wed, 27 Nov 2019 02:22:11 -0500 Received: by mail-wr1-f65.google.com with SMTP id s5so25353732wrw.2 for ; Tue, 26 Nov 2019 23:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=EwOfwwiNckMuQzPVj8mAR4X16hKKAPeuk3yKLlec5YI=; b=V3I8YXvNor+nCa7b1xHp+CvzeKniVPoGLykjf+XAcuJKfd9p9+fkdjScDkbTF3xYv/ QyEmkSOVx3fYUurIM1VUfgvHgX4GMMswAiGOGZkTj8fEuOwZjGAz/JDlYnFHLjZuWOHX duJFN8wQOzt9RxmmFgLnC0CO7QuYb2p6ORpI9u8oDK2BV6KU6p/iA+j9BAKFgnc//lxn 8hLTx0wclZCdf/XjqWvytwvojGUqjOLYvqNc21kHJ+9IvLV5w3s/kQGHe4BwSV2unXH5 URmFHvdKern3tvubdwEu4YjMcSTFaFJWsqVPQvCusDEjdO9pn6Mx1lk/QW7ofucp3KgP DABg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EwOfwwiNckMuQzPVj8mAR4X16hKKAPeuk3yKLlec5YI=; b=UZ2OBcGKMNCHTXNLpGsn7yCzNmTp02X9M/AWG/2XA3I1i8TXAeBSlHuCiAiBYbK7+I /h/bdqTTtDGolEp78M7KUVpbIFNy6V6HzMqjav10N67SMfN0w/xG94RoNuiGhmRgcCOP yYOa605EhWO+d8GjL99abSScDMrXIVpFlzLpbS/XqKKuDzQk5GnvzXrFYuDV+jAW5+vt BHHactcQ9/9F7ibGMxH5EFnjhW8FDxixIMwo2RvBvdd9WsnubaQFJl4d3foUB1/6DH6S KrnzN9ROQgU2vw/PRXvmndZchmMM//KDq8vBA4nCWH2Wicww0TmCplY2XSdSV9jfG3J2 3uAQ== X-Gm-Message-State: APjAAAUwSKvl/EVU4P+h5UNS1jPIVxEfr3tTZE2DOKfodQIa0snybeOS CaTROLrPcMakd2cjn7ePB1QGcyTm5+I= X-Received: by 2002:adf:e40e:: with SMTP id g14mr19450781wrm.264.1574839327516; Tue, 26 Nov 2019 23:22:07 -0800 (PST) Received: from localhost.localdomain ([95.149.164.101]) by smtp.gmail.com with ESMTPSA id e16sm17983130wrj.80.2019.11.26.23.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 23:22:07 -0800 (PST) From: Lee Jones To: stable@vger.kernel.org Subject: [PATCH 4.9 5/6] dm: use blk_set_queue_dying() in __dm_destroy() Date: Wed, 27 Nov 2019 07:21:43 +0000 Message-Id: <20191127072144.30537-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127072144.30537-1-lee.jones@linaro.org> References: <20191127072144.30537-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bart Van Assche [ Upstream commit 2e91c3694181dc500faffec16c5aaa0ac5e15449 ] After QUEUE_FLAG_DYING has been set any code that is waiting in get_request() should be woken up. But to get this behaviour blk_set_queue_dying() must be used instead of only setting QUEUE_FLAG_DYING. Signed-off-by: Bart Van Assche Signed-off-by: Mike Snitzer Signed-off-by: Lee Jones --- drivers/md/dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.24.0 diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 2ffe7db75acb..36e6221fabab 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1946,9 +1946,7 @@ static void __dm_destroy(struct mapped_device *md, bool wait) set_bit(DMF_FREEING, &md->flags); spin_unlock(&_minor_lock); - spin_lock_irq(q->queue_lock); - queue_flag_set(QUEUE_FLAG_DYING, q); - spin_unlock_irq(q->queue_lock); + blk_set_queue_dying(q); if (dm_request_based(md) && md->kworker_task) kthread_flush_worker(&md->kworker);