[1/3,v3] spi: fsl: Fix GPIO descriptor support

Message ID 20191128083718.39177-1-linus.walleij@linaro.org
State Accepted
Commit f106904968e2a075e64653b9b79dda9f0f070ab5
Headers show
Series
  • [1/3,v3] spi: fsl: Fix GPIO descriptor support
Related show

Commit Message

Linus Walleij Nov. 28, 2019, 8:37 a.m.
This makes the driver actually support looking up GPIO
descriptor. A coding mistake in the initial descriptor
support patch was that it was failing to turn on the very
feature it was implementing. Mea culpa.

Cc: Christophe Leroy <christophe.leroy@c-s.fr>
Reported-by: Christophe Leroy <christophe.leroy@c-s.fr>
Fixes: 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v2->v3:
- Resend with the rest of the patches.
ChangeLog v1->v2:
- New patch fixing this specific problem.
---
 drivers/spi/spi-fsl-spi.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.23.0

Comments

Christophe Leroy Nov. 28, 2019, 12:14 p.m. | #1
Le 28/11/2019 à 09:37, Linus Walleij a écrit :
> This makes the driver actually support looking up GPIO

> descriptor. A coding mistake in the initial descriptor

> support patch was that it was failing to turn on the very

> feature it was implementing. Mea culpa.

> 

> Cc: Christophe Leroy <christophe.leroy@c-s.fr>

> Reported-by: Christophe Leroy <christophe.leroy@c-s.fr>

> Fixes: 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors")

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>


> ---

> ChangeLog v2->v3:

> - Resend with the rest of the patches.

> ChangeLog v1->v2:

> - New patch fixing this specific problem.

> ---

>   drivers/spi/spi-fsl-spi.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c

> index 114801a32371..c87e9c4506c2 100644

> --- a/drivers/spi/spi-fsl-spi.c

> +++ b/drivers/spi/spi-fsl-spi.c

> @@ -611,6 +611,7 @@ static struct spi_master * fsl_spi_probe(struct device *dev,

>   	master->setup = fsl_spi_setup;

>   	master->cleanup = fsl_spi_cleanup;

>   	master->transfer_one_message = fsl_spi_do_one_msg;

> +	master->use_gpio_descriptors = true;

>   

>   	mpc8xxx_spi = spi_master_get_devdata(master);

>   	mpc8xxx_spi->max_bits_per_word = 32;

>

Patch

diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c
index 114801a32371..c87e9c4506c2 100644
--- a/drivers/spi/spi-fsl-spi.c
+++ b/drivers/spi/spi-fsl-spi.c
@@ -611,6 +611,7 @@  static struct spi_master * fsl_spi_probe(struct device *dev,
 	master->setup = fsl_spi_setup;
 	master->cleanup = fsl_spi_cleanup;
 	master->transfer_one_message = fsl_spi_do_one_msg;
+	master->use_gpio_descriptors = true;
 
 	mpc8xxx_spi = spi_master_get_devdata(master);
 	mpc8xxx_spi->max_bits_per_word = 32;