[v6] drm/panel: Add generic DSI display controller YAML bindings

Message ID 20191128090726.51107-1-linus.walleij@linaro.org
State Accepted
Commit dc190678534ee0f9042a65db1613ab1e59582bff
Headers show
Series
  • [v6] drm/panel: Add generic DSI display controller YAML bindings
Related show

Commit Message

Linus Walleij Nov. 28, 2019, 9:07 a.m.
This adds a starting point for processing and defining generic
bindings used by DSI display controllers and panels attached to
the virtual DSI ports.

Cc: Stephan Gerhold <stephan@gerhold.net>
Cc: devicetree@vger.kernel.org
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
ChangeLog v5->v6:
- Rename subject to pertain to DSI display controllers in general.
- Change some of the wording in the DSI controller description text,
  making it clear that the binding pertains to the combination of a
  DSI controller with at least one panel attached.
- Add a proper compiling example.
ChangeLog v4->v5:
- Drop the example.
- I still have a vert annoying error message in the Sony
  panel bindings that uses this schema:
  sony,acx424akp.example.dt.yaml: panel@0: $nodename:0: 'panel@0' does not match '^dsi-controller(@.*)?$'
  As this is modeled very closely to
  Documentation/devicetree/bindings/net/mdio.yaml
  and that one doesn't emit this type of warning for its ethernet-phy@0
  etc I am pretty much clueless and just can't see what the problem
  is.
- If I can't figure this out the only viable next step is to drop the
  ambition to create yaml bindings simply because I'm unable to do
  it, and go back to traditional text bindings :(
ChangeLog v3->v4:
- Rename into display/dsi-controller.yaml
- Require a virtual channel number for the DSI panel, as
  DSI have this 2-bit virtual address field.
- Bring in some but not all properties from the existing MIPI
  DSI bindings. This schema can be used with simpler panels but
  not complex panels with multiple virtual channels for the
  moment. Let's handle it when we get there.
- Add an example.
ChangeLog v2->v3:
- Make a more complete DSI panel binding including the controller
  and its address-cells and size-cells and a pattern for the panel
  nodes. The panel is one per DSI master, the reg property is
  compulsory but should always be 0 (as far as I can tell) as
  only one panel can be connected. The bus doesn't really have
  any addresses for the panel, the address/reg notation seems
  to be cargo-culted from the port graphs and is not necessary
  to parse some device trees, it is used to tell whether the
  node is a panel or not rather than any addressing.
- I have no idea how many displays you can daisychain on a single
  DSI master, I just guess 15 will be enough. The MIPI-specs
  are memberwalled. Someone who knows can tell perhaps?
ChangeLog v1->v2:
- New patch after feedback.
---
 .../bindings/display/dsi-controller.yaml      | 91 +++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/dsi-controller.yaml

-- 
2.23.0

Comments

Rob Herring Dec. 2, 2019, 10:28 p.m. | #1
On Thu, Nov 28, 2019 at 3:07 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>

> This adds a starting point for processing and defining generic

> bindings used by DSI display controllers and panels attached to

> the virtual DSI ports.

>

> Cc: Stephan Gerhold <stephan@gerhold.net>

> Cc: devicetree@vger.kernel.org

> Suggested-by: Rob Herring <robh@kernel.org>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

> ChangeLog v5->v6:

> - Rename subject to pertain to DSI display controllers in general.

> - Change some of the wording in the DSI controller description text,

>   making it clear that the binding pertains to the combination of a

>   DSI controller with at least one panel attached.

> - Add a proper compiling example.

> ChangeLog v4->v5:

> - Drop the example.

> - I still have a vert annoying error message in the Sony

>   panel bindings that uses this schema:

>   sony,acx424akp.example.dt.yaml: panel@0: $nodename:0: 'panel@0' does not match '^dsi-controller(@.*)?$'

>   As this is modeled very closely to

>   Documentation/devicetree/bindings/net/mdio.yaml

>   and that one doesn't emit this type of warning for its ethernet-phy@0

>   etc I am pretty much clueless and just can't see what the problem

>   is.

> - If I can't figure this out the only viable next step is to drop the

>   ambition to create yaml bindings simply because I'm unable to do

>   it, and go back to traditional text bindings :(

> ChangeLog v3->v4:

> - Rename into display/dsi-controller.yaml

> - Require a virtual channel number for the DSI panel, as

>   DSI have this 2-bit virtual address field.

> - Bring in some but not all properties from the existing MIPI

>   DSI bindings. This schema can be used with simpler panels but

>   not complex panels with multiple virtual channels for the

>   moment. Let's handle it when we get there.

> - Add an example.

> ChangeLog v2->v3:

> - Make a more complete DSI panel binding including the controller

>   and its address-cells and size-cells and a pattern for the panel

>   nodes. The panel is one per DSI master, the reg property is

>   compulsory but should always be 0 (as far as I can tell) as

>   only one panel can be connected. The bus doesn't really have

>   any addresses for the panel, the address/reg notation seems

>   to be cargo-culted from the port graphs and is not necessary

>   to parse some device trees, it is used to tell whether the

>   node is a panel or not rather than any addressing.

> - I have no idea how many displays you can daisychain on a single

>   DSI master, I just guess 15 will be enough. The MIPI-specs

>   are memberwalled. Someone who knows can tell perhaps?

> ChangeLog v1->v2:

> - New patch after feedback.

> ---

>  .../bindings/display/dsi-controller.yaml      | 91 +++++++++++++++++++

>  1 file changed, 91 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/dsi-controller.yaml


I'll let you apply to drm-misc.

Reviewed-by: Rob Herring <robh@kernel.org>

Patch

diff --git a/Documentation/devicetree/bindings/display/dsi-controller.yaml b/Documentation/devicetree/bindings/display/dsi-controller.yaml
new file mode 100644
index 000000000000..fd986c36c737
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/dsi-controller.yaml
@@ -0,0 +1,91 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/dsi-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common Properties for DSI Display Panels
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+description: |
+  This document defines device tree properties common to DSI, Display
+  Serial Interface controllers and attached panels. It doesn't constitute
+  a device tree binding specification by itself but is meant to be referenced
+  by device tree bindings.
+
+  When referenced from panel device tree bindings the properties defined in
+  this document are defined as follows. The panel device tree bindings are
+  responsible for defining whether each property is required or optional.
+
+  Notice: this binding concerns DSI panels connected directly to a master
+  without any intermediate port graph to the panel. Each DSI master
+  can control one to four virtual channels to one panel. Each virtual
+  channel should have a node "panel" for their virtual channel with their
+  reg-property set to the virtual channel number, usually there is just
+  one virtual channel, number 0.
+
+properties:
+  $nodename:
+    pattern: "^dsi-controller(@.*)?$"
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^panel@[0-3]$":
+    description: Panels connected to the DSI link
+    type: object
+
+    properties:
+      reg:
+        minimum: 0
+        maximum: 3
+        description:
+          The virtual channel number of a DSI peripheral. Must be in the range
+          from 0 to 3, as DSI uses a 2-bit addressing scheme. Some DSI
+          peripherals respond to more than a single virtual channel. In that
+          case the reg property can take multiple entries, one for each virtual
+          channel that the peripheral responds to.
+
+      clock-master:
+        type: boolean
+        description:
+           Should be enabled if the host is being used in conjunction with
+           another DSI host to drive the same peripheral. Hardware supporting
+           such a configuration generally requires the data on both the busses
+           to be driven by the same clock. Only the DSI host instance
+           controlling this clock should contain this property.
+
+      enforce-video-mode:
+        type: boolean
+        description:
+          The best option is usually to run a panel in command mode, as this
+          gives better control over the panel hardware. However for different
+          reasons like broken hardware, missing features or testing, it may be
+          useful to be able to force a command mode-capable panel into video
+          mode.
+
+    required:
+      - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    dsi-controller@a0351000 {
+        reg = <0xa0351000 0x1000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "sony,acx424akp";
+            reg = <0>;
+            vddi-supply = <&ab8500_ldo_aux1_reg>;
+            reset-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
+        };
+    };
+
+...