[v2,1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC

Message ID 20191129000827.650566-2-joel@jms.id.au
State New
Headers show
Series
  • reset: Add ast2600 support
Related show

Commit Message

Joel Stanley Nov. 29, 2019, 12:08 a.m.
The AST2600 has the same LPC layout as previous generation SoCs.

Signed-off-by: Joel Stanley <joel@jms.id.au>

---
v2: Fix cut and paste error in reset bindings
---
 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.24.0

Comments

Andrew Jeffery Dec. 1, 2019, 11:29 p.m. | #1
On Fri, 29 Nov 2019, at 10:38, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.

> 

> Signed-off-by: Joel Stanley <joel@jms.id.au>


Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Rob Herring Dec. 13, 2019, 9:42 p.m. | #2
On Fri, Nov 29, 2019 at 10:38:26AM +1030, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.

> 

> Signed-off-by: Joel Stanley <joel@jms.id.au>

> ---

> v2: Fix cut and paste error in reset bindings

> ---

>  Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--

>  1 file changed, 9 insertions(+), 2 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

> index 86446074e206..a5d89aa9a3c1 100644

> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

> @@ -46,6 +46,7 @@ Required properties

>  - compatible:	One of:

>  		"aspeed,ast2400-lpc", "simple-mfd"

>  		"aspeed,ast2500-lpc", "simple-mfd"

> +		"aspeed,ast2600-lpc", "simple-mfd"

>  

>  - reg:		contains the physical address and length values of the Aspeed

>                  LPC memory region.

> @@ -64,6 +65,7 @@ BMC Node

>  - compatible:	One of:

>  		"aspeed,ast2400-lpc-bmc"

>  		"aspeed,ast2500-lpc-bmc"

> +		"aspeed,ast2600-lpc-bmc"

>  

>  - reg:		contains the physical address and length values of the

>                  H8S/2168-compatible LPC controller memory region

> @@ -128,6 +130,7 @@ Required properties:

>  - compatible:	One of:

>  		"aspeed,ast2400-lpc-ctrl";

>  		"aspeed,ast2500-lpc-ctrl";

> +		"aspeed,ast2600-lpc-ctrl";

>  

>  - reg:		contains offset/length values of the host interface controller

>  		memory regions

> @@ -168,6 +171,7 @@ Required properties:

>  - compatible:	One of:

>  		"aspeed,ast2400-lhc";

>  		"aspeed,ast2500-lhc";

> +		"aspeed,ast2600-lhc";

>  

>  - reg:		contains offset/length values of the LHC memory regions. In the

>  		AST2400 and AST2500 there are two regions.

> @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.

>  

>  Required properties:

>  

> - - compatible:		"aspeed,ast2500-lpc-reset" or

> -			"aspeed,ast2400-lpc-reset"

> + - compatible:		One of:

> +			"aspeed,ast2400-reset";

> +			"aspeed,ast2500-reset";

> +			"aspeed,ast2600-reset";


Doesn't match what's in the driver.

Rob

Patch

diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
index 86446074e206..a5d89aa9a3c1 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
@@ -46,6 +46,7 @@  Required properties
 - compatible:	One of:
 		"aspeed,ast2400-lpc", "simple-mfd"
 		"aspeed,ast2500-lpc", "simple-mfd"
+		"aspeed,ast2600-lpc", "simple-mfd"
 
 - reg:		contains the physical address and length values of the Aspeed
                 LPC memory region.
@@ -64,6 +65,7 @@  BMC Node
 - compatible:	One of:
 		"aspeed,ast2400-lpc-bmc"
 		"aspeed,ast2500-lpc-bmc"
+		"aspeed,ast2600-lpc-bmc"
 
 - reg:		contains the physical address and length values of the
                 H8S/2168-compatible LPC controller memory region
@@ -128,6 +130,7 @@  Required properties:
 - compatible:	One of:
 		"aspeed,ast2400-lpc-ctrl";
 		"aspeed,ast2500-lpc-ctrl";
+		"aspeed,ast2600-lpc-ctrl";
 
 - reg:		contains offset/length values of the host interface controller
 		memory regions
@@ -168,6 +171,7 @@  Required properties:
 - compatible:	One of:
 		"aspeed,ast2400-lhc";
 		"aspeed,ast2500-lhc";
+		"aspeed,ast2600-lhc";
 
 - reg:		contains offset/length values of the LHC memory regions. In the
 		AST2400 and AST2500 there are two regions.
@@ -187,8 +191,11 @@  state of the LPC bus. Some systems may chose to modify this configuration.
 
 Required properties:
 
- - compatible:		"aspeed,ast2500-lpc-reset" or
-			"aspeed,ast2400-lpc-reset"
+ - compatible:		One of:
+			"aspeed,ast2400-reset";
+			"aspeed,ast2500-reset";
+			"aspeed,ast2600-reset";
+
  - reg:			offset and length of the IP in the LHC memory region
  - #reset-controller	indicates the number of reset cells expected