diff mbox

[2/4,V6] EXYNOS5: FDT: Add serial device node values

Message ID 1372065409-18412-3-git-send-email-rajeshwari.s@samsung.com
State Accepted
Commit 4603e8cf8b217be397559d9c9c0cf741e20efd8b
Headers show

Commit Message

Rajeshwari Shinde June 24, 2013, 9:16 a.m. UTC
This patch adds the device node required for serial driver

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
Changes in V2:
        - Changed the compatible string to "samsung,exynos4210-uart"
Changes in V3:
        - Added a alias console as we will support one at any point of time.
Changes in V4:
        - Rebased on latest u-boot-samsung tree.
Changes in V5:
        - Added device node for Snow board.
Changes in V6:
	- Rebased on latest u-boot-samsung branch.
 arch/arm/dts/exynos5250.dtsi              |   28 ++++++++++++++++++++++++++++
 board/samsung/dts/exynos5250-smdk5250.dts |    2 ++
 board/samsung/dts/exynos5250-snow.dts     |    2 ++
 3 files changed, 32 insertions(+), 0 deletions(-)

Comments

Minkyu Kang June 24, 2013, 10:16 a.m. UTC | #1
On 24/06/13 18:16, Rajeshwari Shinde wrote:
> This patch adds the device node required for serial driver
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> Changes in V2:
>         - Changed the compatible string to "samsung,exynos4210-uart"
> Changes in V3:
>         - Added a alias console as we will support one at any point of time.
> Changes in V4:
>         - Rebased on latest u-boot-samsung tree.
> Changes in V5:
>         - Added device node for Snow board.
> Changes in V6:
> 	- Rebased on latest u-boot-samsung branch.
>  arch/arm/dts/exynos5250.dtsi              |   28 ++++++++++++++++++++++++++++
>  board/samsung/dts/exynos5250-smdk5250.dts |    2 ++
>  board/samsung/dts/exynos5250-snow.dts     |    2 ++
>  3 files changed, 32 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
> index cee4fe8..1e14154 100644
> --- a/arch/arm/dts/exynos5250.dtsi
> +++ b/arch/arm/dts/exynos5250.dtsi
> @@ -202,4 +202,32 @@
>  		interrupts = <0 78 0>;
>  	};
>  
> +

please remove this extra line.

> +	serial@12C00000 {
> +		compatible = "samsung,exynos4210-uart";
> +		reg = <0x12C00000 0x100>;
> +		interrupts = <0 51 0>;
> +		id = <0>;
> +	};
> +
> +	serial@12C10000 {
> +		compatible = "samsung,exynos4210-uart";
> +		reg = <0x12C10000 0x100>;
> +		interrupts = <0 52 0>;
> +		id = <1>;
> +	};
> +
> +	serial@12C20000 {
> +		compatible = "samsung,exynos4210-uart";
> +		reg = <0x12C20000 0x100>;
> +		interrupts = <0 53 0>;
> +		id = <2>;
> +	};
> +
> +	serial@12C30000 {
> +		compatible = "samsung,exynos4210-uart";
> +		reg = <0x12C30000 0x100>;
> +		interrupts = <0 54 0>;
> +		id = <3>;
> +	};
>  };
> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
> index 93375a6..80ffe30 100644
> --- a/board/samsung/dts/exynos5250-smdk5250.dts
> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
> @@ -34,6 +34,8 @@
>  		mmc1 = "/mmc@12210000";
>  		mmc2 = "/mmc@12220000";
>  		mmc3 = "/mmc@12230000";
> +		serial0 = "/serial@12C30000";
> +		console = "/serial@12C30000";
>  	};
>  
>  	sromc@12250000 {
> diff --git a/board/samsung/dts/exynos5250-snow.dts b/board/samsung/dts/exynos5250-snow.dts
> index d167df9..fdc047a 100644
> --- a/board/samsung/dts/exynos5250-snow.dts
> +++ b/board/samsung/dts/exynos5250-snow.dts
> @@ -34,6 +34,8 @@
>  		mmc1 = "/mmc@12210000";
>  		mmc2 = "/mmc@12220000";
>  		mmc3 = "/mmc@12230000";
> +		serial0 = "/serial@12C30000";
> +		console = "/serial@12C30000";
>  	};
>  
>  	sound@12d60000 {
> 

Thanks,
Minkyu Kang.
Rajeshwari Birje June 24, 2013, 10:48 a.m. UTC | #2
Hi Minkyu Kang,

Thank you for comment

On Mon, Jun 24, 2013 at 3:46 PM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> On 24/06/13 18:16, Rajeshwari Shinde wrote:
>> This patch adds the device node required for serial driver
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>> Changes in V2:
>>         - Changed the compatible string to "samsung,exynos4210-uart"
>> Changes in V3:
>>         - Added a alias console as we will support one at any point of time.
>> Changes in V4:
>>         - Rebased on latest u-boot-samsung tree.
>> Changes in V5:
>>         - Added device node for Snow board.
>> Changes in V6:
>>       - Rebased on latest u-boot-samsung branch.
>>  arch/arm/dts/exynos5250.dtsi              |   28 ++++++++++++++++++++++++++++
>>  board/samsung/dts/exynos5250-smdk5250.dts |    2 ++
>>  board/samsung/dts/exynos5250-snow.dts     |    2 ++
>>  3 files changed, 32 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
>> index cee4fe8..1e14154 100644
>> --- a/arch/arm/dts/exynos5250.dtsi
>> +++ b/arch/arm/dts/exynos5250.dtsi
>> @@ -202,4 +202,32 @@
>>               interrupts = <0 78 0>;
>>       };
>>
>> +
>
> please remove this extra line.
>
Will correct this and send a new patchset.
>> +     serial@12C00000 {
>> +             compatible = "samsung,exynos4210-uart";
>> +             reg = <0x12C00000 0x100>;
>> +             interrupts = <0 51 0>;
>> +             id = <0>;
>> +     };
>> +
>> +     serial@12C10000 {
>> +             compatible = "samsung,exynos4210-uart";
>> +             reg = <0x12C10000 0x100>;
>> +             interrupts = <0 52 0>;
>> +             id = <1>;
>> +     };
>> +
>> +     serial@12C20000 {
>> +             compatible = "samsung,exynos4210-uart";
>> +             reg = <0x12C20000 0x100>;
>> +             interrupts = <0 53 0>;
>> +             id = <2>;
>> +     };
>> +
>> +     serial@12C30000 {
>> +             compatible = "samsung,exynos4210-uart";
>> +             reg = <0x12C30000 0x100>;
>> +             interrupts = <0 54 0>;
>> +             id = <3>;
>> +     };
>>  };
>> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
>> index 93375a6..80ffe30 100644
>> --- a/board/samsung/dts/exynos5250-smdk5250.dts
>> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
>> @@ -34,6 +34,8 @@
>>               mmc1 = "/mmc@12210000";
>>               mmc2 = "/mmc@12220000";
>>               mmc3 = "/mmc@12230000";
>> +             serial0 = "/serial@12C30000";
>> +             console = "/serial@12C30000";
>>       };
>>
>>       sromc@12250000 {
>> diff --git a/board/samsung/dts/exynos5250-snow.dts b/board/samsung/dts/exynos5250-snow.dts
>> index d167df9..fdc047a 100644
>> --- a/board/samsung/dts/exynos5250-snow.dts
>> +++ b/board/samsung/dts/exynos5250-snow.dts
>> @@ -34,6 +34,8 @@
>>               mmc1 = "/mmc@12210000";
>>               mmc2 = "/mmc@12220000";
>>               mmc3 = "/mmc@12230000";
>> +             serial0 = "/serial@12C30000";
>> +             console = "/serial@12C30000";
>>       };
>>
>>       sound@12d60000 {
>>
>
> Thanks,
> Minkyu Kang.
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
index cee4fe8..1e14154 100644
--- a/arch/arm/dts/exynos5250.dtsi
+++ b/arch/arm/dts/exynos5250.dtsi
@@ -202,4 +202,32 @@ 
 		interrupts = <0 78 0>;
 	};
 
+
+	serial@12C00000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C00000 0x100>;
+		interrupts = <0 51 0>;
+		id = <0>;
+	};
+
+	serial@12C10000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C10000 0x100>;
+		interrupts = <0 52 0>;
+		id = <1>;
+	};
+
+	serial@12C20000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C20000 0x100>;
+		interrupts = <0 53 0>;
+		id = <2>;
+	};
+
+	serial@12C30000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C30000 0x100>;
+		interrupts = <0 54 0>;
+		id = <3>;
+	};
 };
diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
index 93375a6..80ffe30 100644
--- a/board/samsung/dts/exynos5250-smdk5250.dts
+++ b/board/samsung/dts/exynos5250-smdk5250.dts
@@ -34,6 +34,8 @@ 
 		mmc1 = "/mmc@12210000";
 		mmc2 = "/mmc@12220000";
 		mmc3 = "/mmc@12230000";
+		serial0 = "/serial@12C30000";
+		console = "/serial@12C30000";
 	};
 
 	sromc@12250000 {
diff --git a/board/samsung/dts/exynos5250-snow.dts b/board/samsung/dts/exynos5250-snow.dts
index d167df9..fdc047a 100644
--- a/board/samsung/dts/exynos5250-snow.dts
+++ b/board/samsung/dts/exynos5250-snow.dts
@@ -34,6 +34,8 @@ 
 		mmc1 = "/mmc@12210000";
 		mmc2 = "/mmc@12220000";
 		mmc3 = "/mmc@12230000";
+		serial0 = "/serial@12C30000";
+		console = "/serial@12C30000";
 	};
 
 	sound@12d60000 {